Mahara

Code to generate charjs bar graph is not correct

Bug #1891554 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Unassigned
Mahara 20.10.0

Bug Description

The code in get_bar_graph_json() was not generating a bar graph correctly.

Also made the option 'showlegendcallback' so we can turn off the legend when we don't need it

Also made the Admin -> Report -> site overview page 'Most frequently used blocks in portfolio pages' list change from a list of top five to a horizontal bar graph of the top 10

Revision history for this message
Robert Lyon (robertl-9) wrote :

https://reviews.mahara.org/#/c/11136/

Changed in mahara:
milestone: none → 20.10.0
importance: Undecided → Medium
status: New → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11136
Committed: https://git.mahara.org/mahara/mahara/commit/fb8348e0afed3339298be3a7b6714b9114b71107
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit fb8348e0afed3339298be3a7b6714b9114b71107
Author: Robert Lyon <email address hidden>
Date: Thu Aug 13 17:08:14 2020 +1200

Bug 1891554: fixing up how bargraphs work

And changing the way popular block types show on stats overview page
>From list of top 5 to bar graph of top ten

Change-Id: Iad132b53d9f340df1c63327435497ca337a64f35
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/11143

Cecilia Vela Gurovic (ceciliavg)
Changed in mahara:
status: Fix Committed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11143
Committed: https://git.mahara.org/mahara/mahara/commit/f9d470152bd5babc167893e6997fb61bcfa243f0
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit f9d470152bd5babc167893e6997fb61bcfa243f0
Author: Robert Lyon <email address hidden>
Date: Fri Aug 14 18:01:02 2020 +1200

Bug 1891554: fixing up how bargraphs ordering work

Need to fetch actual top ten and not the first ten
Also need to set the axis to start at 0

Change-Id: Iacd1cc527a29ffc0e1dfa1157285b3e5ba073b48
Signed-off-by: Robert Lyon <email address hidden>

Cecilia Vela Gurovic (ceciliavg)
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.