Help icon text missing in certain file browser modals

Bug #1892426 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Lisa Seeto

Bug Description

When you add an attachment to a journal entry or to 'Goals and skills' in the resume or add a cover image, the help icons for the license metadata do not display the actual help text. It's always using the same method.

To replicate:

1. Turn on 'License metadata' in 'Configure site' -> 'Site options'.
2. Create a journal entry.
3. Click the 'Add a file' button under 'Attachments'.
4. Click one of the three help icons.
Expected result: The help text is displayed.
Actual result: Error message is displayed.

5. Go to 'Goals and skills' in the resume.
6. Edit one of the goals.
7. Click the 'Add a file' button under 'Attachments'.
8. Click one of the three help icons.
Expected result: The help text is displayed.
Actual result: Error message is displayed.

Once implemented, check that the help icon text still displays correctly for the following:

a) Main menu -> Create -> Files
b) in the block 'File(s) to download'

Tags: bite-sized
Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :
description: updated
Lisa Seeto (lisaseeto)
Changed in mahara:
assignee: nobody → Lisa Seeto (lisaseeto)
Lisa Seeto (lisaseeto)
Changed in mahara:
status: Confirmed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/11188

Changed in mahara:
milestone: none → 20.10.0
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11188
Committed: https://git.mahara.org/mahara/mahara/commit/554d4f1221069febe52681baf1814c8628b07ee0
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit 554d4f1221069febe52681baf1814c8628b07ee0
Author: Lisa Seeto <email address hidden>
Date: Wed Aug 26 14:53:11 2020 +1200

Bug 1892426: Help icon text missing in certain file browser modals

- added in another pattern to regex for preg_replace

Change-Id: I41a9d451fea0ba185384d2c2acd5aa6900a4781b
Signed-off-by: Lisa Seeto <email address hidden>

Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.