[SRU] binhex always segfaults

Stack trace.

Note: the frommac and tomac commands use similar argument handling code and so also segfault in the same way.

I have now tested and can reproduce the issue on Focal. Also tested and confirmed that Jammy and Mantic are not affected.

debdiff attached.

Thank you for the patch.

Uploaded to Focal.

Hi Sudip,

Thanks for debugging, backporting, and submitting a patch!
Nice touch on the DEP-3 headers.

Just a style/cosmetic _suggestion_ that is helpful: in the
future, please list the .patch file in d/changelog; e.g.,
'* d/p/fix-segfault.patch: Fix segfault with binhex, frommac and tomac. (LP: #1892558)'

And just for documentation purposes:
> There is no change in code, only the relevant header file has been included.
> And, so there are minimum chances of a regression.

The inclusion of a header file even 'without code changes'
may actually cause code changes _indirectly_. For example,
a header file defines a macro that is checked in the source
file (to change code paths) with a preprocessor #if/#ifdef.

This is _not_ the case here, as the included headers only
define the function prototypes, and nothing else/no macro;
so it looks good!

I also confirmed that the newer releases have the change
and are not affected.

Accepting macutils to focal-proposed.
Thanks again!

$ lsb_release -cs; dpkg -s macutils | grep ^Version:; dpkg -L macutils | grep /bin/ | while read BIN; do echo $BIN; $BIN -H >/dev/null 2>&1; echo RC = $?; done
focal
Version: 2.0b3-16build1
/usr/bin/binhex
RC = 139
/usr/bin/frommac
RC = 139
/usr/bin/hexbin
RC = 0
/usr/bin/macsave
RC = 0
/usr/bin/macstream
RC = 0
/usr/bin/macunpack
RC = 0
/usr/bin/tomac
RC = 139
ubuntu@focal:~$

$ lsb_release -cs; dpkg -s macutils | grep ^Version:; dpkg -L macutils | grep /bin/ | while read BIN; do echo $BIN; $BIN -H >/dev/null 2>&1; echo RC = $?; done
jammy
Version: 2.0b3-17
/usr/bin/binhex
RC = 0
/usr/bin/frommac
RC = 0
/usr/bin/hexbin
RC = 0
/usr/bin/macsave
RC = 0
/usr/bin/macstream
RC = 0
/usr/bin/macunpack
RC = 0
/usr/bin/tomac
RC = 0

$ lsb_release -cs; dpkg -s macutils | grep ^Version:; dpkg -L macutils | grep /bin/ | while read BIN; do echo $BIN; $BIN -H >/dev/null 2>&1; echo RC = $?; done
No LSB modules are available.
mantic
Version: 2.0b3-17
/usr/bin/binhex
RC = 0
/usr/bin/frommac
RC = 0
/usr/bin/hexbin
RC = 0
/usr/bin/macsave
RC = 0
/usr/bin/macstream
RC = 0
/usr/bin/macunpack
RC = 0
/usr/bin/tomac
RC = 0

$ lsb_release -cs; dpkg -s macutils | grep ^Version:; dpkg -L macutils | grep /bin/ | while read BIN; do echo $BIN; $BIN -H >/dev/null 2>&1; echo RC = $?; done
No LSB modules are available.
noble
Version: 2.0b3-17
/usr/bin/binhex
RC = 0
/usr/bin/frommac
RC = 0
/usr/bin/hexbin
RC = 0
/usr/bin/macsave
RC = 0
/usr/bin/macstream
RC = 0
/usr/bin/macunpack
RC = 0
/usr/bin/tomac
RC = 0

Hello Nathaniel, or anyone else affected,

Accepted macutils into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/macutils/2.0b3-16ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.