Mahara

CSS Advanced options in Skin not allowing position tag

Bug #1892948 reported by Lisa Seeto
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Lisa Seeto
Mahara 20.10.0

Bug Description

Since updating to CSS Tidy 1.7.1, it appears that some options for setting custom CSS are not available.
To replicate:
1. Have option for skins in config.php set to true for the site (i.e. $config->skins = true;)
2. Log into site and create a new skin (Create -> Skins -> Create skin)
3. Navigate to 'Advanced' tab and enter the following:
.pageheader {
position: absolute;
}
4. Save the skin. NB: Custom CSS changes are not reflected in the skin preview.
5. Edit the skin and navigate to the Advanced tab and look at the custom CSS
Expected results:
The editor window contains:
.pageheader {
position: absolute;
}
Actual results:
.pageheader{
}

See original description
Lisa Seeto (lisaseeto)
description: updated
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/11185

Revision history for this message
Pas (pascal-zaugg) wrote :

There is more than just the position tag affected.

Some of them unproblematic that should be possible:
border-radius:5px;
box-shadow:0 2px 3px #888;

And some might be considered as problematic but still would be great if possible:
content:url(...);
transform:rotate(270deg);
display:none;

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11185
Committed: https://git.mahara.org/mahara/mahara/commit/3abbabea569023fd76ca61a67f2061f18239d3a7
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 3abbabea569023fd76ca61a67f2061f18239d3a7
Author: Lisa Seeto <email address hidden>
Date: Wed Aug 26 12:02:40 2020 +1200

Bug 1892948: CSS Advanced options in Skin not allowing position tag

- added:
 CSS.AllowImportant
 CSS.Trusted
- added commented out:
 CSS.AllowTricky
 CSS.Proprietary

to CSS config

Change-Id: I1908e0cbd1a757b4be29c65998bae8b1b3c2613e
Signed-off-by: Lisa Seeto <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
milestone: none → 20.10.0
importance: Undecided → Medium
status: In Progress → Fix Committed
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.