Client connections setting headers incorrectly

Bug #1894756 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Unassigned

Bug Description

If using a client connection and you turn on use headers and supply a header it fails to work

Scenario

Mahara is trying to call a webservice connection via a client_connection via REST protocol to an external site but the external site is behind basic authentication so you choose the 'use headers' option and put in a basic auth header, eg "Authorization: Basic dGVtcDpBZTlhZWtveg" but it fails to work.

The problem is the code for adding this to the $auth array mixes up parts of the wstoken and the header so breaking the call

Robert Lyon (robertl-9)
description: updated
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/11237

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11237
Committed: https://git.mahara.org/mahara/mahara/commit/14784ea0219607284bbccb6059484e9d9c904fad
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 14784ea0219607284bbccb6059484e9d9c904fad
Author: Robert Lyon <email address hidden>
Date: Tue Sep 8 09:10:16 2020 +1200

Bug 1894756: Set extra headers correctly for client_connnection

So that the wstoken is seperate from extra headers and we can define
the full header in form field

Also have the correct nav menu when editing connection

Change-Id: I12a3b8d699d8da55718dba81c9ad31cfab9d2300
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
milestone: none → 20.10.0
importance: Undecided → Medium
status: New → Fix Committed
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.