[sos4.0][sosclean] hostname doesn't get fully obfuscate inside a clean tarball.

Bug #1896222 reported by Eric Desrochers
14
This bug affects 1 person
Affects Status Importance Assigned to Milestone
sosreport (Ubuntu)
Fix Released
Medium
Eric Desrochers
Bionic
Fix Released
Medium
Eric Desrochers
Focal
Fix Released
Medium
Eric Desrochers
Groovy
Fix Released
Medium
Eric Desrochers

Bug Description

[Impact]
The 'lvmpdump' file is getting skipped due to the fact that the tarball name appears twice in the filepath, and we are currently splitting on the tarball name to get the filepath within the archive.

The ps axo files being skipped is because it is hitting our don't-match-tarballs on the matching of the tar bit.

[Test Case]

* Install sosreport 4.X series (4.0-1~ubuntu0.20.04.*) found in focal-updates.
* Execute sos report --clean or sos clean against an existing tarball.
* Look inside sos_command/lvm2 and sos_command/process plugin's output
* One should see the 'real hostname' where it shouldn't.

[Regression Potential]
* sos clean is a new feature introduce with 4.0-1~ubuntu0.20.04.1 a few days ago. I don't think there is much adoption to this package yet. Hence, no regression potential due to low use (if not none for now).

* The fixes actually make sure new-found obfuscation bugs are taking care of.

[Other Info]
* Upstream:
https://github.com/sosreport/sos/issues/2236

* Upstream commits:
https://github.com/TurboTurtle/sos/commit/fec409c9198b02fa13527f6bef6a1d63bd402dbf
https://github.com/TurboTurtle/sos/commit/ca7cb3440618492e9cf5c7fee77623066bd4b0b7

Eric Desrochers (slashd)
tags: added: seg sos4.0 sts
Changed in sosreport (Ubuntu Groovy):
status: New → In Progress
assignee: nobody → Eric Desrochers (slashd)
importance: Undecided → Medium
Eric Desrochers (slashd)
summary: - [clean] hostname doesn't get fully obfuscate inside a clean tarball.
+ [sos4.0][clean] hostname doesn't get fully obfuscate inside a clean
+ tarball.
Eric Desrochers (slashd)
summary: - [sos4.0][clean] hostname doesn't get fully obfuscate inside a clean
+ [sos4.0][sosclean] hostname doesn't get fully obfuscate inside a clean
tarball.
Changed in sosreport (Ubuntu Focal):
status: New → In Progress
assignee: nobody → Eric Desrochers (slashd)
importance: Undecided → Medium
description: updated
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package sosreport - 4.0-1ubuntu1

---------------
sosreport (4.0-1ubuntu1) groovy; urgency=medium

  [Eric Desrochers]
  * d/p/0003-sosclean-fix-handling-of-filepath-with-archive-name.patch:
    - Fixes the splitting of filepaths within the archive,
      when the archive name is included in the filename
      inside the archive. (LP: #1896222)

  * d/p/0004-sosclean-fix-tarball-skipping-regex.patch:
    - Fix tarball skipping regex

  [Dan Hill]
  * d/p/0005-ceph-collect-balancer-and-pg-autoscale-status.patch:
    - Collect balancer and pg-autoscale status (LP: #1893109)

  [Nicolas Bock]
  * d/p/0006-rabbitmq-add-info-on-maybe-stuck-processes.patch:
    - Add information on maybe_stuck() processes for RMQ. (LP: #1890846)

 -- Eric Desrochers <email address hidden> Fri, 18 Sep 2020 09:23:04 -0400

Changed in sosreport (Ubuntu Groovy):
status: In Progress → Fix Released
Eric Desrochers (slashd)
description: updated
Eric Desrochers (slashd)
description: updated
Eric Desrochers (slashd)
description: updated
description: updated
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Please test proposed package

Hello Eric, or anyone else affected,

Accepted sosreport into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/sosreport/4.0-1~ubuntu0.20.04.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in sosreport (Ubuntu Focal):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-focal
Revision history for this message
Eric Desrochers (slashd) wrote :

[VERIFICATION FOCAL]

Tested with sosreport '4.0-1~ubuntu0.20.04.2'.

sos clean is now performing hostname obfuscation in lvm2 plugin and process plugin.

# ls sos_commands/lvm2
lvmdump_-d_.tmp.sos.hxvih1w4.sosreport-host0-2020-10-02-aurnwtz.sos_commands.lvm2.lvmdump

# lvmdump_-d_.tmp.sos.hxvih1w4.sosreport-host0-2020-10-02-aurnwtz.sos_commands.lvm2.lvmdump
Creating dump directory: /tmp/sos.hxvih1w4/sosreport-host0-2020-10-02-aurnwtz/sos_commands/lvm2/lvmdump

tags: added: verification-done verification-done-focal
removed: verification-needed verification-needed-focal
Revision history for this message
Eric Desrochers (slashd) wrote :

[VERIFICATION FOCAL] [PART 2]

The above "host0" wording being the obfuscation host generated by sos clean.

# /etc/sos/cleaner/default_mapping
{
    "hostname_map": {
        "sosfocaltest": "host0"

Eric Desrochers (slashd)
Changed in sosreport (Ubuntu Bionic):
status: New → In Progress
assignee: nobody → Eric Desrochers (slashd)
Eric Desrochers (slashd)
Changed in sosreport (Ubuntu Bionic):
importance: Undecided → Medium
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package sosreport - 4.0-1~ubuntu0.20.04.2

---------------
sosreport (4.0-1~ubuntu0.20.04.2) focal; urgency=medium

  [Eric Desrochers]
  * d/p/0003-sosclean-fix-handling-of-filepath-with-archive-name.patch:
    - Fixes the splitting of filepaths within the archive,
      when the archive name is included in the filename
      inside the archive. (LP: #1896222)

  * d/p/0004-sosclean-fix-tarball-skipping-regex.patch:
    - Fix tarball skipping regex

  [Dan Hill]
  * d/p/0005-ceph-collect-balancer-and-pg-autoscale-status.patch:
    - Collect balancer and pg-autoscale status (LP: #1893109)

  [Nicolas Bock]
  * d/p/0006-rabbitmq-add-info-on-maybe-stuck-processes.patch:
    - Add information on maybe_stuck() processes for RMQ. (LP: #1890846)

  * d/p/0007-rabbitmq-add-10sec-timeout-to-call-to-maybestuck.patch:
    - Add 10 second timeout to call to `maybe_stuck()`.

 -- Eric Desrochers <email address hidden> Wed, 30 Sep 2020 14:29:50 -0400

Changed in sosreport (Ubuntu Focal):
status: Fix Committed → Fix Released
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for sosreport has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Eric Desrochers (slashd) wrote :

It is now fixed with the release of sos 4.1 now found in -update for Bionic.

Changed in sosreport (Ubuntu Bionic):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.