Ubuntu
dahdi-linux package

dahdi-dkms: build failure with linux-hwe-5.8 in focal

Bug #1899602 reported by Andrea Righi on 2020-10-13

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	dahdi-linux (Ubuntu)	Invalid	Undecided	Unassigned
	Focal	Fix Released	Undecided	Unassigned

Bug Description

[Impact]

The following build error is reported when trying to install dahdi-dkms with the new linux-hwe-5.8 in focal:

In file included from /var/lib/dkms/dahdi/2.11.1~dfsg-1ubuntu6/build/drivers/dahdi/oct612x/oct612x-user.c:27:
/var/lib/dkms/dahdi/2.11.1~dfsg-1ubuntu6/build/include/dahdi/kernel.h:960:18: error: field ‘registration_time’ has incomplete type
960 | struct timespec registration_time;
| ^~~~~~~~~~~~~~~~~

[Test case]

$ sudo apt install dahdi-dkms

Build error is reported in the logs.

[Fix]

Fix by applying 3 patches from the groovy dkms module to properly support a 5.8 kernel.

[Regression potential]

The source code for the 5.4 kernel remains the same, so there is no regression potential. The new changes are all conditionals and they are all applied to the 5.8 kernel.

See original description

Tags:

Revision history for this message

Andrea Righi (arighi) wrote on 2020-10-13:

dahdi-dkms-fix-build-error-with-linux-5.8.debdiff Edit (28.5 KiB, text/plain)

Attached debdiff fixes all the build errors with linux-hwe-5.8.

Ubuntu Foundations Team Bug Bot (crichton) on 2020-10-13

tags:

added: patch

Timo Aaltonen (tjaalton) on 2020-10-30

Changed in dahdi-linux (Ubuntu):
status:	New → Invalid

Andrea Righi (arighi) on 2020-10-30

description:

updated

Revision history for this message

Andy Whitcroft (apw) wrote on 2020-11-03: Please test proposed package

Hello Andrea, or anyone else affected,

Accepted dahdi-linux into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/dahdi-linux/1:2.11.1~dfsg-1ubuntu6.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in dahdi-linux (Ubuntu Focal):
status:	New → Fix Committed

Revision history for this message

Kleber Sacilotto de Souza (kleber-souza) wrote on 2020-11-10:

I have verified dahdi-dkms 1:2.11.1~dfsg-1ubuntu6.1 from focal-proposed and I can confirm that it fixes the compilation issue with hwe-5.8 kernel.

Testcase: installed dahdi-dkms/dahdi-linux 1:2.11.1~dfsg-1ubuntu6.1 on a Focal system, built and loaded the dkms modules with linux-image-5.4.0-52-generic and linux-image-5.8.0-25-generic.

Also re-ran ADT tests on amd64 with linux-meta-hwe-5.8:
https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-focal/focal/amd64/d/dahdi-linux/20201110_143229_adf8e@/log.gz

---
dahdi, 2.11.1~dfsg-1ubuntu6.1, 5.8.0-25-generic, x86_64: installed
DKMS installation: OK
Dummy module load: OK
---

Kleber Sacilotto de Souza (kleber-souza) on 2020-11-10

tags:

added: verification-done-focal

Revision history for this message

Launchpad Janitor (janitor) wrote on 2020-11-10:

This bug was fixed in the package dahdi-linux - 1:2.11.1~dfsg-1ubuntu6.1

---------------
dahdi-linux (1:2.11.1~dfsg-1ubuntu6.1) focal; urgency=medium

  * Linux 5.8 compatibility (LP: #1899602)
    - debian/patches/Linux-5.7-timespec-timeval-fix.patch
    - debian/patches/Linux-5.6-ktime_get_ts-fix.patch
    - debian/patches/Linux-5.6-proc_create_data-fix.patch

-- Andrea Righi <email address hidden> Tue, 13 Oct 2020 09:15:32 +0000

Changed in dahdi-linux (Ubuntu Focal):
status:	Fix Committed → Fix Released

Revision history for this message

Brian Murray (brian-murray) wrote on 2020-11-10: Update Released

The verification of the Stable Release Update for dahdi-linux has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.