Mahara

Update the webservices variables help text - currently hardcoded in english

Bug #1899855 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Doris Tam
Mahara 21.04.0

Bug Description

The need to be changed to language strings eg these files
htdocs/webservice/functions/mahara_*_external.php

and these parts, eg

new external_value(PARAM_RAW, 'Username of the assessment submitter', VALUE_OPTIONAL, null, NULL_ALLOWED, 'id'),

the 'Username of the assessment submitter' needs to be get_string('usernameassessmentsubmitter', 'webservices')

And we make a htdocs/lang/en.utf8/webservices.php for them

Revision history for this message
Robert Lyon (robertl-9) wrote :

There also might be the issue where the same description text is used for different things so we will need to tidy that up as well - have descriptions that match the fields

Changed in mahara:
importance: Medium → Wishlist
Kristina Hoeppner (kris-hoeppner)
Changed in mahara:
status: New → Confirmed
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/11433

Doris Tam (doristam)
Changed in mahara:
status: Confirmed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11433
Committed: https://git.mahara.org/mahara/mahara/commit/e3b87abae3ab2166150680f95a78637038c35aa5
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit e3b87abae3ab2166150680f95a78637038c35aa5
Author: Doris Tam <email address hidden>
Date: Wed Nov 11 10:30:35 2020 +1300

Bug 1899855: Created lang strings for hardcoded string literals in webservices/functions

Better maintenance to have keep strings used in webservices as lang strings rather than
hardcoding them in.

behatnotneeded

Change-Id: I70d54e89865b4ea35bc5762eb02b47e9cbc0a105

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Kristina Hoeppner (kris-hoeppner)
tags: added: newfeature
Kristina Hoeppner (kris-hoeppner)
tags: removed: newfeature
Changed in mahara:
importance: Wishlist → Medium
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.