Ubuntu
alsa-lib package

[SRU] alsa-lib: support the enum value settings both in "" and in ''

Bug #1899857 reported by Hui Wang
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
HWE Next
Fix Released
Undecided
Unassigned
alsa-lib (Ubuntu)
Fix Released
High
Hui Wang
Focal
Fix Released
High
Hui Wang
Groovy
Fix Released
High
Hui Wang

Bug Description

[Impact]
Recently the ucm added some amixer settings, like this one:
cset "name='rt711 ADC 23 Mux' 'MIC2'"
This setting is needed for Dell soundwire audio machines, and only
this setting is set correctly, the headset-mic could work. And we
already backported this ucm to focal. But the alsa-lib ctl parse
doesn't support the enum value in the '' yet, so this amixer setting
can't be set correctly under current focal and groovy, we need to
backport a patch from alsa-lib master branch.

[Fix]
Backport a patch from upstream, this patch is not in the groovy
yet (not in the alsa-lib v1.2.3.2), so both groovy and focal need this
patch.

[Test Case]
On the Dell soundwire audio machine, run alsactl init, then check if
the amixer "rt711 ADC 23 Mux" is set to "MIC2" or not, if it is set
correctly, it means the alsalib enum ctl parse support both "" and ''
now.

[Regression Risk]
This could introduce failure on setting enum amixer settings, users
will experience the failure of audio device like the speaker can't output
sound, the mic can't record sound. But this possibility is very low since
we have tested this SRU on many LENOVO and Dell machines (with and without
soundwire audio), all worked as fine as before.

See original description
Hui Wang (hui.wang)
affects: alsa-utils (Ubuntu) → alsa-lib (Ubuntu)
Changed in alsa-lib (Ubuntu Focal):
importance: Undecided → High
Changed in alsa-lib (Ubuntu Groovy):
importance: Undecided → High
Changed in alsa-lib (Ubuntu Focal):
assignee: nobody → Hui Wang (hui.wang)
tags: added: oem-priority originate-from-1894184 somerville
Changed in alsa-lib (Ubuntu Focal):
status: New → In Progress
Changed in alsa-lib (Ubuntu Groovy):
status: New → In Progress
Revision history for this message
Hui Wang (hui.wang) wrote :

This is the debdiff for groovy.

thx.

description: updated
Revision history for this message
Hui Wang (hui.wang) wrote :

This is the debdiff for focal.

thx.

Revision history for this message
Steve Langasek (vorlon) wrote : Please test proposed package

Hello Hui, or anyone else affected,

Accepted alsa-lib into groovy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/alsa-lib/1.2.3.2-1ubuntu2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-groovy to verification-done-groovy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-groovy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in alsa-lib (Ubuntu Groovy):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-groovy
Revision history for this message
Kai-Chuan Hsieh (kchsieh) wrote :

Verify on Intel Precesion 5750. CID: 202002-27723, with ubuntu 20.04.1.

1. add groovy-proposed source to /etc/apt/source.list
+deb http://archive.ubuntu.com/ubuntu/ groovy-proposed main restricted
2. $ sudo apt update
3. $ sudo apt install libasound2
4. Try to modify /usr/alsa/ucm2/codecs/rt711/init.conf
-cset "name='rt711 ADC 23 Mux' 'MIC2'"
+cset "name='rt711 ADC 23 Mux' 'LINE1'"
5. $ alsaucm set _boot ""
6. $ amixer contents
numid=54,iface=MIXER,name='rt711 ADC 23 Mux'
  ; type=ENUMERATED,access=rw------,values=1,items=4
  ; Item #0 'MIC2'
  ; Item #1 'LINE1'
  ; Item #2 'LINE2'
  ; Item #3 'DMIC'
  : values=1
7. it shows that the rule can apply successfully

tags: added: verification-done verification-done-groovy
removed: verification-needed verification-needed-groovy
Revision history for this message
Kai-Chuan Hsieh (kchsieh) wrote :

continue #4 fix typo.

Verify on *Dell Precesion 5750. CID: 202002-27723, with ubuntu 20.04.1.

1. add groovy-proposed source to /etc/apt/source.list
+deb http://archive.ubuntu.com/ubuntu/ groovy-proposed main restricted
2. $ sudo apt update
3. $ sudo apt install libasound2
4. Try to modify /usr/alsa/ucm2/codecs/rt711/init.conf
-cset "name='rt711 ADC 23 Mux' 'MIC2'"
+cset "name='rt711 ADC 23 Mux' 'LINE1'"
5. $ alsaucm set _boot ""
6. $ amixer contents
numid=54,iface=MIXER,name='rt711 ADC 23 Mux'
  ; type=ENUMERATED,access=rw------,values=1,items=4
  ; Item #0 'MIC2'
  ; Item #1 'LINE1'
  ; Item #2 'LINE2'
  ; Item #3 'DMIC'
  : values=1
7. it shows that the rule can apply successfully

Revision history for this message
Sebastien Bacher (seb128) wrote :

uploaded to focal SRU now

Changed in alsa-lib (Ubuntu Focal):
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package alsa-lib - 1.2.3.2-1ubuntu2

---------------
alsa-lib (1.2.3.2-1ubuntu2) groovy; urgency=medium

  * d/p/0001-control-ctlparse-fix-enum-values-in-or.patch
  - Fix ctl parsing for enum value setting, let it support both
    "" and '' (LP: #1899857)

 -- Hui Wang <email address hidden> Thu, 15 Oct 2020 00:50:24 +0000

Changed in alsa-lib (Ubuntu Groovy):
status: Fix Committed → Fix Released
Revision history for this message
Kai-Chuan Hsieh (kchsieh) wrote :

Hello,

May I know what blocks the focal release SRU?

Thanks,

Revision history for this message
Kai-Chuan Hsieh (kchsieh) wrote :

@seb128

Hello,

I reupload the debdiff for focal based on the latest alsa-lib version.
Please help to upload to queue. version is 1.2.2-2.1ubuntu2.3.debdiff.

Thanks,

Revision history for this message
Olivier Tilloy (osomon) wrote :

alsa-lib 1.2.2-2.1ubuntu2.3 is now in the focal queue

Revision history for this message
Kai-Chuan Hsieh (kchsieh) wrote :

May I know when will it be in proposed? should I invite someone to review? thanks.

Revision history for this message
Timo Aaltonen (tjaalton) wrote :

Hello Hui, or anyone else affected,

Accepted alsa-lib into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/alsa-lib/1.2.2-2.1ubuntu2.3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

tags: added: verification-needed verification-needed-focal
removed: verification-done
Revision history for this message
Kai-Chuan Hsieh (kchsieh) wrote :

Validate on Latitude 9420.
Its codec init.conf under /usr/share/alsa/ucm2/codecs/rt715-sdca/init.conf introduced by
https://github.com/thesofproject/alsa-ucm-conf/pull/45

The command:
cset "name='rt714 ADC 22 Mux' 'DMIC3'"
cset "name='rt714 ADC 23 Mux' 'DMIC4'"
doesn't work, and internal microphone is not able to use.

After update the libasound2.
run
$ alsactl init
$ amixer cget name='rt714 ADC 22 Mux'
numid=85,iface=MIXER,name='rt714 ADC 22 Mux'
  ; type=ENUMERATED,access=rw------,values=1,items=8
  ; Item #0 'MIC1'
  ; Item #1 'MIC2'
  ; Item #2 'LINE1'
  ; Item #3 'LINE2'
  ; Item #4 'DMIC1'
  ; Item #5 'DMIC2'
  ; Item #6 'DMIC3'
  ; Item #7 'DMIC4'
  : values=6
$ amixer cget name='rt714 ADC 23 Mux'
numid=86,iface=MIXER,name='rt714 ADC 23 Mux'
  ; type=ENUMERATED,access=rw------,values=1,items=8
  ; Item #0 'MIC1'
  ; Item #1 'MIC2'
  ; Item #2 'LINE1'
  ; Item #3 'LINE2'
  ; Item #4 'DMIC1'
  ; Item #5 'DMIC2'
  ; Item #6 'DMIC3'
  ; Item #7 'DMIC4'
  : values=7

And the internal microphone works.

tags: added: verification-done verification-done-focal
removed: verification-needed verification-needed-focal
Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of the Stable Release Update for alsa-lib has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package alsa-lib - 1.2.2-2.1ubuntu2.3

---------------
alsa-lib (1.2.2-2.1ubuntu2.3) focal; urgency=medium

  * d/p/0001-control-ctlparse-fix-enum-values-in-or.patch
  - Fix ctl parsing for enum value setting, let it support both
    "" and '' (LP: #1899857)

 -- Hui Wang <email address hidden> Wed, 16 Dec 2020 17:23:08 +0800

Changed in alsa-lib (Ubuntu Focal):
status: Fix Committed → Fix Released
Timo Aaltonen (tjaalton)
Changed in hwe-next:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.