requestsync attempts to change bug importance, which is not always possible

Bug #190061 reported by James Westby
4
Affects Status Importance Assigned to Milestone
ubuntu-dev-tools (Ubuntu)
Fix Released
Low
Siegfried Gevatter

Bug Description

Binary package hint: ubuntu-dev-tools

Hi,

I (non-MOTU, non-bugsquad), attempted to use requestsync
with --lp as I did not have my private key to hand. This is
what happened:

$ requestsync --lp -s 2vcard hardy
Explanation of the Ubuntu delta and why it can be dropped:
The changes have all been integrated by Debian.

Summary:
Please sync 2vcard 0.5-2 (universe) from Debian unstable (main)

Description:
Please sync 2vcard 0.5-2 (universe) from Debian unstable (main).

Explanation of the Ubuntu delta and why it can be dropped:
The changes have all been integrated by Debian.

Changelog since current hardy version 0.5-1ubuntu3:

2vcard (0.5-2) unstable; urgency=low

  * Fixed debian/copyright (Closes: #449058)
  * Added watch file (Closes: #462041)
  * Fixed arch (Closes: #449046)
  * Fixed description typo (Closes: #438658)
  * New co-maintainer: me!!

 -- Marcela Tiznado <email address hidden> Thu, 31 Jan 2008 21:23:27 -0200

Press enter to file this bug, Control-C to abort.

Traceback (most recent call last):
  File "/usr/bin/requestsync", line 314, in <module>
    if post_bug(srcpkg, subscribe, mapping[status], title, report):
  File "/usr/bin/requestsync", line 226, in post_bug
    bug.importance = 'Wishlist'
  File "/usr/lib/python2.5/site-packages/launchpadbugs/lphelper.py", line 260, in <lambda>
    if fset : fset = lambda s, v, n=fset.__name__ : getattr(s, n)(v)
  File "/usr/lib/python2.5/site-packages/launchpadbugs/html_bug.py", line 58, in f
    return func(a, *args, **kwargs)
  File "/usr/lib/python2.5/site-packages/launchpadbugs/html_bug.py", line 111, in func
    setattr(reduce(getattr, attributes[:-1]), attributes[-1], value)
  File "/usr/lib/python2.5/site-packages/launchpadbugs/lphelper.py", line 260, in <lambda>
    if fset : fset = lambda s, v, n=fset.__name__ : getattr(s, n)(v)
  File "/usr/lib/python2.5/site-packages/launchpadbugs/html_bug.py", line 184, in set_importance
    raise IOError, "'Importance' editable only by the maintainer or bug contact of the project/package"
IOError: 'Importance' editable only by the maintainer or bug contact of the project/package

So I do not have permission to change the importance.

However the bug was still filed, even though I assumed that it
wasn't, meaning that I filed a duplicate.

It would be great if it could either know whether editing the importance
was possible for that user, or catch the error and report it
gracefully.

Also, as a bonus it could make sure that if any errors occur after
filing the user knows that the bug has been filed.

Thanks,

James

Changed in ubuntu-dev-tools:
importance: Undecided → Low
Revision history for this message
Daniel Hahler (blueyed) wrote :

Thank you for this bug report.
I'll look into this.

Changed in ubuntu-dev-tools:
assignee: nobody → blueyed
status: New → In Progress
Revision history for this message
Daniel Hahler (blueyed) wrote :

I've fixed this now in my branch, which I'll link and Siegfried hopefully will merge soon.
Thanks for your bug report.

Changed in ubuntu-dev-tools:
assignee: blueyed → nobody
status: In Progress → Triaged
Changed in ubuntu-dev-tools:
status: Triaged → Fix Committed
Changed in ubuntu-dev-tools:
assignee: nobody → rainct
status: Fix Committed → Triaged
Revision history for this message
Siegfried Gevatter (rainct) wrote :

Merged into the main branch, thanks.

Changed in ubuntu-dev-tools:
status: Triaged → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-dev-tools - 0.31

---------------
ubuntu-dev-tools (0.31) intrepid; urgency=low

  [ Siegfried-Angel Gevatter Pujals (RainCT) ]
  * pbuilder-dist.new:
     - Rewrite the script in Python to make it more robust and faster.
  * what-patch:
     - If cdbs-edit-patch is used, output "cdbs (patchsys.mk)" instead of
       just "cdbs" (LP: #195795).
  * check-symbols:
     - Add a brief explanation about why sudo privilegies are required
       in order to run this script (LP: #194622).
     - End with exit code 1 if there's an error.
  * suspicious-source:
     - Whitelist C# files (LP: #225691): *.cs.
     - Whitelist manpages: *.[0-9].

  [ Daniel Hahler ]
  * requestsync:
     - Use debian_bundle.changelog.Version for version comparison in
       debian_changelog.
     - Fix --lp for Firefox 3 (LP: #208808):
       It now tries ~/.lpcookie.txt, ~/.mozilla/*/*/cookies.sqlite and
       ~/.mozilla/*/*/cookies.txt to find a Launchpad cookie file.
       Also added a hint that you can create a valid file, by logging into
       Launchpad with Firefox.
     - Added confirm loops, which displays the message to be send/posted and
       either allows to edit (or forces to, in case of Ubuntu changes).
       (LP: #194613, #194615)
       This adds a convient edit_report method, which gets used both from the
       Launchpad and mail code path.
     - Do not fallback to submitting by email, if posting to Launchpad failed.
       This hasn't been requested and therefore should not get done.
     - post_bug: Catch IOError when setting bug importance (LP: #190061)
     - mail_bug: Catch socket.error (LP: #190739)

  [ Kees Cook ]
  * mk-sbuild-lv
    - don't install recommended packages during chroot install.
    - allow customization of schroot.conf suffix and LV/snapshot sizes.
  * what-patch:
    - restore previous output behavior, added logic to verbose test instead.
    - added details for each patch system report.
  * pull-debian-debdiff:
    - parse .dsc file for required source files.
    - switch to GPLv3
  * debian/control: add Depends needed for pull-debian-debdiff.
  * debian/copyright:
    - updated pull-debian-debdiff, which is now GPLv3.
    - adjusted Copyright lines to make lintian happy.

 -- Kees Cook <email address hidden> Fri, 13 Jun 2008 11:43:24 -0700

Changed in ubuntu-dev-tools:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.