Drop-down icon of last item in main menu inconsistent in expanding sub menu

Bug #1903933 reported by Doris Tam
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Doris Tam

Bug Description

- SUMMARY -
Clicking the arrow icon beside the last item of the main menu to expand the submenu causes the main menu to collapse after opening.

Reproduce:
- Go to the people search page, files page, pages and collections page
- Refresh the page
- Open the main menu
- Click on the arrow associated with the last menu item to expand it

Expect:
- Expanded menu items from the main menu's submenu has displayed
- User can see the items of the expanded submenu

Actual:
- Main menu is collapsed upon clicking the arrow to expand the menu item
- If we open up the main menu again, we can see that the submenu did expand out

Note:
- Clicking the actual text of the item does not cause this issue
- Version is of the latest master at the time of writing 2020.11.12, assuming 20.10
- Same outcome on both Firefox and Chrome
- This doesn't happen to all Mahara pages only some, not sure what the similarities are of the pages affected 🤔

Tags: menus
Doris Tam (doristam)
description: updated
description: updated
tags: added: menus
description: updated
description: updated
description: updated
Revision history for this message
Robert Lyon (robertl-9) wrote :

It looks like the problem is in htdocs/js/mahara.js on line 1193 and / or line 1202 where we hide things on blur

We need to adjust it so that if we only do the hiding of we are tabbing away from the last element rather than any action

Changed in mahara:
assignee: nobody → Doris Tam (doristam)
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/11456

Doris Tam (doristam)
Changed in mahara:
status: New → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11456
Committed: https://git.mahara.org/mahara/mahara/commit/4b75fcb7689742cf28f86ce7ce7e58c0bf574c21
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 4b75fcb7689742cf28f86ce7ce7e58c0bf574c21
Author: Doris Tam <email address hidden>
Date: Wed Nov 18 11:00:42 2020 +1300

Bug 1903933: Change the condition for collapsing from on blur to on keyup

This is so we are still able to expand the last submenu without it collapsing
by clicking on the arrow (last menu item) rather than collapsing the menu
when removing focus from it (what was the last menu item before expanding it).

Change-Id: Ie8920b1731b41e3db5f943d50f43642608885dc2

Robert Lyon (robertl-9)
Changed in mahara:
milestone: none → 21.04.0
importance: Undecided → Medium
status: In Progress → Fix Committed
summary: - Dropdown icon of last item in main menu inconsistent in expanding
- submenu
+ Drop-down icon of last item in main menu inconsistent in expanding sub
+ menu
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.