Mahara

Adding navigation block to a collection can cause loss of data

  1. Series 19.10
  2. Bug #1904352
Bug #1904352 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
19.10
Fix Released
High
Unassigned
Mahara 19.10.6
20.04
Fix Released
High
Unassigned
Mahara 20.04.3
20.10
Fix Released
High
Unassigned
Mahara 20.10.1
21.04
Fix Released
High
Unassigned
Mahara 21.04.0

Bug Description

When doing the following scenario the display of a page can be adversely affected

1) Have a collection of pages that were made before the new grid layout was added, eg before September 2019, that don't have navigation blocks in them. A good test is to have an image block on each page.

2) Go to edit one of the pages - it should prompt you to convert the page to the new grid layout - choose the 'Accept' option

3) Add a navigation block to the page and set 'Add to all pages' to 'Yes'

4) Save the block

Now go view the collection - the page you edited should look normal but the other pages will now be missing all blocks except the Navigation one

Luckily the data is not deleted but just that the new navigation block for those pages has been saved as a block with new grid layout information so the page is rendered as a new layout page.

What we need to do is save the navigation block onto the pages in old layout way so that it all displays again as expected.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "20.10_STABLE" branch: https://reviews.mahara.org/11447

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/11448

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/11449

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11448
Committed: https://git.mahara.org/mahara/mahara/commit/bf1139f111ec64ec1a454875001a802d88cd9abe
Submitter: Lisa Seeto (<email address hidden>)
Branch: master

commit bf1139f111ec64ec1a454875001a802d88cd9abe
Author: Robert Lyon <email address hidden>
Date: Mon Nov 16 10:35:46 2020 +1300

Bug 1904352: Save navigation block correctly

Depending if the other pages in collection are in old or new layout

Change-Id: Ic6a395e391614e285338b8f6e3c900383cec4113
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/11447
Committed: https://git.mahara.org/mahara/mahara/commit/ace9ca1cfb148de2ab63b50f3825194043b2fbc7
Submitter: Lisa Seeto (<email address hidden>)
Branch: 20.10_STABLE

commit ace9ca1cfb148de2ab63b50f3825194043b2fbc7
Author: Robert Lyon <email address hidden>
Date: Mon Nov 16 10:35:46 2020 +1300

Bug 1904352: Save navigation block correctly

Depending if the other pages in collection are in old or new layout

Change-Id: Ic6a395e391614e285338b8f6e3c900383cec4113
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit bf1139f111ec64ec1a454875001a802d88cd9abe)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "20.04_STABLE" branch: https://reviews.mahara.org/11474

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11474
Committed: https://git.mahara.org/mahara/mahara/commit/b22edae33cea21047b02baa426eccc9c7d1dfb1a
Submitter: Lisa Seeto (<email address hidden>)
Branch: 20.04_STABLE

commit b22edae33cea21047b02baa426eccc9c7d1dfb1a
Author: Robert Lyon <email address hidden>
Date: Mon Nov 16 10:35:46 2020 +1300

Bug 1904352: Save navigation block correctly

Depending if the other pages in collection are in old or new layout

Change-Id: Ic6a395e391614e285338b8f6e3c900383cec4113
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit bf1139f111ec64ec1a454875001a802d88cd9abe)
(cherry picked from commit ace9ca1cfb148de2ab63b50f3825194043b2fbc7)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "19.10_STABLE" branch: https://reviews.mahara.org/11475

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11475
Committed: https://git.mahara.org/mahara/mahara/commit/5c07bcd66bc1369879598648f550b6d8723eb337
Submitter: Lisa Seeto (<email address hidden>)
Branch: 19.10_STABLE

commit 5c07bcd66bc1369879598648f550b6d8723eb337
Author: Robert Lyon <email address hidden>
Date: Mon Nov 16 10:35:46 2020 +1300

Bug 1904352: Save navigation block correctly

Depending if the other pages in collection are in old or new layout

Change-Id: Ic6a395e391614e285338b8f6e3c900383cec4113
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit bf1139f111ec64ec1a454875001a802d88cd9abe)
(cherry picked from commit ace9ca1cfb148de2ab63b50f3825194043b2fbc7)
(cherry picked from commit b22edae33cea21047b02baa426eccc9c7d1dfb1a)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/11449
Committed: https://git.mahara.org/mahara/mahara/commit/238eb5724dd2ff6d4a63ba214961bbaa585e12a9
Submitter: Lisa Seeto (<email address hidden>)
Branch: master

commit 238eb5724dd2ff6d4a63ba214961bbaa585e12a9
Author: Robert Lyon <email address hidden>
Date: Mon Nov 16 12:20:15 2020 +1300

Bug 1904352: Clean up bad navigation blocks in database

Change-Id: Ic770ff00935f951cdc30c6a52e70bb96ed96f01f
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "20.10_STABLE" branch: https://reviews.mahara.org/11476

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "20.04_STABLE" branch: https://reviews.mahara.org/11477

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "19.10_STABLE" branch: https://reviews.mahara.org/11478

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11478
Committed: https://git.mahara.org/mahara/mahara/commit/7e1bf3f9c22097405f69abdb040bed8381b4afda
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.10_STABLE

commit 7e1bf3f9c22097405f69abdb040bed8381b4afda
Author: Robert Lyon <email address hidden>
Date: Mon Nov 16 12:20:15 2020 +1300

Bug 1904352: Clean up bad navigation blocks in database

Change-Id: Ic770ff00935f951cdc30c6a52e70bb96ed96f01f
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/11477
Committed: https://git.mahara.org/mahara/mahara/commit/6875028c8c511e7ec8abe065668ce62d95f0b431
Submitter: Robert Lyon (<email address hidden>)
Branch: 20.04_STABLE

commit 6875028c8c511e7ec8abe065668ce62d95f0b431
Author: Robert Lyon <email address hidden>
Date: Mon Nov 16 12:20:15 2020 +1300

Bug 1904352: Clean up bad navigation blocks in database

Change-Id: Ic770ff00935f951cdc30c6a52e70bb96ed96f01f
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/11476
Committed: https://git.mahara.org/mahara/mahara/commit/170700be748ee9286327d1ebf9ad95217acf3568
Submitter: Robert Lyon (<email address hidden>)
Branch: 20.10_STABLE

commit 170700be748ee9286327d1ebf9ad95217acf3568
Author: Robert Lyon <email address hidden>
Date: Mon Nov 16 12:20:15 2020 +1300

Bug 1904352: Clean up bad navigation blocks in database

Change-Id: Ic770ff00935f951cdc30c6a52e70bb96ed96f01f
Signed-off-by: Robert Lyon <email address hidden>

Kristina Hoeppner (kris-hoeppner)
no longer affects: mahara
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.