[SRU] git-review>=1.27 for updated opendev gerrit

Bug #1905282 reported by Corey Bryant
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
git-review (Ubuntu)
Fix Released
Undecided
Unassigned
Trusty
Triaged
Low
Unassigned
Xenial
Triaged
Low
Unassigned
Bionic
Fix Released
High
Unassigned
Focal
Fix Released
Undecided
Unassigned
Groovy
Fix Released
Undecided
Unassigned
Hirsute
Fix Released
Undecided
Unassigned

Bug Description

[Impact]
OpenStack's gerrit, https://review.opendev.org, was upgraded over the weekend and now running git-review on bionic will result in a failure "prohibited by Gerrit: not permitted: create".

This is fixed in 1.27.0 and there is a small delta since 1.26.0.

$ git-pretty 1.26.0..1.27.0
 - [3c46c33] Fix compare_review's use of fetch_review
 - [6587639] Always print failure case when testing remotes
 - [dcbfb32] Use new %topic=XXXX syntax for topic pushes
 - [c7436f9] Start using reno for releasenotes
 - [8236cdb] Use doc/requirements and openstackdocstheme
 - [c9282ae] Update tox docs environment to use sphinx-build
 - [694f532] Update default gerrit namespace
 - [de0d271] tox: default envlist to supported python versions
 - [7de9ffc] support review URLs as download arguments
 - [ed3c79e] expand help for --download option
 - [6f50b59] `work-in-progress` and `private` workflow in Gerrit 2.15
 - [31c5e0b] Document usepushurl in the man page
 - [aeeff97] Fix git review -d M,N with later gerrit
 - [244731b] Testing getting specific patchset
 - [b07a524] Add bindep.txt

[Test Case]
Run 'git review' on an openstack change it should successfully push changes to gerrit, and not fail with "prohibited by Gerrit: not permitted: create".

[Regression Potential]
'git-review' is used to proposed changes to opendev projects so any regressions would be found through the use of this CLI tool. As of now, the 1.26.0 version of git-review in bionic doesn't work with the upgraded gerrit. We've had version 1.27.0 in focal for 6-7 months now and regressions should be significantly minimized by that.

[Discussion]
Work-around for using 1.26.0: In chatting with clarkb he mentioned users can push directly using git push gerrit HEAD:refs/for/$branch or install git review 1.27.0 in a virtualenv.

Revision history for this message
Aurelien Lourot (aurelien-lourot) wrote :

Workaround: `pip install git-review` will give you 1.28 on bionic.

Changed in git-review (Ubuntu):
status: New → Confirmed
description: updated
description: updated
Revision history for this message
Corey Bryant (corey.bryant) wrote :

git-review 1.27.0-0ubuntu0.18.04.1 has been uploaded to the bionic unapproved queue where it is awaiting SRU team review: https://launchpad.net/ubuntu/bionic/+queue?queue_state=1&queue_text=git-review

Changed in git-review (Ubuntu Hirsute):
status: Confirmed → Fix Released
Changed in git-review (Ubuntu Groovy):
status: New → Fix Released
Changed in git-review (Ubuntu Focal):
status: New → Fix Released
Changed in git-review (Ubuntu Bionic):
status: New → Triaged
importance: Undecided → High
Changed in git-review (Ubuntu Xenial):
status: New → Triaged
importance: Undecided → Low
Changed in git-review (Ubuntu Trusty):
status: New → Triaged
importance: Undecided → Low
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Corey, or anyone else affected,

Accepted git-review into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/git-review/1.27.0-0ubuntu0.18.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in git-review (Ubuntu Bionic):
status: Triaged → Fix Committed
tags: added: verification-needed verification-needed-bionic
Revision history for this message
Corey Bryant (corey.bryant) wrote :

Thanks Brian.

Verified successfully on bionic-proposed:

ubuntu@coreycb-bastion:/tmp/microstack$ apt policy git-review
git-review:
  Installed: 1.26.0-1
  Candidate: 1.26.0-1
  Version table:
 *** 1.26.0-1 500
        500 http://nova.clouds.archive.ubuntu.com/ubuntu bionic/universe amd64 Packages
        100 /var/lib/dpkg/status

ubuntu@coreycb-bastion:/tmp/microstack$ git review
remote: error: branch refs/publish/master:
remote: If you are using git-review, update to at least git-review 1.27. Otherwise:
remote: You need 'Create' rights to create new references.
remote: User: coreycb
remote: Contact an administrator to fix the permissions
remote:
remote: Processing changes: refs: 1
remote: Processing changes: refs: 1, done
To ssh://review.opendev.org:29418/x/microstack.git
 ! [remote rejected] HEAD -> refs/publish/master (prohibited by Gerrit: not permitted: create)
error: failed to push some refs to 'ssh://<email address hidden>:29418/x/microstack.git'

ubuntu@coreycb-bastion:/tmp/microstack$ apt policy git-review
git-review:
  Installed: 1.27.0-0ubuntu0.18.04.1
  Candidate: 1.27.0-0ubuntu0.18.04.1
  Version table:
 *** 1.27.0-0ubuntu0.18.04.1 500
        500 http://nova.clouds.archive.ubuntu.com/ubuntu bionic-proposed/universe amd64 Packages
        100 /var/lib/dpkg/status
     1.26.0-1 500
        500 http://nova.clouds.archive.ubuntu.com/ubuntu bionic/universe amd64 Packages

ubuntu@coreycb-bastion:/tmp/microstack$ git review
Creating a git remote called 'gerrit' that maps to:
        ssh://<email address hidden>:29418/x/microstack.git
Your change was committed before the commit hook was installed.
Amending the commit to add a gerrit change id.
remote:
remote: Processing changes: updated: 1 (\)
remote: Processing changes: updated: 1 (|)
remote: Processing changes: updated: 1 (/)
remote: Processing changes: refs: 1, updated: 1 (/)
remote: Processing changes: refs: 1, updated: 1 (/)
remote: Processing changes: refs: 1, updated: 1, done
remote: commit cbe8209: warning: subject >50 characters; use shorter first paragraph
remote: warning: no changes between prior commit 9d0def2 and new commit cbe8209
remote:
remote: SUCCESS
remote:
remote: https://review.opendev.org/c/x/microstack/+/765001 Add command to README for retrieving admin password
remote:
To ssh://review.opendev.org:29418/x/microstack.git
 * [new branch] HEAD -> refs/for/master

tags: added: verification-done verification-done-bionic
removed: verification-needed verification-needed-bionic
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package git-review - 1.27.0-0ubuntu0.18.04.1

---------------
git-review (1.27.0-0ubuntu0.18.04.1) bionic; urgency=medium

  * d/gbp.conf: Update gbp configuration file.
  * d/control: Update Vcs-* links and maintainers.
  * New upstream release to enable compatiblity with updated
    review.opendev.org (LP: #1905282).

 -- Corey Bryant <email address hidden> Mon, 23 Nov 2020 10:29:10 -0500

Changed in git-review (Ubuntu Bionic):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of the Stable Release Update for git-review has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.