[SRU] Disable CRTCs when system becomes headless

Bug #1905825 reported by Kai-Heng Feng
20
This bug affects 1 person
Affects Status Importance Assigned to Milestone
HWE Next
Fix Released
Undecided
Unassigned
OEM Priority Project
Fix Released
Critical
Alex Tu
mutter (Ubuntu)
Fix Released
Undecided
Kai-Heng Feng
Focal
Fix Released
Undecided
Marco Trevisan (Treviño)
Groovy
Won't Fix
Undecided
Unassigned
Hirsute
Fix Released
Undecided
Kai-Heng Feng

Bug Description

[Impact]
On new Intel SoCs, after all connectors are unplugged and the system becomes headless, it cannot detect monitor hotplug event from type-c port.

[Fix]
https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1561

Based on "drm/i915 Intel GFX Driver, Hotplug" [1]:
"Finally, the userspace is responsible for triggering a modeset upon receiving the hotplug uevent, disabling or enabling the crtc as needed."

[Test]
Unplug type-c monitor from an Intel Tiger Lake desktop. Replug the monitor back, monitor is blank.
With the fix applied, the system can detect monitor again.

[Where problems could occur]
This fix disables CRTCs when there's no monitor, if driver has trouble dealing with it, we may see something break.

tags: added: focal groovy hirsute
Revision history for this message
Kai-Heng Feng (kaihengfeng) wrote :
tags: added: oem-priority originate-from-1898738 somerville
Changed in mutter (Ubuntu Hirsute):
assignee: nobody → Daniel van Vugt (vanvugt)
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Already in progress by Kai-Heng Feng.

Changed in mutter (Ubuntu Hirsute):
assignee: Daniel van Vugt (vanvugt) → Kai-Heng Feng (kaihengfeng)
status: New → In Progress
Revision history for this message
Martin Wimpress  (flexiondotorg) wrote :

Assign to Marco, to backport the upstream fixes to Focal.

Changed in mutter (Ubuntu Focal):
assignee: nobody → Kai-Heng Feng (kaihengfeng)
assignee: Kai-Heng Feng (kaihengfeng) → Marco Trevisan (Treviño) (3v1n0)
Revision history for this message
Kai-Heng Feng (kaihengfeng) wrote :
Revision history for this message
Amr Ibrahim (amribrahim1987) wrote :

mutter 3.36.8 is now out with the desired fixes:
https://gitlab.gnome.org/GNOME/mutter/-/blob/gnome-3-36/NEWS

It can be SRUed in Focal.

tags: added: fixed-in-3.36.8 fixed-upstream
tags: added: fixed-in-3.38.3
Changed in mutter (Ubuntu Hirsute):
status: In Progress → Fix Committed
Changed in mutter (Ubuntu Groovy):
status: New → Fix Committed
Changed in mutter (Ubuntu Focal):
status: New → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package mutter - 3.38.3-2ubuntu1

---------------
mutter (3.38.3-2ubuntu1) hirsute; urgency=medium

  * Merge with debian, containing new upstream release (LP: #1915025)
    - Disable CRTCs when system becomes headless (LP: #1905825)
    - Fixed crash during windows unmanagement (LP: #1870822)
    - Do not handle ungrabbed events when unmanaging (LP: #1880405)
    - Downgrade assert to warning when adding window (LP: #1911921)
  * d/p/x11-Add-support-for-fractional-scaling-using-Randr.patch:
    - Refreshed
  * debian/rules: Enable remote desktop for all linux builds (LP: #1730612)

mutter (3.38.3-2) unstable; urgency=medium

  * Team upload
  * d/patches: Update to commit 3.38.3-12-g2d424a739 from gnome-3-38 branch
    - Cope with monitors with metacharacters in their EDID data
    - Don't crash if parsing monitor configuration fails
    - Don't crash if an extension tries to add the same window to a
      workspace more than once, such as auto-move-windows
    - Cope with monitor configuration changes during screencasting
    - Speed up workspace switching when many windows are open
    - Fix Xwayland windows not always appearing in the gnome-shell overview
    - Avoid warning spam and poor performance when unmanaging a window
      (probably Closes: #970295, LP: #1841774)

mutter (3.38.3-1) unstable; urgency=medium

  * Team upload
  * d/watch: Only watch for 3.38.x versions
  * New upstream release

 -- Marco Trevisan (Treviño) <email address hidden> Tue, 09 Feb 2021 04:59:11 +0100

Changed in mutter (Ubuntu Hirsute):
status: Fix Committed → Fix Released
Revision history for this message
Rex Tsai (chihchun) wrote :

Macro do we have a plan when we can port the patches or upgrade to 3.36.8?

Changed in oem-priority:
importance: Undecided → Critical
assignee: nobody → Alex Tu (alextu)
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Hi Rex, took a while but it's now i focal queue.

Revision history for this message
Timo Aaltonen (tjaalton) wrote : Please test proposed package

Hello Kai-Heng, or anyone else affected,

Accepted mutter into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/mutter/3.36.9-0ubuntu0.20.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

tags: added: verification-needed verification-needed-focal
Revision history for this message
Kai-Heng Feng (kaihengfeng) wrote :

On Dell 3090 UFF, unplug then replug the monitor from Type-C connector, the monitor remains blank.

Enabled -proposed and upgrade the system, the monitor can be detected after replugging the Type-C connector.

tags: added: verification-done-focal
removed: verification-needed-focal
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package mutter - 3.36.9-0ubuntu0.20.04.1

---------------
mutter (3.36.9-0ubuntu0.20.04.1) focal; urgency=medium

  * New upstream release (LP: #1919143)
    - Do not ping unmanaging windows
    - Improve freezes when switching workspace
    - Fix drag cancel animation when using geometry scaling
    - Fix stuck icon in DND operation between X11 and wayland
    - Fix restoring focus to windows using globally active input
    - Fix _NET_WM_FRAME_DRAWN timestamps
    - Fix unwanted position changes on window resize
    - Fix device configuration not being picked up on X11
    - Fix size hints with CSD
    - Disable CRTCs if there is no monitor (LP: #1905825)
    - Fixed crashes
    - Plugged memory leaks

 -- Marco Trevisan (Treviño) <email address hidden> Wed, 31 Mar 2021 02:15:27 +0200

Changed in mutter (Ubuntu Focal):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of the Stable Release Update for mutter has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Matthew Ruffell (mruffell) wrote :

Hello,

Just a note that mutter 3.36.9-0ubuntu0.20.04.1 has introduced a regression in a VMware Horizon VDI environment, where gdm fails to start, and has taken out several hundred VDIs.

I am tracking the issue in bug 1930359.

The plan is to make a test package with the patches from bug 1905825 reverted before we start digging into the point release patches from 1919143.

Thanks,
Matthew

Revision history for this message
Brian Murray (brian-murray) wrote :

Given the regression of mutter in bug 1930359 should the SRU of mutter for Groovy continue to be pursued? If so bug 1841774 is still missing SRU information.

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Currently bug 1930359 seems to have nothing to do with this fix, based on the latest comment 8.

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

And I wasn't planning on SRUing bug 1841774. If anyone needs to then they can add the info.

Revision history for this message
Brian Murray (brian-murray) wrote :

The Groovy Gorilla has reached end of life, so this bug will not be fixed for that release

Changed in mutter (Ubuntu Groovy):
status: Fix Committed → Won't Fix
Changed in oem-priority:
status: New → Fix Released
Timo Aaltonen (tjaalton)
Changed in hwe-next:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.