recent/tagged journal entries block creates new entry on dragging

Bug #1907000 reported by Doris Tam
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Gold

Bug Description

When we are on the editing view of a page, the '+ New entry' text that appears on the top of the journal block, recent journal entries block, and tagged journal entries block is only detected as a button for the journal block and not the other two.

Dragging the recent journal entries block and tagged journal entries block's '+ New entry' area to reposition the block on the tag (upon releasing the mouse) opens up the '+ New entry' page.

Reproduce:
- create journal entries
- add tags to some entries
- create a new page
- add a journal block (configured correctly so that it displays journal entries)
- add a recent journal entries block (configured correctly so that it displays journal entries)
- add a tagged journal entries block (configured correctly so that it displays journal entries)
- on the edit view, move the mouse over the texts '+ New entry'

Expected: All three blocks with mouse hover displays a pointer
Actual: Only the journal block appears with a pointer on hover

- drag the recent journal entries block

Expected: Reposition the block to the new location
Actual: The page is directed to the new journal entry page

- drag the tagged journal entries block

Expected: Reposition the block to the new location
Actual: The page is directed to the new journal entry page

Tags: bite-sized
Doris Tam (doristam)
description: updated
Changed in mahara:
importance: Undecided → Medium
status: New → Confirmed
Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

I can only replicate the pointer issue but not the dragging issue with your patch https://reviews.mahara.org/#/c/11488/ so we might not have to worry about too much once that is merged.

Changed in mahara:
milestone: none → 21.04.0
tags: added: bite-sized
Gold (gold.catalyst)
Changed in mahara:
assignee: nobody → Gold (gold.catalyst)
status: Confirmed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/11540

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11540
Committed: https://git.mahara.org/mahara/mahara/commit/98a38d90553c19fc71a9d495670d7d6994131111
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 98a38d90553c19fc71a9d495670d7d6994131111
Author: Gold <email address hidden>
Date: Thu Feb 4 13:33:52 2021 +1300

Bug 1907000 - fix Add entry drag n drop.

* Added a new class to force the pointer cursor.
* Added this class to the Add entry anchors.
* Added a data flag to assist spotting the drag n drop activity when Add
entry is the element clicked for dragging the block.
* Added js to test this data flag before submitting on click.
* Renamed `AddNewPostShortcut()` in recent/tagged posts JS to better
identify them.

Change-Id: I3e367cd9323e9eb5ef18495d33ce6fa9c3c7c48d

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/11744

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.