Please merge librelp 1.9.0-1 (universe) from Debian unstable (main)

Bug #1910307 reported by Matthew Ruffell
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
librelp (Ubuntu)
Fix Released
Medium
Matthew Ruffell
Hirsute
Fix Released
Medium
Matthew Ruffell

Bug Description

[Impact]

librelp 1.9.0-1 is available in Debian, and is much newer than what we carry in Ubuntu 1.5.0-1ubuntu2. This bug tracks the merge to the newer version.

This bug is needed for the SRU of bug 1908473, which fixes a file descriptor leak in librelp. The leak was fixed in 1.7.0, so the merge to 1.9.0 contains the fix already.

[Testcase]

Test packages are available in the following ppa, with builds for all supported architectures, with debug symbols:

https://launchpad.net/~mruffell/+archive/ubuntu/lp1910307-test

Tags: patch sts
tags: added: sts
Changed in librelp (Ubuntu Hirsute):
status: New → In Progress
importance: Undecided → Wishlist
assignee: nobody → Matthew Ruffell (mruffell)
Revision history for this message
Matthew Ruffell (mruffell) wrote :

Attached is the debdiff from librelp_1.9.0-1.dsc to the new librelp_1.9.0-1ubuntu1.dsc

Revision history for this message
Matthew Ruffell (mruffell) wrote :

Attached is the debdiff from librelp_1.5.0-1ubuntu2.dsc to librelp_1.9.0-1ubuntu1.dsc

description: updated
Revision history for this message
Matthew Ruffell (mruffell) wrote :

Note - we no longer need to carry the "python2.diff" patch present in librelp_1.5.0-1ubuntu2.dsc due to the test system being ported to python3.

The tests have been changed so that the scripts are executed by a python interpreter, and not bash, so the shbangs for "/usr/bin/env python" are now dead code, and don't break the testsuite, like it once did in the old librelp_1.5.0-1ubuntu2.dsc version.

You can see the transition to being executed in a python interpreter in the below hunk:
https://paste.ubuntu.com/p/wwNwg8f4Zm/

Hence, it is safe to drop "python2.diff".

tags: added: sts-sponsor
Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "Debdiff with the merge from Debian" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

tags: added: patch
Revision history for this message
Eric Desrochers (slashd) wrote :

@Matthew

* Do you have a PPA where your merge of librelp can be found ?

* Could you please update d/changelog and mention that 'python2.diff' has been dropped.

Example:
 * Former patches:
   - d/p/python2.diff

I see you have noted it in LP which is good, but would be even better to have it marked done in d/changelog as well.

I'll continue to review once I have the PPA.

- Eric

description: updated
Revision history for this message
Matthew Ruffell (mruffell) wrote :

Attached is the revised debdiff between librelp_1.9.0-1.dsc and librelp_1.9.0-1ubuntu1.dsc

Revision history for this message
Matthew Ruffell (mruffell) wrote :

I built 1.9.0-1ubuntu0+lp1910307v20210113b2 in https://launchpad.net/~mruffell/+archive/ubuntu/lp1910307-test, and contains the identical code to the debdiff above. It builds successfully on all supported architectures, which also includes riscv64, which means the patch we merged in still works as intended.

Ready to merge.

Revision history for this message
Eric Desrochers (slashd) wrote :

[sts-sponsors][hirsute]

Sponsored in Hirsute.

Thanks for your contribution and testing Matthew.

- Eric

Changed in librelp (Ubuntu Hirsute):
importance: Wishlist → Medium
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package librelp - 1.9.0-1ubuntu1

---------------
librelp (1.9.0-1ubuntu1) hirsute; urgency=medium

  * Merge from Debian unstable. (LP: #1910307)
    Remaining changes:
    [ William Grant ]
    - d/p/shrink-receiver-abort-tests.sh: Reduce message count
      so tests pass on slow platforms like riscv64.
    Dropped changes:
    - d/p/python2.diff: No longer needed due to tests being
      ported to python3 in recent versions.
  * Fix file descriptor leak as sockets are stuck in CLOSE_WAIT
    due to not being closed properly due to memory leak. (LP: #1908473)

 -- Matthew Ruffell <email address hidden> Thu, 26 Nov 2020 21:52:43 +0000

Changed in librelp (Ubuntu Hirsute):
status: In Progress → Fix Released
Eric Desrochers (slashd)
tags: removed: sts-sponsor
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.