Ubuntu
golang-1.13 package

zLib link failures on Xenial

Bug #1913852 reported by rojer on 2021-01-30

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	golang-1.13 (Ubuntu)	Invalid	Undecided	Unassigned
	Xenial	Fix Released	Undecided	Unassigned

Bug Description

[impact]
Applications that use the "compress/zlib" package fail to build.

[test case]
$ cat > go.mod
module github.com/foo/baz

go 1.13
$ cat > main.go
package main

import (
"bytes"
"compress/zlib"
)

func main() {
        var b bytes.Buffer
        w := zlib.NewWriter(&b)
        w.Write([]byte("hello, world\n"))
        w.Close()
}
$ go build -v

The final command will fail before this is fixed and pass after.

[regression potential]
The fix is just preventing debhelper from stripping the zlib.a file in golang-1.13-go. Rebuilding the go toolchain one more time should not introduce any changes (the go project is pretty good about bootstrap hygiene).

[original description]
Backported go-1.13 came with issues with zlib.

In some projects i see link errors:

golang.org/x/crypto/openpgp/packet.(*Compressed).parse: relocation target compress/zlib.NewReaderDict not defined
github.com/go-git/go-git/v5/plumbing/format/packfile.NewEncoder: relocation target compress/zlib.NewWriterLevelDict not defined
github.com/go-git/go-git/v5/plumbing/format/packfile.(*Encoder).entry: relocation target compress/zlib.(*Writer).Reset not defined
github.com/go-git/go-git/v5/plumbing/format/packfile.(*Scanner).copyObject: relocation target type.compress/zlib.Resetter not defined
...

also reported in https://github.com/GoogleCloudPlatform/osconfig/issues/279

and compiling a trivial program (example from compress/zlib reference) causes crash during linking:

root@a6a24cdee4e3:/src/qqq# cat go.mod
module github.com/foo/baz

go 1.13
root@a6a24cdee4e3:/src/qqq# cat main.go
package main

import (
"bytes"
"compress/zlib"
)

func main() {
        var b bytes.Buffer
        w := zlib.NewWriter(&b)
        w.Write([]byte("hello, world\n"))
        w.Close()
}
root@a6a24cdee4e3:/src/qqq# go version
go version go1.13.8 linux/amd64
root@a6a24cdee4e3:/src/qqq# cat /etc/lsb-release
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=16.04
DISTRIB_CODENAME=xenial
DISTRIB_DESCRIPTION="Ubuntu 16.04.7 LTS"
root@a6a24cdee4e3:/src/qqq# go build -v
# github.com/foo/baz
panic: runtime error: index out of range [23] with length 0

goroutine 1 [running]:
cmd/link/internal/ld.decodetypeKind(...)
        /usr/lib/go-1.13/src/cmd/link/internal/ld/decodesym.go:69
cmd/link/internal/ld.newtype(0xc0006f4000, 0xc0007146e0, 0xc000618e68)
        /usr/lib/go-1.13/src/cmd/link/internal/ld/dwarf.go:424 +0x29e1
cmd/link/internal/ld.defgotype(0xc0006f4000, 0xc0007146e0, 0x1a)
        /usr/lib/go-1.13/src/cmd/link/internal/ld/dwarf.go:419 +0x1c8
cmd/link/internal/ld.dwarfGenerateDebugInfo(0xc0006f4000)
        /usr/lib/go-1.13/src/cmd/link/internal/ld/dwarf.go:1900 +0x91c
cmd/link/internal/ld.Main(0x84cdc0, 0x10, 0x20, 0x1, 0x7, 0x10, 0x69ac6f, 0x1b, 0x697756, 0x14, ...)
        /usr/lib/go-1.13/src/cmd/link/internal/ld/main.go:212 +0xb92
main.main()
        /usr/lib/go-1.13/src/cmd/link/main.go:65 +0x1d6

See original description

Tags:

Revision history for this message

Michael Hudson-Doyle (mwhudson) wrote on 2021-02-10:

Huh this is very strange. I notice that go build -a succeeds so I wonder if one of the .a files that's part of golang-1.13-go is broken somehow?

Revision history for this message

rojer (rojer9) wrote on 2021-02-10:

yes, zlib.a is bad:

root@26d441ac192e:/usr/lib/go-1.13/src/cmd/link# go tool nm /usr/lib/go-1.13/pkg/linux_amd64/compress/zlib.a | head
open /usr/lib/go-1.13/pkg/linux_amd64/compress/zlib.a: unrecognized object file

on the surface it does look like go archive but obviously something is not quite right.
gzip.a in the same directory is fine:

root@26d441ac192e:/usr/lib/go-1.13/src/cmd/link# go tool nm /usr/lib/go-1.13/pkg/linux_amd64/compress/gzip.a | head
         U
         U bufio.(*Reader).Read
         U bufio.(*Reader).ReadByte
         U bufio..inittask
         U compress/flate.(*Writer).Reset
         U compress/flate.(*compressor).close
         U compress/flate.(*compressor).syncFlush
         U compress/flate.(*compressor).write
         U compress/flate..inittask
         U compress/flate.NewReader

Revision history for this message

Michael Hudson-Doyle (mwhudson) wrote on 2021-02-10:

Well here's a funny thing:

root@xenial:~/zzzz# go tool pack tv /usr/lib/go-1.13/pkg/linux_amd64/compress/zlib.a
-rw-r--r-- 0/0 5145 Jan 1 00:00 1970 __.PKGDEF/
-rw-r--r-- 0/0 46655 Jan 1 00:00 1970 _go_.o/

why are there / on the end of the archive names? No idea, but it's probably why nothing is happy.

Revision history for this message

Michael Hudson-Doyle (mwhudson) wrote on 2021-02-11:

Ohhhhh I have dealt with this before: the problem is that debhelper (in xenial) thinks that "zlib.a" is a static library (it's trying to find files with names of the form "libXXX.a" but uses a bad regex) and feeds it to strip as part of the package build, which mangles the file.

Michael Hudson-Doyle (mwhudson) on 2021-02-11

description:

updated

Revision history for this message

Michael Hudson-Doyle (mwhudson) wrote on 2021-02-11:

I've uploaded a fix to unapproved. You can also try the version from https://launchpad.net/~mwhudson/+archive/ubuntu/devirt/+packages to see if it helps.

Revision history for this message

rojer (rojer9) wrote on 2021-02-11:

yep, confirmed that 1.13.8-1ubuntu1~16.04.3~ppa1 fixes the issue

Revision history for this message

Brian Murray (brian-murray) wrote on 2021-02-16: Please test proposed package

Hello rojer, or anyone else affected,

Accepted golang-1.13 into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/golang-1.13/1.13.8-1ubuntu1~16.04.3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in golang-1.13 (Ubuntu Xenial):
status:	New → Fix Committed
tags:	added: verification-needed verification-needed-xenial
Changed in golang-1.13 (Ubuntu):
status:	New → Invalid

Revision history for this message

rojer (rojer9) wrote on 2021-04-13:

verified that 1.13.8-1ubuntu1~16.04.3 works

tags:	added: verification-done-xenial removed: verification-needed verification-needed-xenial
tags:	added: verification-needed

Revision history for this message

Chris Halse Rogers (raof) wrote on 2021-04-14: Update Released

The verification of the Stable Release Update for golang-1.13 has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message

Launchpad Janitor (janitor) wrote on 2021-04-14:

#10

This bug was fixed in the package golang-1.13 - 1.13.8-1ubuntu1~16.04.3

---------------
golang-1.13 (1.13.8-1ubuntu1~16.04.3) xenial; urgency=medium

* Workaround a debhelper/binutils combo bug on Xenial where compress/zlib.a
gets stripped, which mangles it. (LP: #1913852)

-- Michael Hudson-Doyle <email address hidden> Thu, 11 Feb 2021 14:39:49 +1300

Changed in golang-1.13 (Ubuntu Xenial):
status:	Fix Committed → Fix Released

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.

Ubuntugolang-1.13 package

zLib link failures on Xenial

Bug Description

Other bug subscribers

Remote bug watches

Ubuntu
golang-1.13 package