SRU: Always update the initramfs when changing power profile

IMHO, shall we have a kernel boot parameter so that the script in the initrd check and decide what to load and/or parameter to added.

If that's too much work, maybe put that as a long-term goal.

I think that change has a different scope, and needs further discussion. The fix in this bug report works with the way we currently do things.

Hello Alberto, or anyone else affected,

Accepted nvidia-settings into groovy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/nvidia-settings/460.39-0ubuntu0.20.10.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-groovy to verification-done-groovy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-groovy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Hello Alberto, or anyone else affected,

Accepted nvidia-prime into groovy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/nvidia-prime/0.8.16~0.20.10.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-groovy to verification-done-groovy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-groovy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Hello Alberto, or anyone else affected,

Accepted nvidia-settings into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/nvidia-settings/460.39-0ubuntu0.20.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Hello Alberto, or anyone else affected,

Accepted nvidia-prime into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/nvidia-prime/0.8.16~0.20.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Hello Alberto, or anyone else affected,

Accepted nvidia-settings into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/nvidia-settings/460.39-0ubuntu0.18.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Ok, I have accepted all the packages into -proposed pockets besides nvidia-prime for bionic. There seems to be an old unverified nvidia-prime/u-d-c SRU in bionic-proposed that needs to be handled first. Can someone take a look at LP: #1904583?

Another thing: since this is a whole backport of the prime-settings, I'd like some more aging and manual exploratory testing of this before we proceed.

Final thing, regarding the nvidia-prime part: looking at the diff I saw this change bundled in it:
@@ -152,10 +154,10 @@
             # (No need to check if nvidia is available)
             self._enable_nvidia()
         elif profile == "on-demand":
- self._disable_nvidia(keep_nvidia_modules=True)
             if self._supports_runtimepm():
                 self._enable_runtimepm()
                 self._enable_kms()
+ self._disable_nvidia(keep_nvidia_modules=True)
         else:
             # Make sure that the installed packages support PRIME
             #if not self._supports_prime():

I only noticed it after already accepting groovy. Just wanted to make sure: is this related to the initramfs update? Was it needed? Is this change expected?

Thank you.

Hello Alberto, or anyone else affected,

Accepted nvidia-prime into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/nvidia-prime/0.8.16~0.18.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

# verified pass on focal:

## package version as expected.
ubuntu@dell-bto-focal-fossa-nvstaging-202005-27873:~$ apt list ubuntu-drivers-common nvidia-prime
Listing... Done
nvidia-prime/focal-proposed,focal-proposed,now 0.8.16~0.20.04.1 all [installed,automatic]
ubuntu-drivers-common/focal-updates,now 1:0.8.6.5~0.20.04.1 amd64 [installed,automatic]

## check if module option in initrd in on-demand mode.
$ sudo prime-select on-demand
Info: selecting the on-demand profile
Writing /lib/modprobe.d/nvidia-runtimepm.conf
Updating the initramfs. Please wait for the operation to complete:
Done

### then I see the module option in initrd correctly.
main/usr/lib/modprobe.d/nvidia-runtimepm.conf:1:options nvidia "NVreg_DynamicPowerManagement=0x02"

## check if module option not in initrd in nvidia mode.

$ sudo prime-select nvidia
Info: selecting the nvidia profile
Deleting /lib/modprobe.d/nvidia-runtimepm.conf
Done

### then the module option "NVreg_DynamicPowerManagement=0x02" is removed from initrd correctly.

# suggestion:
On nvidia settings UI, there's no message saying it's building initrd after user select on-demand mode. So, the nvidia settings looks like just hangs up when it's building initrd.

If user have multiple kernel before selecting on-demand, user might be confused and treat it as nvidia settings UI hangs up then force close it or reboot machine.

@Alex: there should still be a progress dialog, regardless of the power profile.

Do you have the new nvidia-settings package?

@Łukasz I verified LP: #1904583

Also, the reason why I moved self._disable_nvidia() down is that we want the other stuff that ends up in the modprobe conf file (from self._enable_runtimepm() and self._enable_kms()) to take place before we update the initramfs, which we do in self._disable_nvidia().

So it's all correct.

Verified on a Kubuntu Focus M1 running focal:

erich@erich-KFocus:~$ apt-cache policy nvidia-settings
nvidia-settings:
  Installed: 460.39-0ubuntu0.20.04.1
  Candidate: 460.39-0ubuntu0.20.04.1
  Version table:
 *** 460.39-0ubuntu0.20.04.1 100
        100 /var/lib/dpkg/status

Works exactly as expected complete with a "Please wait for the operation to complete" progress indicator.

Verified on a Kubuntu Focus M1 running focal:

erich@erich-KFocus:~$ apt-cache policy nvidia-settings
nvidia-settings:
  Installed: 460.39-0ubuntu0.20.10.1
  Candidate: 460.39-0ubuntu0.20.10.1
  Version table:
 *** 460.39-0ubuntu0.20.10.1 100
        100 /var/lib/dpkg/status

Works exactly as expected complete with a "Please wait for the operation to complete" progress indicator.

Meant to say groovy in #15 (oops)

This bug was fixed in the package nvidia-settings - 460.39-0ubuntu0.20.10.1

---------------
nvidia-settings (460.39-0ubuntu0.20.10.1) groovy; urgency=medium

  * New upstream release.
  * debian/patches/link-order.diff,
    debian/patches/12_nostrip.patch,
    debian/patches/05_add_polkit_support.patch,
    debian/patches/06_remove_local_prefix.patch,
    debian/patches/07_remove_features_for_legacy.patch
    debian/patches/08_add_prime_support.patch
    debian/patches/10_legacy_vdpau.patch
    debian/patches/11_link_as-needed.patch
    debian/patches/13_libxnvctrl_so_0.patch
    debian/patches/15_clean.patch:
    - Refresh patches.
  * debian/patches/series:
    - Drop 16_gzip-n.patch.
  * debian/patches/08_add_prime_support.patch:
    - Refresh and add support for a progress dialog
      (LP: #1915003).

 -- Alberto Milone <email address hidden> Wed, 03 Feb 2021 18:09:00 +0100

The verification of the Stable Release Update for nvidia-settings has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

This bug was fixed in the package nvidia-prime - 0.8.16~0.20.10.1

---------------
nvidia-prime (0.8.16~0.20.10.1) groovy; urgency=medium

  * prime-select:
    - Make sure to update the initramfs, so that
      the driver options can be applied correctly.
      This time around we can also provide visual
      feedback (in the form of a progress spinner)
      while update-initramfs is running (LP: #1915003).

 -- Alberto Milone <email address hidden> Wed, 10 Feb 2021 12:36:51 +0100

This bug was fixed in the package nvidia-prime - 0.8.16~0.20.04.1

---------------
nvidia-prime (0.8.16~0.20.04.1) focal; urgency=medium

  * prime-select:
    - Make sure to update the initramfs, so that
      the driver options can be applied correctly.
      This time around we can also provide visual
      feedback (in the form of a progress spinner)
      while update-initramfs is running (LP: #1915003).

 -- Alberto Milone <email address hidden> Wed, 10 Feb 2021 12:38:51 +0100

This bug was fixed in the package nvidia-settings - 460.39-0ubuntu0.20.04.1

---------------
nvidia-settings (460.39-0ubuntu0.20.04.1) focal; urgency=medium

  * New upstream release.
  * debian/patches/link-order.diff,
    debian/patches/12_nostrip.patch,
    debian/patches/05_add_polkit_support.patch,
    debian/patches/06_remove_local_prefix.patch,
    debian/patches/07_remove_features_for_legacy.patch
    debian/patches/08_add_prime_support.patch
    debian/patches/10_legacy_vdpau.patch
    debian/patches/11_link_as-needed.patch
    debian/patches/13_libxnvctrl_so_0.patch
    debian/patches/15_clean.patch:
    - Refresh patches.
  * debian/patches/series:
    - Drop 16_gzip-n.patch.
  * debian/patches/08_add_prime_support.patch:
    - Refresh and add support for a progress dialog
      (LP: #1915003).

 -- Alberto Milone <email address hidden> Wed, 03 Feb 2021 22:11:10 +0100

For bionic, it seems that the new nvidia-settings FTBFS on amd64. Can someone take a look at that?

I have fixed the bionic build in 460.39-0ubuntu0.18.04.2. I had accidentally dropped a change that is only required for bionic.

Hello Alberto, or anyone else affected,

Accepted nvidia-settings into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/nvidia-settings/460.39-0ubuntu0.18.04.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Can we get this verified?

All good on Bionic too:

:~$ apt-cache policy nvidia-prime
nvidia-prime:
  Installed: 0.8.16~0.18.04.1
  Candidate: 0.8.16~0.18.04.1
  Version table:
 *** 0.8.16~0.18.04.1 500
        500 http://it.archive.ubuntu.com/ubuntu bionic-proposed/main amd64 Packages
        500 http://it.archive.ubuntu.com/ubuntu bionic-proposed/main i386 Packages
        100 /var/lib/dpkg/status
     0.8.8.2 500
        500 http://it.archive.ubuntu.com/ubuntu bionic-updates/main amd64 Packages
        500 http://it.archive.ubuntu.com/ubuntu bionic-updates/main i386 Packages
     0.8.8 500
        500 http://it.archive.ubuntu.com/ubuntu bionic/main amd64 Packages
        500 http://it.archive.ubuntu.com/ubuntu bionic/main i386 Packages

:~$ apt-cache policy nvidia-settings
nvidia-settings:
  Installed: 460.39-0ubuntu0.18.04.2
  Candidate: 460.39-0ubuntu0.18.04.2
  Version table:
 *** 460.39-0ubuntu0.18.04.2 500
        500 http://it.archive.ubuntu.com/ubuntu bionic-proposed/main amd64 Packages
        100 /var/lib/dpkg/status
     440.82-0ubuntu0.18.04.1 500
        500 http://it.archive.ubuntu.com/ubuntu bionic-updates/main amd64 Packages
     390.42-0ubuntu1 500
        500 http://it.archive.ubuntu.com/ubuntu bionic/main amd64 Packages

This bug was fixed in the package nvidia-settings - 460.39-0ubuntu0.18.04.2

---------------
nvidia-settings (460.39-0ubuntu0.18.04.2) bionic; urgency=medium

  * debian/patches/13_libxnvctrl_so_0.patch:
    - Put -fPIC back in for XNVCTRL_CFLAGS.
      This is only needed in bionic, and was accidentally
      dropped.

nvidia-settings (460.39-0ubuntu0.18.04.1) bionic; urgency=medium

  * New upstream release.
  * debian/patches/link-order.diff,
    debian/patches/12_nostrip.patch,
    debian/patches/05_add_polkit_support.patch,
    debian/patches/06_remove_local_prefix.patch,
    debian/patches/07_remove_features_for_legacy.patch
    debian/patches/08_add_prime_support.patch
    debian/patches/10_legacy_vdpau.patch
    debian/patches/11_link_as-needed.patch
    debian/patches/13_libxnvctrl_so_0.patch
    debian/patches/15_clean.patch:
    - Refresh patches.
  * debian/patches/series:
    - Drop 16_gzip-n.patch.
  * debian/patches/08_add_prime_support.patch:
    - Refresh and add support for a progress dialog
      (LP: #1915003).

 -- Alberto Milone <email address hidden> Thu, 04 Mar 2021 13:00:10 +0100

This bug was fixed in the package nvidia-prime - 0.8.16~0.18.04.1

---------------
nvidia-prime (0.8.16~0.18.04.1) bionic; urgency=medium

  * prime-select:
    - Make sure to update the initramfs, so that
      the driver options can be applied correctly.
      This time around we can also provide visual
      feedback (in the form of a progress spinner)
      while update-initramfs is running (LP: #1915003).

nvidia-prime (0.8.15.3~0.18.04.1) bionic; urgency=medium

  * Backport 0.8.15.3 (LP: #1904583).

 -- Alberto Milone <email address hidden> Wed, 10 Feb 2021 12:56:24 +0100