Cannot close the modal "Connect to Wifi" window to return to desktop

Bug #1918666 reported by Rocko
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
GNOME Shell
Fix Released
Unknown
gjs (Ubuntu)
Fix Released
Critical
Sebastien Bacher
gnome-shell (Ubuntu)
Fix Released
Critical
Daniel van Vugt

Bug Description

When I select the task bar menu, click on the Wifi and select "Select to network", a modal window appears that allows me to select a Wifi network.

After I have clicked on one of the networks, normally, when I click Cancel or Connect, the modal window disappears and returns me to the desktop.

With the current gnome-shell, this modal window persists and I cannot access the desktop - this is both in Wayland and in X. Connect doesn't seem to work - it's like the buttons are no longer accepting clicks. The ESC key also doesn't do anything. (If I don't click on a network, the ESC key does work, and so does Cancel.)

I think I once managed to get Alt-Ctrl-F1 to bring back the GDM login window, but the modal window was still there when I went back into the desktop.

Alt-F2 didn't work so I couldn't try re-starting gnome-shell.

ProblemType: Bug
DistroRelease: Ubuntu 21.04
Package: gnome-shell 3.38.3-3ubuntu1
ProcVersionSignature: Ubuntu 5.11.0-11.12-generic 5.11.0
Uname: Linux 5.11.0-11-generic x86_64
NonfreeKernelModules: nvidia_modeset nvidia
ApportVersion: 2.20.11-0ubuntu60
Architecture: amd64
CasperMD5CheckResult: unknown
CurrentDesktop: ubuntu:GNOME
Date: Thu Mar 11 20:35:24 2021
DisplayManager: gdm3
RelatedPackageVersions: mutter-common 3.38.3-3ubuntu2
SourcePackage: gnome-shell
UpgradeStatus: Upgraded to hirsute on 2021-02-24 (15 days ago)

Revision history for this message
Rocko (rockorequin) wrote :
Rocko (rockorequin)
description: updated
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in gnome-shell (Ubuntu):
status: New → Confirmed
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Confirmed and I notice:

Mar 12 10:04:40 kab gnome-shell[1586]: JS ERROR: Error: Argument timestamp: value is out of range for uint32
                                       popModal@resource:///org/gnome/shell/ui/main.js:637:12
                                       popModal@resource:///org/gnome/shell/ui/modalDialog.js:205:14
                                       close@resource:///org/gnome/shell/ui/modalDialog.js:178:14

...
Mar 12 10:04:46 kab gnome-shell[1586]: pushModal: invocation of begin_modal failed

tags: added: rls-hh-incoming
Changed in gnome-shell (Ubuntu):
importance: Undecided → Critical
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Slightly similar to bug 1918738.

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Seems to be a regression in gjs 1.67.2-2 and downgrading to the previous version fixes it for me:

https://launchpad.net/ubuntu/+source/gjs/1.67.2-1/+build/21079029

summary: - Cannot close the modal "Connect to Wifi" window to return to desktop
+ [regression] Shell regressions in 1.67.2-2 starting with "JS ERROR:
+ Error: Argument <name>: value is out of range for uint32"
Changed in gjs (Ubuntu):
importance: Undecided → Critical
status: New → Triaged
no longer affects: gnome-shell (Ubuntu)
Changed in gjs (Ubuntu):
assignee: nobody → Marco Trevisan (Treviño) (3v1n0)
summary: - [regression] Shell regressions in 1.67.2-2 starting with "JS ERROR:
- Error: Argument <name>: value is out of range for uint32"
+ Shell regressions in 1.67.2-2 starting with "JS ERROR: Error: Argument
+ <name>: value is out of range for uint32"
tags: added: regression-release
summary: - Shell regressions in 1.67.2-2 starting with "JS ERROR: Error: Argument
- <name>: value is out of range for uint32"
+ Shell regressions in gjs 1.67.2-2 starting with "JS ERROR: Error:
+ Argument <name>: value is out of range for uint32"
Revision history for this message
Daniel van Vugt (vanvugt) wrote : Re: Shell regressions in gjs 1.67.2-2 starting with "JS ERROR: Error: Argument <name>: value is out of range for uint32"

The same change also landed in gjs upstream an hour ago: https://gitlab.gnome.org/GNOME/gjs/-/merge_requests/583

For hirsute however we should probably revert it. Because we're going to keep finding places in gnome-shell that now fail with the error checking for some time to come. And while that happens, random parts of the shell will break. So the new error checking is not something we should introduce right now at the end of the cycle.

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

The associated fixes for gnome-shell should be proposed upstream for GNOME 40/41.

Changed in gnome-shell (Ubuntu):
importance: Undecided → Critical
status: New → Triaged
no longer affects: gnome-shell (Ubuntu)
Changed in gjs (Ubuntu):
assignee: Marco Trevisan (Treviño) (3v1n0) → Daniel van Vugt (vanvugt)
status: Triaged → In Progress
Revision history for this message
Daniel van Vugt (vanvugt) wrote :
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Also the offending change in gjs 1.67.2-2 is a feature, not a bug fix. So it probably shouldn't have happened at all after feature freeze.

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Since these bugs are going to keep occuring in different places, and the eventual fixes for gnome-shell for each will be different, I have separated out bug 1918738 again.

The short term fix for hirsute should still be https://salsa.debian.org/gnome-team/gjs/-/merge_requests/17

summary: - Shell regressions in gjs 1.67.2-2 starting with "JS ERROR: Error:
- Argument <name>: value is out of range for uint32"
+ Cannot close the modal "Connect to Wifi" window to return to desktop
Changed in gnome-shell (Ubuntu):
importance: Undecided → Critical
status: New → Triaged
Revision history for this message
Daniel van Vugt (vanvugt) wrote :
Changed in gnome-shell (Ubuntu):
assignee: nobody → Daniel van Vugt (vanvugt)
status: Triaged → In Progress
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

gjs (1.67.2-2ubuntu1) hirsute; urgency=medium

  * Revert NaN handling changes which were included in the previous
    revision but not mentioned in the changelog, that's creating issues
    for the shell (lp: #1918738)

 -- Sebastien Bacher <email address hidden> Fri, 12 Mar 2021 09:25:26 +0100

Changed in gjs (Ubuntu):
assignee: Daniel van Vugt (vanvugt) → Sebastien Bacher (seb128)
assignee: Sebastien Bacher (seb128) → Daniel van Vugt (vanvugt)
status: In Progress → Fix Released
assignee: Daniel van Vugt (vanvugt) → Sebastien Bacher (seb128)
Changed in gnome-shell (Ubuntu):
status: In Progress → Fix Committed
tags: added: fixed-in-40 fixed-upstream
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (3.9 KiB)

This bug was fixed in the package gnome-shell - 3.38.4-1ubuntu1

---------------
gnome-shell (3.38.4-1ubuntu1) hirsute; urgency=medium

  * Merge with debian, containing a new upstream release
  * debian/control: (Build-)Depends on mutter 3.38.4
  * debian/patches:
    - Refresh
    - Remove input-thread related patches
    - Fix handling of OSK codes in keyboard (LP: #1918738)
    - Ensure Cancel button uses proper arguments (LP: #1918666)
    - Allow updating struts in Overview (LP: #1917939)
    - Configure Login Scree: cleanup code to match shell's JS
  * Remaining changes with debian:
    - Replace gnome-backgrounds dep with ubuntu-wallpapers and Suggests
      gnome-themes-standard-data, gnome-backgrounds
    - Add some Recommends:
      + ubuntu-session (| gnome-session) to have the ubuntu session available
      + xserver-xorg-legacy
      + yaru-theme-gnome-shell for the default ubuntu theming
    - Update debian/gbp.conf with Ubuntu settings
    - gnome-shell-common.prerm: Remove deprecated ubuntu theme alternative
    - ubuntu/desktop_detect.patch:
      + add caching for desktop detection to avoid querying the current
        desktop env variable as iterate through the list each time. For the
        time of the Shell process, we can expect this env variable to stay
        stable.
    - ubuntu/smarter_alt_tab.patch:
      + quick alt-tab (without showing up the switcher) switch only between
        the last window of the last 2 applications to be focused instead of
        raising all windows of those apps.
    - ubuntu/lightdm-user-switching.patch:
      + Allow user switching when using LightDM.
    - ubuntu/lock_on_suspend.patch
      + Respect Ubuntu's lock-on-suspend setting.
    - ubuntu/background_login.patch
      + Change default background color as we modified the default GDM color
        for our ubuntu session.
    - ubuntu/gdm_alternatives.patch
      + Add support for GDM3 theme alternatives
    - optional-hot-corner.patch
      + enable patch proposed by upstream developer already in package (but
        not in series) to add a settings for optional hot corner activation.
    - main-show-an-error-message-on-gnome-shell-crash.patch,
      global-make-possible-to-set-debug-flags-dynamically.patch,
      main-increase-the-granularity-of-backtraces-in-SHELL_DEBU.patch,
      main-add-backtrace-crashes-all-and-backtrace-all.patch,
      sessionMode-add-support-for-debugFlags-parameter.patch:
      + Improve debug JS tracing for crash reports
    - st-scroll-view-Handle-the-case-where-scrollbars-are-NULL.patch:
      + Fix crash on theme changes
    - ubuntu/search-call-XUbuntuCancel-method-on-providers-when-no-dat.patch:
      + stop searches when requested from UI
    - magnifier-Show-cursor-when-magnifier-is-enabled-and-scale.patch:
      + Show monitor scaled cursor when magnifier is enabled
    - Break gnome-shell-extension-desktop-icons (<< 19.01.3+git20190814)

gnome-shell (3.38.4-1) unstable; urgency=medium

  * Team upload
  * New upstream release
    - Fix missing X11 fallback icons (particularly for games and other
      programs not installed system-wide), a regression in 3.37.3
    - Fix a Shell crash when a...

Read more...

Changed in gnome-shell (Ubuntu):
status: Fix Committed → Fix Released
tags: added: fixed-in-3.38.5
Changed in gnome-shell:
status: Unknown → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.