Ubuntu
sosreport package

[sos4.1][Policy|Ubuntu] Upload no longer working

Bug #1923209 reported by Eric Desrochers
16
This bug affects 2 people
Affects Status Importance Assigned to Milestone
sosreport (Ubuntu)
Fix Released
Medium
Eric Desrochers
Bionic
Fix Released
Medium
Eric Desrochers
Focal
Fix Released
Medium
Eric Desrochers
Groovy
Fix Released
Medium
Eric Desrochers
Hirsute
Fix Released
Medium
Eric Desrochers

Bug Description

[Impact]

UA customer can no longer instruct sos to upload the sos archive in our Canonical FTP automatically. One would need to manually sftp the file as a separate task.

[Test Case]

Run sos with the --upload option for instance as follow:

$ sos report -o ubuntu --upload

sosreport (version 4.1)

This command will collect system configuration and diagnostic
information from this Ubuntu system.

For more information on Canonical visit:

        Community Website : https://www.ubuntu.com/
        Commercial Support : https://www.canonical.com

The generated archive may contain data considered sensitive and its
content should be reviewed by the originating organization before being
passed to any third party.

No changes will be made to system configuration.

Press ENTER to continue, or CTRL-C to quit.

Please enter the case id that you are generating this report for []:
Traceback (most recent call last):
  File "/usr/bin/sos", line 22, in <module>
    sos.execute()
  File "/usr/lib/python3/dist-packages/sos/__init__.py", line 186, in execute
    self._component.execute()
  File "/usr/lib/python3/dist-packages/sos/report/__init__.py", line 1372, in execute
    self.prework()
  File "/usr/lib/python3/dist-packages/sos/report/__init__.py", line 857, in prework
    self.policy.pre_work()
  File "/usr/lib/python3/dist-packages/sos/policies/distros/__init__.py", line 163, in pre_work
    if cmdline_opts.upload and self.get_upload_url():
  File "/usr/lib/python3/dist-packages/sos/policies/distros/ubuntu.py", line 77, in get_upload_url
    fname = os.path.basename(self.upload_archive)
  File "/usr/lib/python3.9/posixpath.py", line 142, in basename
    p = os.fspath(p)
TypeError: expected str, bytes or os.PathLike object, not method

[Where problem could occur]

Worse case scenario, the sos archive upload still won't work to our UA customer FTP, and one would have to transfer us the sos archive manually via 'sftp' as an separate task.

It won't affect other sos functionnalites nor execution.

[Other information]

Upstream commit:
https://github.com/sosreport/sos/commit/3c90f654dc10c107003d6061ce6346c191269a87

See original description
Eric Desrochers (slashd)
Changed in sosreport (Ubuntu):
importance: Undecided → Low
tags: added: seg sts
description: updated
Changed in sosreport (Ubuntu Bionic):
importance: Undecided → Low
Changed in sosreport (Ubuntu Focal):
importance: Undecided → Medium
Changed in sosreport (Ubuntu Bionic):
importance: Low → Medium
Changed in sosreport (Ubuntu):
importance: Low → Medium
Changed in sosreport (Ubuntu Groovy):
importance: Undecided → Medium
Eric Desrochers (slashd)
description: updated
Eric Desrochers (slashd)
description: updated
description: updated
Eric Desrochers (slashd)
description: updated
Eric Desrochers (slashd)
Changed in sosreport (Ubuntu):
status: New → In Progress
assignee: nobody → Eric Desrochers (slashd)
summary: - [sos4.1] Upload no longer working
+ [sos4.1][Policy|Ubuntu] Upload no longer working
Eric Desrochers (slashd)
description: updated
Revision history for this message
Eric Desrochers (slashd) wrote :

We are in the middle of a non-lts freeze schedule release (21.04).
As soon as 'hirsute' become stable, and we start the new cycle for 'II' release. I'll start the SRU.

- Eric

description: updated
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package sosreport - 4.1-1ubuntu2

---------------
sosreport (4.1-1ubuntu2) impish; urgency=medium

  * d/p/series:
    - Re-order patches in numerical order.

  * d/p/0003-ubuntu-policy-fix-upload.patch:
    - Fix sos archive upload to UA Canonical server
      (LP: #1923209)

  * d/p/0004-chrony-configuration-can-now-be-fragmented.patch:
    - Chrony 4.0, first introduced in Hirsute, support
      fragmented configuration.

  * d/p/0005-global-drop-plugin-version.patch:
    - Removal of plugins versionning features as it generate
      unhelpful noise. (LP: #1922925)

  * d/p/0006-networking-check-presence-of-devlink.patch:
    - On certain kernel configuration, devlink cmds may
      trigger the module to load automatically. This will
      also prevent simple.sh, part of the autopkgtest, in
      Bionic to fail due to devlink kernel conf in 4.15.
      (LP: #1923661)

  * d/p/0007-sosnode-avoid-checksum-cleanup-if-no-archive.patch:
    - Fixes an exception propagation from `cleanup()`
      where an attempt to look for and remove a checksum
      file was made when an archive was not generated.
      (LP: #1923641)

 -- Eric Desrochers <email address hidden> Mon, 26 Apr 2021 15:34:42 -0400

Changed in sosreport (Ubuntu):
status: In Progress → Fix Released
Revision history for this message
Eric Desrochers (slashd) wrote :

Uploaded in H/G/F/B.

Changed in sosreport (Ubuntu Bionic):
status: New → In Progress
Changed in sosreport (Ubuntu Focal):
status: New → In Progress
Changed in sosreport (Ubuntu Groovy):
status: New → In Progress
assignee: nobody → Eric Desrochers (slashd)
Changed in sosreport (Ubuntu Focal):
assignee: nobody → Eric Desrochers (slashd)
Changed in sosreport (Ubuntu Bionic):
assignee: nobody → Eric Desrochers (slashd)
Revision history for this message
Timo Aaltonen (tjaalton) wrote : Please test proposed package

Hello Eric, or anyone else affected,

Accepted sosreport into hirsute-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/sosreport/4.1-1ubuntu1.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-hirsute to verification-done-hirsute. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-hirsute. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in sosreport (Ubuntu Hirsute):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-hirsute
Changed in sosreport (Ubuntu Groovy):
status: In Progress → Fix Committed
tags: added: verification-needed-groovy
Revision history for this message
Timo Aaltonen (tjaalton) wrote :

Hello Eric, or anyone else affected,

Accepted sosreport into groovy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/sosreport/4.1-1ubuntu0.20.10.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-groovy to verification-done-groovy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-groovy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in sosreport (Ubuntu Focal):
status: In Progress → Fix Committed
tags: added: verification-needed-focal
Revision history for this message
Timo Aaltonen (tjaalton) wrote :

Hello Eric, or anyone else affected,

Accepted sosreport into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/sosreport/4.1-1ubuntu0.20.04.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in sosreport (Ubuntu Bionic):
status: In Progress → Fix Committed
tags: added: verification-needed-bionic
Revision history for this message
Timo Aaltonen (tjaalton) wrote :

Hello Eric, or anyone else affected,

Accepted sosreport into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/sosreport/4.1-1ubuntu0.18.04.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Revision history for this message
Ubuntu SRU Bot (ubuntu-sru-bot) wrote : Autopkgtest regression report (sosreport/4.1-1ubuntu1.1)

All autopkgtests for the newly accepted sosreport (4.1-1ubuntu1.1) for hirsute have finished running.
The following regressions have been reported in tests triggered by the package:

sosreport/4.1-1ubuntu1.1 (amd64, ppc64el)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/hirsute/update_excuses.html#sosreport

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

Revision history for this message
Ubuntu SRU Bot (ubuntu-sru-bot) wrote : Autopkgtest regression report (sosreport/4.1-1ubuntu0.20.04.2)

All autopkgtests for the newly accepted sosreport (4.1-1ubuntu0.20.04.2) for focal have finished running.
The following regressions have been reported in tests triggered by the package:

sosreport/4.1-1ubuntu0.20.04.2 (ppc64el, s390x, amd64)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/focal/update_excuses.html#sosreport

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

Revision history for this message
Ubuntu SRU Bot (ubuntu-sru-bot) wrote : Autopkgtest regression report (sosreport/4.1-1ubuntu0.20.10.2)

All autopkgtests for the newly accepted sosreport (4.1-1ubuntu0.20.10.2) for groovy have finished running.
The following regressions have been reported in tests triggered by the package:

sosreport/4.1-1ubuntu0.20.10.2 (ppc64el, s390x, amd64, arm64)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/groovy/update_excuses.html#sosreport

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

Revision history for this message
Eric Desrochers (slashd) wrote :

[VERIFICATION BIONIC]

I ran the following command:
# sos report -o ubuntu --upload # The important bit here is the --upload option, the rest is just to generate the sos archive.

The above command line output:
"
....

Attempting upload to Canonical Support File Server
Uploaded archive successfully
"

I also confirmed that the sos archive was present on the Canonical sftp under the right location as it should and as it was before this regression occurs.

- Eric

tags: added: verification-done-bionic
removed: verification-needed-bionic
Revision history for this message
Arif Ali (arif-ali) wrote :

[VERIFICATION HIRSUTE]

I ran the following command:
# sos report -o ubuntu --upload # The important bit here is the --upload option, the rest is just to generate the sos archive.

The above command line output:
"
....

Attempting upload to Canonical Support File Server
Uploaded archive successfully
"

I also confirmed that the sos archive was present on the Canonical sftp under the right location as it should and as it was before this regression occurs.

- Arif

tags: added: verification-done-hirsute
removed: verification-needed-hirsute
Revision history for this message
Eric Desrochers (slashd) wrote :

[VERIFICATION FOCAL]

I ran the following command:
# sos report -o ubuntu --upload # The important bit here is the --upload option, the rest is just to generate the sos archive.

The above command line output:
"
....

Attempting upload to Canonical Support File Server
Uploaded archive successfully
"

I also confirmed that the sos archive was present on the Canonical sftp under the right location as it should and as it was before this regression occurs.

- Eric

Revision history for this message
Eric Desrochers (slashd) wrote :

[VERIFICATION GROOVY]

I ran the following command:
# sos report -o ubuntu --upload # The important bit here is the --upload option, the rest is just to generate the sos archive.

The above command line output:
"
....

Attempting upload to Canonical Support File Server
Uploaded archive successfully
"

I also confirmed that the sos archive was present on the Canonical sftp under the right location as it should and as it was before this regression occurs.

- Eric

tags: added: verification-done-focal verification-done-groovy
removed: verification-needed-focal verification-needed-groovy
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for sosreport has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package sosreport - 4.1-1ubuntu0.20.10.2

---------------
sosreport (4.1-1ubuntu0.20.10.2) groovy; urgency=medium

  * d/p/0003-ubuntu-policy-fix-upload.patch:
    - Fix sos archive upload to UA Canonical server
      (LP: #1923209)

 -- Eric Desrochers <email address hidden> Thu, 13 May 2021 10:20:52 -0400

Changed in sosreport (Ubuntu Groovy):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package sosreport - 4.1-1ubuntu0.20.04.2

---------------
sosreport (4.1-1ubuntu0.20.04.2) focal; urgency=medium

  * d/p/0003-ubuntu-policy-fix-upload.patch:
    - Fix sos archive upload to UA Canonical server
      (LP: #1923209)

 -- Eric Desrochers <email address hidden> Thu, 13 May 2021 10:22:56 -0400

Changed in sosreport (Ubuntu Focal):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package sosreport - 4.1-1ubuntu0.18.04.2

---------------
sosreport (4.1-1ubuntu0.18.04.2) bionic; urgency=medium

  * d/p/0003-ubuntu-policy-fix-upload.patch:
    - Fix sos archive upload to UA Canonical server
      (LP: #1923209)

 -- Eric Desrochers <email address hidden> Thu, 13 May 2021 10:25:47 -0400

Changed in sosreport (Ubuntu Bionic):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package sosreport - 4.1-1ubuntu1.1

---------------
sosreport (4.1-1ubuntu1.1) hirsute; urgency=medium

  * d/p/0003-ubuntu-policy-fix-upload.patch:
    - Fix sos archive upload to UA Canonical server
      (LP: #1923209)

 -- Eric Desrochers <email address hidden> Thu, 13 May 2021 10:15:23 -0400

Changed in sosreport (Ubuntu Hirsute):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.