Mahara

Device detection error

Bug #1926380 reported by Kristina Hoeppner on 2021-04-28

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Mahara	Fix Released	High	Lisa Seeto	Mahara 21.04.0

Bug Description

There is an error with the device detection that we removed for 21.04.

Error message:

[WAR] cb (admin/site/options.php:990) Undefined index: userscandisabledevicedetection
Call stack (most recent first):

    log_message("Undefined index: userscandisabledevicedetection", 8, true, true, "/home/kristina/code/mahara/htdocs/admin/site/optio...", 990) at /home/kristina/code/mahara/htdocs/lib/errors.php:515
    error(8, "Undefined index: userscandisabledevicedetection", "/home/kristina/code/mahara/htdocs/admin/site/optio...", 990, array(size 7)) at /home/kristina/code/mahara/htdocs/admin/site/options.php:990
    siteoptions_submit(object(Pieform), array(size 101)) at /home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:572
    Pieform->__construct(array(size 9)) at /home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:168
    Pieform::process(array(size 9)) at /home/kristina/code/mahara/htdocs/lib/mahara.php:5589
    pieform(array(size 9)) at /home/kristina/code/mahara/htdocs/admin/site/options.php:854

====================

How to replicate:

1. Fresh database.
2. Log in as site admin.
3. Go to Admin menu -> Configure site -> Site options.
4. Change the theme to any of the available ones.
5. Save.

Results:
- Expected: The page saves without issues.
- Actual: Above error message

Lisa Seeto (lisaseeto) on 2021-04-28

Changed in mahara:
assignee:	nobody → Lisa Seeto (lisaseeto)
status:	Confirmed → In Progress

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2021-04-28: A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/11706

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2021-04-29: A change has been merged

Reviewed: https://reviews.mahara.org/11706
Committed: https://git.mahara.org/mahara/mahara/commit/96231bab6486067842f715ea109844c75d4f9a84
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 96231bab6486067842f715ea109844c75d4f9a84
Author: Lisa Seeto <email address hidden>
Date: Thu Apr 29 10:19:04 2021 +1200

Bug 1926380: Device detection error

- removed references to 'userscandisabledevicedetection'

Change-Id: I6bd4527c002209a8d21bea0f576b1f9de3048ab9
Signed-off-by: Lisa Seeto <email address hidden>

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2021-04-29: A patch has been submitted for review

Patch for "21.04_STABLE" branch: https://reviews.mahara.org/11716

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2021-04-29: A change has been merged

Reviewed: https://reviews.mahara.org/11716
Committed: https://git.mahara.org/mahara/mahara/commit/de72c456feb8bf9af437ce8f9c81d92cb3fe284e
Submitter: Robert Lyon (<email address hidden>)
Branch: 21.04_STABLE

commit de72c456feb8bf9af437ce8f9c81d92cb3fe284e
Author: Lisa Seeto <email address hidden>
Date: Thu Apr 29 10:19:04 2021 +1200

Bug 1926380: Device detection error

- removed references to 'userscandisabledevicedetection'

Change-Id: I6bd4527c002209a8d21bea0f576b1f9de3048ab9
Signed-off-by: Lisa Seeto <email address hidden>
(cherry picked from commit 96231bab6486067842f715ea109844c75d4f9a84)

Robert Lyon (robertl-9) on 2021-04-29