Mahara

Profile icon has a rectangular border around square icons

Bug #1926529 reported by Doris Tam
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Unassigned
Mahara 21.04.0

Bug Description

The profile icon displayed on comments has a grey border that isn't correctly displaying

Re-create the bug

1. Create a page
2. Go to the bottom of the page to see the comments are
3. Look at the profile icon displayed beside the comments

Expected: the profile icon is square and so is its border
Currently: the profile icon is square but the border is twice the length of it verically

Tags: styling
Revision history for this message
Doris Tam (doristam) wrote :
tags: added: styling
Revision history for this message
Robert Lyon (robertl-9) wrote :

This issue is due to the comment ratings turned on - we don't get the elongated box when they are off

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/11723

Revision history for this message
Robert Lyon (robertl-9) wrote :

To test,

Place a comment on a page when comment ratings is not turned on

Then turn on comment ratings

Place another comment on a page and give it a rating

Without patch
- strange border gap on comment icon

With patch
- no strange gap

Changed in mahara:
status: New → In Progress
milestone: none → 21.04.0
importance: Undecided → Medium
Revision history for this message
Robert Lyon (robertl-9) wrote :

To turn on comment ratings go to admin/extensions/pluginconfig.php?plugintype=artefact&pluginname=comment&type=comment

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11723
Committed: https://git.mahara.org/mahara/mahara/commit/ae10f316a0c30e40b26063a81587f1bc4c276318
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit ae10f316a0c30e40b26063a81587f1bc4c276318
Author: Robert Lyon <email address hidden>
Date: Thu Apr 29 14:47:54 2021 +1200

Bug 1926529: Place the comment usericon span in a div

So the span doesn't have the flex height

Change-Id: Icf591a59555b59f6f7d8f3d761daa579b3527909
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "21.04_STABLE" branch: https://reviews.mahara.org/11733

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11733
Committed: https://git.mahara.org/mahara/mahara/commit/79a0508c814b6925da5cdeb6b6fda51a8663fac1
Submitter: Robert Lyon (<email address hidden>)
Branch: 21.04_STABLE

commit 79a0508c814b6925da5cdeb6b6fda51a8663fac1
Author: Robert Lyon <email address hidden>
Date: Thu Apr 29 14:47:54 2021 +1200

Bug 1926529: Place the comment usericon span in a div

So the span doesn't have the flex height

Change-Id: Icf591a59555b59f6f7d8f3d761daa579b3527909
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit ae10f316a0c30e40b26063a81587f1bc4c276318)

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/11744

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.