Upgrade Gridstack to Gridstack 4.X

Bug #1928273 reported by Kristina Hoeppner
26
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Robert Lyon

Bug Description

Upgrade Gridstack to the latest version.

summary: - upgrade Gridstack to Gridstack 4.X
+ Upgrade Gridstack to Gridstack 4.X
Changed in mahara:
status: Confirmed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/11815

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/11900

Changed in mahara:
milestone: 21.10.0 → 22.04.0
assignee: Lisa Seeto (lisaseeto) → nobody
assignee: nobody → Robert Lyon (robertl-9)
Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "main" branch: https://reviews.mahara.org/12111

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "main" branch: https://reviews.mahara.org/12112

Revision history for this message
Dianne Tennent (dianne-t) wrote (last edit ):

Hi Bob,
The dotted lines that indicate the placement of the blocks in gridstack are wayyy too faint for my eyes (and therefore, probably others too), really hard to see. Could we pretty please darken them?

htdocs/theme/raw/sass/layout/_gridlayout.scss : line 53
htdocs/theme/raw/sass/lib/_gridstack.scss : line 35

ps here's the bug I reported, confirmed by Kristina:
https://bugs.launchpad.net/mahara/+bug/1952141

Cheers!

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/12111
Committed: https://git.mahara.org/mahara/mahara/commit/4c9cec56c0ed46523a6b01e403bb69ff131841fd
Submitter: Robert Lyon (<email address hidden>)
Branch: main

commit 4c9cec56c0ed46523a6b01e403bb69ff131841fd
Author: Lisa Seeto <email address hidden>
Date: Wed Jun 2 15:36:56 2021 +1200

Bug 1928273: Upgrade Gridstack to Gridstack 4.3.X

When calling grids we now assign the grid and grid element objects thus:

var grid = a gridstack object
var gridElement = a jquery .grid-stack selector object

Need to explicitly indicate the $() as jQuery() in filebrowser.js to
get things to work as expected for file upload in block config

Change-Id: I78a096f23397af42554a04f75d1bfceec1716173
Signed-off-by: Lisa Seeto <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review
Changed in mahara:
status: Fix Committed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/c/mahara/+/12611
Committed: https://git.mahara.org/mahara/mahara/commit/ebfa4aa6349f85c7afc6fa6280d0abe5a37637e2
Submitter: "Gold <email address hidden>"
Branch: main

commit ebfa4aa6349f85c7afc6fa6280d0abe5a37637e2
Author: Robert Lyon <email address hidden>
Date: Tue Apr 19 14:12:51 2022 +1200

Bug 1928273: make drag border correct colour

Change-Id: Ib6943b8abf947dba378dfae2c2576eb3b59bf367
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "22.04_DEV" branch: https://reviews.mahara.org/c/mahara/+/12644

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/c/mahara/+/12644
Committed: https://git.mahara.org/mahara/mahara/commit/8a38fa8fa040321ceb5b5100ce71c46285faf44b
Submitter: "Robert Lyon <email address hidden>"
Branch: 22.04_DEV

commit 8a38fa8fa040321ceb5b5100ce71c46285faf44b
Author: Robert Lyon <email address hidden>
Date: Tue Apr 19 14:12:51 2022 +1200

Bug 1928273: make drag border correct colour

Change-Id: Ib6943b8abf947dba378dfae2c2576eb3b59bf367
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit ebfa4aa6349f85c7afc6fa6280d0abe5a37637e2)

Changed in mahara:
status: In Progress → Fix Committed
Gold (gold.catalyst)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.