Mahara

Annotation block text entry blocks screen on mobile

Bug #1928611 reported by shane nuessler on 2021-05-16

This bug affects 1 person

	Status	Importance	Assigned to	Milestone
Mahara	Fix Released	High	Unassigned	Mahara 21.10.0
20.04	Fix Released	High	Unassigned	Mahara 20.04.4
20.10	Fix Released	High	Unassigned	Mahara 20.10.2
21.04	Fix Released	High	Unassigned	Mahara 21.04.1

Bug Description

Mahara 19.10 - 21.04

To reproduce

on mobile only

Create a page
add an annotation block, add some text, leave feedback/comments on
save/display page

affects android/ipad

see attached images of bug in action

Revision history for this message

shane nuessler (edunutter) wrote on 2021-05-16:

Photos (5).zip Edit (880.8 KiB, application/zip)

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2021-05-18: A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/11787

Revision history for this message

Robert Lyon (robertl-9) wrote on 2021-05-18:

Thank you for the bug report.

I was able to replicate and make a fix for this.

The issue can be seen with annotation block, the comment block, and in the peer assessment block when viewing the page with 'peer' role

Revision history for this message

shane nuessler (edunutter) wrote on 2021-05-18:

Thank you Robert, hope you're well.

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2021-05-18: A change has been merged

Reviewed: https://reviews.mahara.org/11787
Committed: https://git.mahara.org/mahara/mahara/commit/adc54bc23eabc1e83950ccf31452e57b9a9a0565
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit adc54bc23eabc1e83950ccf31452e57b9a9a0565
Author: Robert Lyon <email address hidden>
Date: Tue May 18 12:04:06 2021 +1200

Bug 1928611: Hide android/ios version of tinymce when modal closed

Change-Id: Ica0da1561756bae5572d86be39d58699a37fd503
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2021-05-18: A patch has been submitted for review

Patch for "21.04_STABLE" branch: https://reviews.mahara.org/11788

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2021-05-18:

Patch for "20.10_STABLE" branch: https://reviews.mahara.org/11789

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2021-05-18:

Patch for "20.04_STABLE" branch: https://reviews.mahara.org/11790

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2021-05-18: A change has been merged

Reviewed: https://reviews.mahara.org/11790
Committed: https://git.mahara.org/mahara/mahara/commit/b777242eb4e93f7182699a0da91bc276d2aa13be
Submitter: Robert Lyon (<email address hidden>)
Branch: 20.04_STABLE

commit b777242eb4e93f7182699a0da91bc276d2aa13be
Author: Robert Lyon <email address hidden>
Date: Tue May 18 12:04:06 2021 +1200

Bug 1928611: Hide android/ios version of tinymce when modal closed

Change-Id: Ica0da1561756bae5572d86be39d58699a37fd503
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit adc54bc23eabc1e83950ccf31452e57b9a9a0565)

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2021-05-18:

#10

Reviewed: https://reviews.mahara.org/11789
Committed: https://git.mahara.org/mahara/mahara/commit/1166d222bc1ddf1b48f4ccf3cc0a0dec7728adc2
Submitter: Robert Lyon (<email address hidden>)
Branch: 20.10_STABLE

commit 1166d222bc1ddf1b48f4ccf3cc0a0dec7728adc2
Author: Robert Lyon <email address hidden>
Date: Tue May 18 12:04:06 2021 +1200

Bug 1928611: Hide android/ios version of tinymce when modal closed

Change-Id: Ica0da1561756bae5572d86be39d58699a37fd503
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit adc54bc23eabc1e83950ccf31452e57b9a9a0565)

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2021-05-18:

#11

Reviewed: https://reviews.mahara.org/11788
Committed: https://git.mahara.org/mahara/mahara/commit/ffffd6da4b37991b7224e80542ec3fe4e8ad2101
Submitter: Robert Lyon (<email address hidden>)
Branch: 21.04_STABLE

commit ffffd6da4b37991b7224e80542ec3fe4e8ad2101
Author: Robert Lyon <email address hidden>
Date: Tue May 18 12:04:06 2021 +1200

Bug 1928611: Hide android/ios version of tinymce when modal closed

Change-Id: Ica0da1561756bae5572d86be39d58699a37fd503
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit adc54bc23eabc1e83950ccf31452e57b9a9a0565)

Kristina Hoeppner (kris-hoeppner) on 2021-10-28

no longer affects:

mahara/21.10