Ubuntu
fwts package

build fails due to relative paths in Makefile.am using automake before version 1.16.1

Bug #1929138 reported by Colin Ian King
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
fwts (Ubuntu)
Fix Released
High
Colin Ian King

Bug Description

Older versions of automake before version 1.16.1 can't handle $(srcdir) or $(top_srcdir) in the *_SOURCES symbols.

Turns out that using $(srcdir) or $(top_srcdir) in pre 1.16.1 automake is a bad idea for *_SOURCES as these can't be expanded and one ends up with directories being created with the unexanded names $(srcdir) and $(top_srcdir) being created.

A fix is to just hard-code relative paths instead for the *_SOURCES and use $(top_srcdir) for include paths and paths not used in *_SOURCES.

See also https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=752993

Colin Ian King (colin-king)
Changed in fwts (Ubuntu):
status: New → In Progress
importance: Undecided → High
assignee: nobody → Colin Ian King (colin-king)
Revision history for this message
Colin Ian King (colin-king) wrote :

Fix sent to fwts-devel for review: https://lists.ubuntu.com/archives/fwts-devel/2021-May/013077.html

Alex Hung (alexhung)
Changed in fwts (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Alex Hung (alexhung) wrote :

The patch is now included in repo

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package fwts - 21.06.00-0ubuntu1

---------------
fwts (21.06.00-0ubuntu1) impish; urgency=medium

  [Alex Hung]
  * fwts_test: arg-json-0001: use current klog.json, not a copy
  * lib: fwts_acpi_tables: constify read-only function arguments
  * fwts_framework: clean up flag macros
  * acpi: pptt: constify read-only function arguments
  * acpi: wdat: enable printing fields
  * fwts-test: sync up with wdat changes
  * acpi: wrap long funtion definitions
  * acpi/fwts-test: fix typo (depreciated->deprecated)
  * sbbr: add checks for mandatory tables
  * sbbr: update recommended tables
  * acpi: remove SBBR mandatory tests in various tables
  * acpi: sbbr: add mcfg and pptt to --sbbr option
  * live-image: remove unnecessary -skip-test=s3,s4 argument
  * live-image: create a separate menu for arm64/aarch64
  * dmicheck: add type 42 to SBBR requirement
  * klog.json: check IRQ requests on irqchip
  * tpmevlog: add to batch tests
  * live-image: add utils tests to "Selected" menu
  * live-image: add "TPM tests" to root menu
  * auto-packager: mkpackage.sh: remove xenial

  [Colin Ian King]
  * Makefile.am: remove all traces of $srcdir and $top_srcdir in Makefile.am
    (LP: #1929138)
  * ACPICA: Update to version 20210604
  * fwts-test: sync test logs with latest ACPICA
  * snapcraft.yaml: add architectures info to make remote snap builds easier
  * Debian: remove spaces at end of lines of changelong
  * Debian: remove spaces at end of lines of control file
  * debian/copyright: use secure https url specifier
  * Debian: add project Homepage field to control file
  * Debian: add Rules-Requires-Root field to control file
  * Debian: update compat level to 9
  * Debian: control: update Standards-Version to 4.1.0
  * Add lintian overrides for ldconfig trigger warning
  * Debian: move source lintian overrides file to source
  * Remove complex disabling of ACPI for non-ACPI targets
  * fwts_acpi_tables: memcpy 4 char ACPI table name

  [Ivan Hu]
  * uefirttime: set test time for the settime and setwakeuptime tests
    (LP: #1929509)

 -- Alex Hung <email address hidden> Sun, 20 Jun 2021 23:42:45 -0600

Changed in fwts (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.