[SRU] GDM background configurable with gsettings

Bug #1929536 reported by Jean-Baptiste Lallement
18
This bug affects 2 people
Affects Status Importance Assigned to Milestone
gnome-shell (Ubuntu)
Fix Released
Medium
Unassigned
Focal
Fix Released
Medium
Unassigned

Bug Description

[Description]
Customization of the greeter is a requirement from Corporate customers.

Currently the background (plain color or image) of the greeter is hard coded in the style embedded in the theme. Customizing this background requires to extract the style sheet from gnome-shell gresource file, modify it manually, recompile and deploy the new gresource, and add an alternative to it.

This feature adds 4 gsettings keys to make the background of the greeter configurable via gsettings. The default value defined the in the theme is used for keys that are not set.

[Test Case]
1. Boot a desktop session
2. Verify that the default aubergine background is displayed in the greeter.
3. Login as the administrator of the machine
4. Install systemd-container
5. Switch to the GDM user:
  $ sudo machinectl shell gdm@ /bin/bash
6. Apply a different background with the command:
  $ gsettings set com.ubuntu.login-screen background-picture-uri 'file:///usr/share/backgrounds/warty-final-ubuntu.png'
7. Logout
8. Verify that the image 'warty-final-ubuntu.png' is displayed as the background of the greeter.

[Risks / Impact]
The changeset is minimal, isolated (Only the code of the greeter is impacted by the change.) and can be easily reverted.
In case of error in the code, GDM will fail to load and it will be immediately visible.

[Build]
Builds and tested successfully locally.
Besides the updated JS is not compiled as part of build.

[Upstream Issue]
https://gitlab.gnome.org/GNOME/gdm/-/issues/684

Changed in gnome-shell (Ubuntu):
status: New → Fix Released
importance: Undecided → Medium
Changed in gnome-shell (Ubuntu Focal):
importance: Undecided → Medium
milestone: none → ubuntu-20.04.3
description: updated
description: updated
Revision history for this message
Brian Murray (brian-murray) wrote :

For the record this was fixed in Hirsute with a different bug number:

gnome-shell (3.38.3-3ubuntu2) hirsute; urgency=medium

  [ Didier Roche ]
  [ Jean-Baptiste Lallement ]
  * debian/patches/ubuntu/configure_login_screen.patch:
    Make GDM background configurable with gsettings (LP: #1918613)

 -- Didier Roche <email address hidden> Thu, 25 Mar 2021 10:44:17 +0100

Changed in gnome-shell (Ubuntu Focal):
status: New → Fix Committed
tags: added: verification-needed verification-needed-focal
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Jean-Baptiste, or anyone else affected,

Accepted gnome-shell into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-shell/3.36.9-0ubuntu0.20.04.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Revision history for this message
Jean-Baptiste Lallement (jibel) wrote :

verification

gnome-shell 3.36.9-0ubuntu0.20.04.2 has been tested successfully and can be configured via AD and GPOs. Without AD the behaviour is still the same.

marking as verification done

tags: added: verification-done verification-done-focal
removed: verification-needed verification-needed-focal
Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of the Stable Release Update for gnome-shell has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-shell - 3.36.9-0ubuntu0.20.04.2

---------------
gnome-shell (3.36.9-0ubuntu0.20.04.2) focal; urgency=medium

  [ Didier Roche ]
  [ Jean-Baptiste Lallement ]
  * debian/patches/ubuntu/configure_login_screen.patch:
    Make GDM background configurable with gsettings (LP: #1929536)

 -- Didier Roche <email address hidden> Wed, 19 May 2021 15:49:17 +0200

Changed in gnome-shell (Ubuntu Focal):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.