Ubuntu
golang-1.16 package

buildmode=c-shared not supported on linux/risc-v

Bug #1936664 reported by William Wilson on 2021-07-16

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	golang-1.16 (Ubuntu)	Fix Released	High	Heinrich Schuchardt
	golang-1.17 (Ubuntu)	Fix Released	Undecided	William Wilson

Bug Description

In order to build ubuntu-report and eventual desktop images for risc-v, golang needs to support buildmode=c-shared on linux/risc-v. We have submitted the change upstream, and will need to carry a delta until it lands in debian.

See https://github.com/golang/go/issues/47100 for upstream work.

Tags:

Revision history for this message

Heinrich Schuchardt (xypron) wrote on 2021-07-23:

Patches worked on in https://github.com/4a6f656c/go.git, branch riscv64-c-shared-go1.16.

Revision history for this message

Heinrich Schuchardt (xypron) wrote on 2021-07-26:

Update golang-1.16 is available in ppa:xypron/golang.

Revision history for this message

Heinrich Schuchardt (xypron) wrote on 2021-07-27:

Concerning upstreaming Joel Sing wrote:

"The changes have been mailed out, but are not yet landed (Go is currently in a release freeze).
https://github.com/golang/go/issues/47100 (https://go-review.googlesource.com/c/go/+/334872/1)
I would expect that they'll land and appear in the Go 1.18 cycle (February 2022 release)."

Mathew Hodson (mhodson) on 2021-08-13

Changed in golang-1.16 (Ubuntu):
importance:	Undecided → Wishlist

Revision history for this message

Heinrich Schuchardt (xypron) wrote on 2021-08-17:

@mhodson:
Why did you set this to importance wishlist? Other packages cannot be built due to this deficiency. E.g. gnome-initial-setup.

Heinrich Schuchardt (xypron) on 2021-09-08

tags:

added: fr-1686

Revision history for this message

Heinrich Schuchardt (xypron) wrote on 2021-09-10:

I am looking for a sponsor for golang-1.16 - 1.16.7-1ubuntu2 available in ppa:xypron/golang.

Revision history for this message

Heinrich Schuchardt (xypron) wrote on 2021-09-10:

golang-1.16 - 1.16.7-1ubuntu2 is available in ppa:xypron/golang. I am looking for a sponsor.

The new version provides building dynamic link libraries on RISC-V which is needed for packages like ubuntu reports.

Gunnar Hjalmarsson (gunnarhj) on 2021-09-10

Changed in golang-1.16 (Ubuntu):
status:	New → Fix Committed
importance:	Wishlist → High

Revision history for this message

Launchpad Janitor (janitor) wrote on 2021-09-10:

This bug was fixed in the package golang-1.16 - 1.16.7-1ubuntu2

---------------
golang-1.16 (1.16.7-1ubuntu2) impish; urgency=medium

  * Add support for c-archive and c-shared on RISC-V (LP: #1936664)
    - Apply patches from https://github.com/4a6f656c/go.git,
      branch riscv64-c-shared-go1.16:
      - d/patches/0001-runtime-cgo-save-and-restore-X3-aka-GP-for-crosscall.patch
      - d/patches/0002-runtime-save-and-restore-X3-aka-GP-for-asmcgocalls-o.patch
      - d/patches/0003-all-add-support-for-c-archive-and-c-shared-on-linux-.patch
      - d/patches/0004-runtime-change-riscv64-assembly-to-work-with-Go-1.16.patch

-- Heinrich Schuchardt <email address hidden> Tue, 07 Sep 2021 15:18:09 +0200

Changed in golang-1.16 (Ubuntu):
status:	Fix Committed → Fix Released

Heinrich Schuchardt (xypron) on 2021-09-10

Changed in golang-1.16 (Ubuntu):
assignee:	nobody → Heinrich Schuchardt (xypron)

William Wilson (jawn-smith) on 2021-09-16

Changed in golang-1.17 (Ubuntu):
status:	New → In Progress
assignee:	nobody → William Wilson (jawn-smith)

Revision history for this message

William Wilson (jawn-smith) wrote on 2021-09-17:

lp1936664.debdiff Edit (16.7 KiB, text/plain)

This patch adds the buildmode=c-shared functionality to Go 1.17. In addition to running sbuilds to ensure it built, I have also built the ubuntu-report sysmetrics shared library with it.

Revision history for this message

Launchpad Janitor (janitor) wrote on 2021-09-17:

This bug was fixed in the package golang-1.17 - 1.17-1ubuntu2

---------------
golang-1.17 (1.17-1ubuntu2) impish; urgency=medium