Mahara

Accordion across Mahara e.g. 'Site options' are not expandable by screen reader

Bug #1939076 reported by Doris Tam on 2021-08-06

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Mahara	Fix Released	Medium	Dianne Tennent	Mahara 21.10.0

Bug Description

These accordions are not able to be accessed using the keyboard.

Including but not limited to any pieforms that are of type 'fieldset' e.g. as seen on site/options.php

The accordion headers are internal links and cannot be accessed by the keyboard. They need to be buttons but once that change is made, the page refreshed upon every button press. Investigation needed.

https://www.w3.org/TR/wai-aria-practices-1.1/examples/accordion/accordion.html

See original description

Tags:

Doris Tam (doristam) on 2021-08-06

tags:	added: accessibi
tags:	added: accessibility removed: accessibi
description:	updated

Doris Tam (doristam) on 2021-08-08

description:	updated
description:	updated
tags:	removed: a11y

Kristina Hoeppner (kris-hoeppner) on 2021-08-10

Changed in mahara:
status:	New → Confirmed
importance:	Undecided → Medium
summary:	- Accordion across Mahara e.g. Site options are not expandable + Accordion across Mahara e.g. 'Site options' are not expandable by screen + reader

Revision history for this message

Kristina Hoeppner (kris-hoeppner) wrote on 2021-09-19:

The 'Enter' key does open retractable panels.

Please test whether the screen reader also recognises that, Dianne.

Thank you
Kristina

Changed in mahara:
status:	Confirmed → Invalid
status:	Invalid → Triaged
assignee:	nobody → Dianne Tennent (dianne-t)

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2021-09-20: A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/12014

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2021-09-20:

Patch for "master" branch: https://reviews.mahara.org/12015

Kristina Hoeppner (kris-hoeppner) on 2021-09-28

Changed in mahara:
status:	Triaged → In Progress
milestone:	none → 21.10.0

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2021-10-04:

Patch for "master" branch: https://reviews.mahara.org/12052

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2021-10-05: A change has been merged

Reviewed: https://reviews.mahara.org/12014
Committed: https://git.mahara.org/mahara/mahara/commit/de8b13cf65e2517380d66ccbcc00af51d0a4aadf
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit de8b13cf65e2517380d66ccbcc00af51d0a4aadf
Author: Dianne Tennent <email address hidden>
Date: Mon Sep 20 17:05:40 2021 +1200

Bug 1939076 Accordians with fieldset pieforms

Changed from links to buttons to make it
screen reader accessible

Change-Id: Ic2bc933a23d820aa7562dd36fe2df98ceb9f7bcd

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2021-10-05:

Reviewed: https://reviews.mahara.org/12015
Committed: https://git.mahara.org/mahara/mahara/commit/4900cd07bfac2865b950c8cd163d9e2f92443f95
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 4900cd07bfac2865b950c8cd163d9e2f92443f95
Author: Evonne <email address hidden>
Date: Tue Sep 21 10:48:38 2021 +1200

Bug 1939076 fixing styling to collapsible legend buttons

behatnotneeded

Change-Id: Id73e475ff3510c057fbfafcae83580ed46b2b6bc

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2021-10-05: A patch has been submitted for review

Patch for "21.10_DEV" branch: https://reviews.mahara.org/12056

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2021-10-05:

Patch for "21.10_DEV" branch: https://reviews.mahara.org/12057

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2021-10-05: A change has been merged

Reviewed: https://reviews.mahara.org/12057
Committed: https://git.mahara.org/mahara/mahara/commit/cdc24b1988f5666d20b22f7c01ef3cf403899e21
Submitter: Robert Lyon (<email address hidden>)
Branch: 21.10_DEV

commit cdc24b1988f5666d20b22f7c01ef3cf403899e21
Author: Evonne <email address hidden>
Date: Tue Sep 21 10:48:38 2021 +1200

Bug 1939076 fixing styling to collapsible legend buttons

behatnotneeded

Change-Id: Id73e475ff3510c057fbfafcae83580ed46b2b6bc
(cherry picked from commit 4900cd07bfac2865b950c8cd163d9e2f92443f95)

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2021-10-05:

#10

Reviewed: https://reviews.mahara.org/12056
Committed: https://git.mahara.org/mahara/mahara/commit/3556c4386310dccdaac3758cc9ee2605630a7c80
Submitter: Robert Lyon (<email address hidden>)
Branch: 21.10_DEV

commit 3556c4386310dccdaac3758cc9ee2605630a7c80
Author: Dianne Tennent <email address hidden>
Date: Mon Sep 20 17:05:40 2021 +1200

Bug 1939076 Accordians with fieldset pieforms

Changed from links to buttons to make it
screen reader accessible

Change-Id: Ic2bc933a23d820aa7562dd36fe2df98ceb9f7bcd
(cherry picked from commit de8b13cf65e2517380d66ccbcc00af51d0a4aadf)

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2021-10-06: A patch has been submitted for review

#11

Patch for "master" branch: https://reviews.mahara.org/12059

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2021-10-11:

#13

Reviewed: https://reviews.mahara.org/12059
Committed: https://git.mahara.org/mahara/mahara/commit/efba80fc080b3e12194c0467b4947a6893351037
Submitter: Gold (<email address hidden>)
Branch: master

commit efba80fc080b3e12194c0467b4947a6893351037
Author: Evonne <email address hidden>
Date: Wed Oct 6 14:09:39 2021 +1300

Bug 1939076: fixing styling for link-expand-right buttons

Visually aligning the styling to btn-secondary rather than collapsible
fieldset.

behatnotneeded

Change-Id: Idc0622b7f6f8557295ec442bbe335e631717bd7e

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2021-10-11: A change has been merged

#12

Reviewed: https://reviews.mahara.org/12052
Committed: https://git.mahara.org/mahara/mahara/commit/1edc49e9494b2fb9a5a54f57a8625ba7c6ad4e91
Submitter: Gold (<email address hidden>)
Branch: master

commit 1edc49e9494b2fb9a5a54f57a8625ba7c6ad4e91
Author: Robert Lyon <email address hidden>
Date: Mon Oct 4 13:00:30 2021 +1300

Bug 1939076: fixing styling for link-expand-right buttons

As seen in view access edit page and admin -> people search page

where the chevron was not aligned with the text

Change-Id: I290e11c7c4f64429dffc37feeeeb5d65d2133ffc
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2021-10-13: A patch has been submitted for review

#14

Patch for "21.10_DEV" branch: https://reviews.mahara.org/12068

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2021-10-13:

#15

Patch for "21.10_DEV" branch: https://reviews.mahara.org/12069

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2021-10-13: A change has been merged

#16

Reviewed: https://reviews.mahara.org/12069
Committed: https://git.mahara.org/mahara/mahara/commit/ede3e59b0a9b9625fde870677cc65db33b4b117a
Submitter: Robert Lyon (<email address hidden>)
Branch: 21.10_DEV

commit ede3e59b0a9b9625fde870677cc65db33b4b117a
Author: Evonne <email address hidden>
Date: Wed Oct 6 14:09:39 2021 +1300

Bug 1939076: fixing styling for link-expand-right buttons

Visually aligning the styling to btn-secondary rather than collapsible
fieldset.

behatnotneeded

Change-Id: Idc0622b7f6f8557295ec442bbe335e631717bd7e
(cherry picked from commit efba80fc080b3e12194c0467b4947a6893351037)

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2021-10-13:

#17

Reviewed: https://reviews.mahara.org/12068
Committed: https://git.mahara.org/mahara/mahara/commit/7823a5839d206e8a719c407736c016a094b326f2
Submitter: Robert Lyon (<email address hidden>)
Branch: 21.10_DEV

commit 7823a5839d206e8a719c407736c016a094b326f2
Author: Robert Lyon <email address hidden>
Date: Mon Oct 4 13:00:30 2021 +1300

Bug 1939076: fixing styling for link-expand-right buttons

As seen in view access edit page and admin -> people search page

where the chevron was not aligned with the text

Change-Id: I290e11c7c4f64429dffc37feeeeb5d65d2133ffc
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 1edc49e9494b2fb9a5a54f57a8625ba7c6ad4e91)

Kristina Hoeppner (kris-hoeppner) on 2021-10-18