please enable libssh support

Bug #1939416 reported by Christian Ehrhardt 
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
libvirt (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

That was a request in IRC today as it seems there are a few suboptions that qemu+ssh can not provide but qemu+libssh can.

See https://libvirt.org/uri.html for some details.

In the past it was libssh only and that was not in main also causing trouble for others, see bug 681423

But nowadays libvirt can do both.
So as we did in qemu we could switch to libssh (1) and since that is in main have it working helping users that need that feature.

We currently have
commit 6ef5c50d74b89e766ad3bf09e7ccc948a59b57d3
Author: Christian Ehrhardt <email address hidden>
Date: Wed Dec 14 12:42:32 2016 +0100

    disable libssh2 support (universe dependency)

    Signed-off-by: Christian Ehrhardt <email address hidden>

diff --git a/debian/control b/debian/control
index d32f839681..9ff27dfc6f 100644
--- a/debian/control
+++ b/debian/control
@@ -38,7 +38,6 @@ Build-Depends:
  libsanlock-dev [linux-any],
  libsasl2-dev,
  libselinux1-dev (>= 2.0.82) [linux-any],
- libssh2-1-dev,
  libudev-dev [linux-any],
  libwireshark-dev (>= 1.11.3),
  libwiretap-dev,
diff --git a/debian/rules b/debian/rules
index 0a799973d6..93b56f738f 100755
--- a/debian/rules
+++ b/debian/rules
@@ -104,7 +104,7 @@ DEB_CONFIGURE_EXTRA_ARGS := \
     $(WITH_OPENVZ) \
     -Dsasl=enabled \
     -Dyajl=enabled \
- -Dlibssh2=enabled \
+ -Dlibssh2=disabled \
     $(WITH_POLKIT) \
     $(WITH_SANLOCK) \
     $(WITH_UDEV) \

But since we can now use libssh (1) being in main
 libssh | 0.9.3-2ubuntu2 | focal | source
 libssh | 0.9.3-2ubuntu2.1 | focal-security | source
 libssh | 0.9.3-2ubuntu2.1 | focal-updates | source
 libssh | 0.9.5-1 | hirsute | source
 libssh | 0.9.5-1 | impish | source

That can nowadays be converted and instead become something like:

index 7c7a85b0a8..97b1e02c67 100644
--- a/debian/control
+++ b/debian/control
@@ -38,6 +38,7 @@ Build-Depends:
  libsanlock-dev [linux-any],
  libsasl2-dev,
  libselinux1-dev (>= 2.0.82) [linux-any],
+ libssh-1-dev (>= 0.7),
  libtirpc-dev,
  libudev-dev [linux-any],
  libwireshark-dev (>= 1.11.3),
diff --git a/debian/rules b/debian/rules
index 724baaee19..f0f07e7ca3 100755
--- a/debian/rules
+++ b/debian/rules
@@ -105,6 +105,7 @@ DEB_CONFIGURE_EXTRA_ARGS := \
     -Dsasl=enabled \
     -Dyajl=enabled \
     -Dlibssh2=disabled \
+ -Dlibssh=enabled \
     $(WITH_POLKIT) \
     $(WITH_SANLOCK) \
     $(WITH_UDEV)

If that builds fine it can be tested via
  virsh -c qemu+libssh://ubuntu@horsea/system list

Related branches

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Enabling libssh (1) also benefits Debian, so I have submitted
  https://salsa.debian.org/libvirt-team/libvirt/-/merge_requests/110

Changed in libvirt (Ubuntu):
status: New → In Progress
Changed in libvirt (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package libvirt - 7.6.0-0ubuntu1

---------------
libvirt (7.6.0-0ubuntu1) impish; urgency=medium

  * Merge v7.6.0 from upstream and unreleased changes from Debian git.
    Among other bugs this fixes copy-storage-inc based migrations (LP: #1936778)
    - New upstream version 7.5.0
    - New upstream version 7.6.0
    - symbols: Bump symbol versions
    - refresh d/p/debian/Set-defaults-for-zfs-tools.patch for v7.5.0
    - patches: Refresh patches
    - d/rules: disable the new Cloud Hypervisor driver
    - d/rules: enable more features explicitly
    - d/rules: use apparmor_profiles=enabled instead of the now rejected
      value true
    - update d/p/debian/Revert-m4-virt-xdr-rewrite-XDR-check.patch: to detect
      XDR functions from glibc
  * d/control, d/rules: enable libssh (LP: #1939416)
  * refresh ubuntu patches for v7.6.0
  * Further fixups for v7.6.0 (thanks to Andrea Bolognani)
    - rules: Explicitly set remote_default_mode
    - rules: Rework installation of AppArmor-related files

 -- Christian Ehrhardt <email address hidden> Wed, 11 Aug 2021 08:11:16 +0200

Changed in libvirt (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.