Comment notification doesn't take you to the comment

Bug #1940798 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Doris Tam

Bug Description

The comment notification email does not take you to the page comment itself any more but are left at the top of the page. The comment has to be searched for on the page if it is a page comment or the artefact found, which can be tricky when there are lots of artefacts on a page.

The URL is something like view/view.php?id=27&showcomment=180 and /view/view.php?id=27&artefact=163&showcomment=181 for a comment on an artefact, but you don't jump to the comment.

To replicate:

1. PersonA creates a page and includes an image that allows comments.
2. PersonA shares the page with PersonB and allows comments.
3. Log in as PersonB and leave a public comment on the page and on the artefact.
4. Log in as PersonA.
5. PersonA received a notification with a link to the page comment and a notification with the link to the artefact comment.

Expected result: Clicking the link in the email that is to take you to the comment takes you to the comment. In the case of the artefact comment that should open the modal. In case of the page comment, the comment should be seen at the top of the page or somehow highlighted temporarily.

Actual result: The link only takes you to the page but not the comment or the comment on the artefact.

There is bug #1940800 that deals with moderated comments.

This issue doesn't deal with the wishlist item bug #1945248 to highlight the comment.

Tags: usability
description: updated
description: updated
tags: added: usability
Doris Tam (doristam)
Changed in mahara:
assignee: nobody → Doris Tam (doristam)
status: Confirmed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/12029

Changed in mahara:
milestone: 22.04.0 → 21.10.0
Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "main" branch: https://reviews.mahara.org/12137

description: updated
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/12137
Committed: https://git.mahara.org/mahara/mahara/commit/e73fef68688624a18bfb3d58a4e0cd730a30e411
Submitter: Robert Lyon (<email address hidden>)
Branch: main

commit e73fef68688624a18bfb3d58a4e0cd730a30e411
Author: Doris Tam <email address hidden>
Date: Thu Sep 23 14:18:41 2021 +1200

Bug 1940798: Scroll to 'showcomment' param in URL

If the 'showcomment' parameter exists in the URL,
scroll to where comment with that ID sits on the page.

This includes page comments and artefact comments.
Block comments have not been considered.
Change-Id: Iac3fe5beab59afb11e465fba13797320acff9dc2

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "21.10_DEV" branch: https://reviews.mahara.org/12178

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/12178
Committed: https://git.mahara.org/mahara/mahara/commit/4093a5af00daccb800ec786d4ff9e9db5289bf18
Submitter: Robert Lyon (<email address hidden>)
Branch: 21.10_DEV

commit 4093a5af00daccb800ec786d4ff9e9db5289bf18
Author: Doris Tam <email address hidden>
Date: Thu Sep 23 14:18:41 2021 +1200

Bug 1940798: Scroll to 'showcomment' param in URL

If the 'showcomment' parameter exists in the URL,
scroll to where comment with that ID sits on the page.

This includes page comments and artefact comments.
Block comments have not been considered.
Change-Id: Iac3fe5beab59afb11e465fba13797320acff9dc2
(cherry picked from commit e73fef68688624a18bfb3d58a4e0cd730a30e411)

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.