Ubuntu
monitoring-plugins package

Incorrectly excludes tmpfs filesystems

Bug #1940916 reported by Jonathan Wiltshire
38
This bug affects 3 people
Affects Status Importance Assigned to Milestone
monitoring-plugins (Ubuntu)
Fix Released
Medium
Miriam España Acebal
Bionic
Fix Released
Medium
Hua Zhang
Focal
Fix Released
Medium
Miriam España Acebal
Impish
Fix Released
Medium
Miriam España Acebal
Jammy
Fix Released
Medium
Miriam España Acebal

Bug Description

[SRU]

[Impact]

False positive reports are generated in monitoring tools when artificial file systems are mounted, as they show 100% disk utilisation, and therefore add an unnecessary (but fatal sounding) "CRITICAL DISK" noise. But, if we exclude them by default as we did in the first place in bug 1827159, we limit the use of command options that are commonly used in scripts and that, because of this exclusion, cannot operate on this kind of filesystems (e.g. the path option or the include filesystem option -as excluding has preference over including).

[Test Plan]

0.Preparing the test environment:

#Preparing the container
lxc launch images:ubuntu/focal checkdisks-focal
lxc shell checkdisks-focal
apt update -y
apt upgrade -y

#Installing necessary tools
apt install monitoring-plugins
apt install snapd

#Mount some synthetic systems and make use of snap space
mkdir /reproduce-tmpfs
mkdir /reproduce-squashfs
mkdir /reproduce-tracefs
mount -t tmpfs -o rw,size=2G tmpfs /reproduce-tmpfs
mount -t tmpfs -o rw,size=2G squashfs /reproduce-squashfs
mount -t tmpfs -o rw,size=2G tracefs /reproduce-tracefs
snap install gnome-calculator

1. Bad cases:

# "CRITICAL DISK" noise

$ /usr/lib/nagios/plugins/check_disk -w 10 -c 10
DISK CRITICAL - free space: /dev 448 MB (100% inode=99%); /run 96 MB (98% inode=99%); / 884 MB (18% inode=80%); /dev/shm 485 MB (100% inode=99%); /run/lock 5 MB (100% inode=99%); /snap/lxd/21835 0 MB (0% inode=0%); /snap/core20/1270 0 MB (0% inode=0%); /snap/snapd/14295 0 MB (0% inode=0%); /boot/efi 99 MB (95% inode=-); /run/snapd/ns 96 MB (98% inode=99%); /snap/snapd/14549 0 MB (0% inode=0%); /run/user/1000 97 MB (99% inode=99%); /snap/bare/5 0 MB (0% inode=0%); /snap/multipass-sshfs/145 0 MB (0% inode=0%); /home/ubuntu/monitoring-plugins 1024000 MB (100% inode=100%); /home/ubuntu/reproduce 2048 MB (100% inode=99%); /home/ubuntu/reproduce-squash 2048 MB (100% inode=99%); /snap/core20/1328 0 MB (0% inode=0%); /home/ubuntu/reproduce-tracefs 2048 MB (100% inode=99%);| /dev=0MB;438;438;0;448 /run=0MB;87;87;0;97 /=3886MB;4777;4777;0;4787 /dev/shm=0MB;475;475;0;485 /run/lock=0MB;-5;-5;0;5 /snap/lxd/21835=67MB;57;57;0;67 /snap/core20/1270=62MB;52;52;0;62 /snap/snapd/14295=43MB;33;33;0;43 /boot/efi=5MB;94;94;0;104 /run/snapd/ns=0MB;87;87;0;97 /snap/snapd/14549=43MB;33;33;0;43 /run/user/1000=0MB;87;87;0;97 /snap/bare/5=0MB;-10;-10;0;0 /snap/multipass-sshfs/145=1MB;-9;-9;0;1 /home/ubuntu/monitoring-plugins=0MB;1023990;1023990;0;1024000 /home/ubuntu/reproduce=0MB;2038;2038;0;2048 /home/ubuntu/reproduce-squash=0MB;2038;2038;0;2048 /snap/core20/1328=62MB;52;52;0;62 /home/ubuntu/reproduce-tracefs=0MB;2038;2038;0;2048

$ /usr/lib/nagios/plugins/check_disk -w 10 -c 10 -e -X squashfs
DISK CRITICAL - free space: /run/lock 5 MB (100% inode=99%);| /dev=0MB;438;438;0;448 /run=0MB;87;87;0;97 /=3886MB;4777;4777;0;4787 /dev/shm=0MB;475;475;0;485 /run/lock=0MB;-5;-5;0;5 /boot/efi=5MB;94;94;0;104 /run/snapd/ns=0MB;87;87;0;97 /run/user/1000=0MB;87;87;0;97 /home/ubuntu/monitoring-plugins=0MB;1023990;1023990;0;1024000 /home/ubuntu/reproduce=0MB;2038;2038;0;2048 /home/ubuntu/reproduce-squash=0MB;2038;2038;0;2048 /home/ubuntu/reproduce-tracefs=0MB;2038;2038;0;2048

$ /usr/lib/nagios/plugins/check_disk -w 10 -c 10 -e -X tracefs
DISK CRITICAL - free space: /run/lock 5 MB (100% inode=99%); /snap/lxd/21835 0 MB (0% inode=0%); /snap/core20/1270 0 MB (0% inode=0%); /snap/snapd/14295 0 MB (0% inode=0%); /snap/snapd/14549 0 MB (0% inode=0%); /snap/bare/5 0 MB (0% inode=0%); /snap/multipass-sshfs/145 0 MB (0% inode=0%); /snap/core20/1328 0 MB (0% inode=0%);| /dev=0MB;438;438;0;448 /run=0MB;87;87;0;97 /=3886MB;4777;4777;0;4787 /dev/shm=0MB;475;475;0;485 /run/lock=0MB;-5;-5;0;5 /snap/lxd/21835=67MB;57;57;0;67 /snap/core20/1270=62MB;52;52;0;62 /snap/snapd/14295=43MB;33;33;0;43 /boot/efi=5MB;94;94;0;104 /run/snapd/ns=0MB;87;87;0;97 /snap/snapd/14549=43MB;33;33;0;43 /run/user/1000=0MB;87;87;0;97 /snap/bare/5=0MB;-10;-10;0;0 /snap/multipass-sshfs/145=1MB;-9;-9;0;1 /home/ubuntu/monitoring-plugins=0MB;1023990;1023990;0;1024000 /home/ubuntu/reproduce=0MB;2038;2038;0;2048 /home/ubuntu/reproduce-squash=0MB;2038;2038;0;2048 /snap/core20/1328=62MB;52;52;0;62 /home/ubuntu/reproduce-tracefs=0MB;2038;2038;0;2048

$ /usr/lib/nagios/plugins/check_disk -w 10 -c 10 -e -X tracefs -X squashfs
DISK CRITICAL - free space: /run/lock 5 MB (100% inode=99%);| /dev=0MB;438;438;0;448 /run=0MB;87;87;0;97 /=3886MB;4777;4777;0;4787 /dev/shm=0MB;475;475;0;485 /run/lock=0MB;-5;-5;0;5 /boot/efi=5MB;94;94;0;104 /run/snapd/ns=0MB;87;87;0;97 /run/user/1000=0MB;87;87;0;97 /home/ubuntu/monitoring-plugins=0MB;1023990;1023990;0;1024000 /home/ubuntu/reproduce=0MB;2038;2038;0;2048 /home/ubuntu/reproduce-squash=0MB;2038;2038;0;2048 /home/ubuntu/reproduce-tracefs=0MB;2038;2038;0;2048

$ /usr/lib/nagios/plugins/check_disk -w 10 -c 10 -e -X tmpfs
DISK CRITICAL - free space: /snap/lxd/21835 0 MB (0% inode=0%); /snap/core20/1270 0 MB (0% inode=0%); /snap/snapd/14295 0 MB (0% inode=0%); /snap/snapd/14549 0 MB (0% inode=0%); /snap/bare/5 0 MB (0% inode=0%); /snap/multipass-sshfs/145 0 MB (0% inode=0%); /snap/core20/1328 0 MB (0% inode=0%);| /dev=0MB;438;438;0;448 /=3886MB;4777;4777;0;4787 /snap/lxd/21835=67MB;57;57;0;67 /snap/core20/1270=62MB;52;52;0;62 /snap/snapd/14295=43MB;33;33;0;43 /boot/efi=5MB;94;94;0;104 /snap/snapd/14549=43MB;33;33;0;43 /snap/bare/5=0MB;-10;-10;0;0 /snap/multipass-sshfs/145=1MB;-9;-9;0;1 /home/ubuntu/monitoring-plugins=0MB;1023990;1023990;0;1024000 /snap/core20/1328=62MB;52;52;0;62

# "DISK UNKNOWN" as synthetic filesystems are excluded

$ /usr/lib/nagios/plugins/check_disk -w 10% -c 5% -p /reproduce-tmpfs
DISK UNKNOWN - free space:|

$ /usr/lib/nagios/plugins/check_disk -w 10% -c 5% -N tmpfs
DISK UNKNOWN - free space:|

$ /usr/lib/nagios/plugins/check_disk -w 10% -c 5% -X squashfs -N tmpfs
DISK UNKNOWN - free space:|

2. Good cases:

# "CRITICAL DISK" noise

$ /usr/lib/nagios/plugins/check_disk -w 10 -c 10
DISK OK - free space: / 6971 MB (85% inode=99%); /dev/fuse 32071 MB (100% inode=99%); /dev/net/tun 32071 MB (100% inode=99%); /dev/full 32071 MB (100% inode=99%); /dev/null 32071 MB (100% inode=99%); /dev/random 32071 MB (100% inode=99%); /dev/tty 32071 MB (100% inode=99%); /dev/urandom 32071 MB (100% inode=99%); /dev/zero 32071 MB (100% inode=99%); /snap 6971 MB (85% inode=99%);| /=1204MB;8165;8165;0;8175 /dev/fuse=0MB;32061;32061;0;32071 /dev/net/tun=0MB;32061;32061;0;32071 /dev/full=0MB;32061;32061;0;32071 /dev/null=0MB;32061;32061;0;32071 /dev/random=0MB;32061;32061;0;32071 /dev/tty=0MB;32061;32061;0;32071 /dev/urandom=0MB;32061;32061;0;32071 /dev/zero=0MB;32061;32061;0;32071 /snap=1204MB;8165;8165;0;8175

# "DISK UNKNOWN" as synthetic filesystems are excluded

$ /usr/lib/nagios/plugins/check_disk -w 10% -c 5% -p /reproduce-tmpfs
DISK OK - free space: /reproduce-tmpfs 2048 MB (100% inode=99%);| /reproduce-tmpfs=0MB;1843;1945;0;2048

$ /usr/lib/nagios/plugins/check_disk -w 10% -c 5% -N tmpfs
DISK OK - free space: /dev 0 MB (99% inode=99%); /dev/lxd 0 MB (100% inode=99%); /dev/.lxd-mounts 0 MB (100% inode=99%); /proc/sys/kernel/random/boot_id 0 MB (99% inode=99%); /dev/shm 32106 MB (100% inode=99%); /run 6421 MB (99% inode=99%); /run/lock 5 MB (100% inode=99%); /sys/fs/cgroup 32106 MB (100% inode=99%); /run/user/0 6421 MB (100% inode=99%); /run/snapd/ns 6421 MB (99% inode=99%); /reproduce-tmpfs 2048 MB (100% inode=99%); /reproduce-squashfs 2048 MB (100% inode=99%); /reproduce-tracefs 2048 MB (100% inode=99%);| /dev=0MB;0;0;0;0 /dev/lxd=0MB;0;0;0;0 /dev/.lxd-mounts=0MB;0;0;0;0 /proc/sys/kernel/random/boot_id=0MB;0;0;0;0 /dev/shm=0MB;28895;30500;0;32106 /run=0MB;5778;6099;0;6421 /run/lock=0MB;4;4;0;5 /sys/fs/cgroup=0MB;28895;30500;0;32106 /run/user/0=0MB;5778;6099;0;6421 /run/snapd/ns=0MB;5778;6099;0;6421 /reproduce-tmpfs=0MB;1843;1945;0;2048 /reproduce-squashfs=0MB;1843;1945;0;2048 /reproduce-tracefs=0MB;1843;1945;0;2048

$ /usr/lib/nagios/plugins/check_disk -w 10% -c 5% -N tmpfs -p /reproduce-tmpfs
DISK OK - free space: /reproduce-tmpfs 2048 MB (100% inode=99%);| /reproduce-tmpfs=0MB;1843;1945;0;2048

//This case is fine, as I am explicitly asking for an fs that is being explicitly excluded too.
$ /usr/lib/nagios/plugins/check_disk -w 10% -c 5% -X tmpfs -p /reproduce-tmpfs
DISK UNKNOWN - free space:|

$ /usr/lib/nagios/plugins/check_disk -w 10% -c 5% -X squashfs -p /reproduce-tmpfs
DISK OK - free space: /reproduce-tmpfs 2048 MB (100% inode=99%);| /reproduce-tmpfs=0MB;1843;1945;0;2048

$ /usr/lib/nagios/plugins/check_disk -w 10% -c 5% -X squashfs -N tmpfs
DISK OK - free space: /dev 0 MB (99% inode=99%); /dev/lxd 0 MB (100% inode=99%); /dev/.lxd-mounts 0 MB (100% inode=99%); /proc/sys/kernel/random/boot_id 0 MB (99% inode=99%); /dev/shm 32106 MB (100% inode=99%); /run 6421 MB (99% inode=99%); /run/lock 5 MB (100% inode=99%); /sys/fs/cgroup 32106 MB (100% inode=99%); /run/user/0 6421 MB (100% inode=99%); /run/snapd/ns 6421 MB (99% inode=99%); /reproduce-tmpfs 2048 MB (100% inode=99%); /reproduce-squashfs 2048 MB (100% inode=99%); /reproduce-tracefs 2048 MB (100% inode=99%);| /dev=0MB;0;0;0;0 /dev/lxd=0MB;0;0;0;0 /dev/.lxd-mounts=0MB;0;0;0;0 /proc/sys/kernel/random/boot_id=0MB;0;0;0;0 /dev/shm=0MB;28895;30500;0;32106 /run=0MB;5778;6099;0;6421 /run/lock=0MB;4;4;0;5 /sys/fs/cgroup=0MB;28895;30500;0;32106 /run/user/0=0MB;5778;6099;0;6421 /run/snapd/ns=0MB;5778;6099;0;6421 /reproduce-tmpfs=0MB;1843;1945;0;2048 /reproduce-squashfs=0MB;1843;1945;0;2048 /reproduce-tracefs=0MB;1843;1945;0;2048

[Where problems could occur]

As this alters the logic of how out-of-space checks are handled, relevant issues to keep an eye out for would relate to filesystem checks reporting improperly. These tools underlay a few different front-ends, so regression bugs may get filed in a few different places, however they will tend to display error messages involving check_disk, nagios, and either tmpfs or tracefs. To minimize it, this changes has been done after all the arguments logic has been done (thanks Richard Laager), therefore excluding filesystems only if not required explicitly by the user (thanks Christian Ehrhardt).

Note that there are likely other synthetic filesystems beyond tmpfs, squashfs and tracefs (e.g. udev, usbfs, devtmpfs, fuse.*, ...) which might also cause similar false positives; these should be handled as separate bugs, although the proposed code here has the intention to be easily used to it.

[Other Info]

The intention is to forward the patch to upstream once is accepted here, as the previous one (https://github.com/monitoring-plugins/monitoring-plugins/pull/1609 and https://github.com/monitoring-plugins/monitoring-plugins/issues/1608) was rejected. Update: Issue created to upstream at https://github.com/monitoring-plugins/monitoring-plugins/issues/1748 with PR at https://github.com/monitoring-plugins/monitoring-plugins/pull/1749 .

[Original Report]
-------------------------------------------------------------------
$ lsb_release -d
Description: Ubuntu 20.04.3 LTS

$ apt-cache policy monitoring-plugins | head -n2
monitoring-plugins:
  Installed: 2.2-6ubuntu1.1

check_disk returns UNKNOWN for tmpfs filesystems, even when directed explicitly to check them. This is a regression introduced by the fix for LP: #1827159.

Steps to reproduce:

$ df -h /tmp
Filesystem Size Used Avail Use% Mounted on
tmpfs 16G 64K 16G 1% /tmp
$ /usr/lib/nagios/plugins/check_disk -w 10% -c 5% -p /tmp
DISK UNKNOWN - free space:|

Running the check as part of a group, even with just the one member, is a workaround:

$ /usr/lib/nagios/plugins/check_disk -w 10% -c 5% -g tmp -p /tmp
DISK OK - free space: tmp 16058 MB (99% inode=99%);| tmp=0MB;14452;15255;0;16058

See original description

Related branches

~mirespace/ubuntu/+source/monitoring-plugins:1940916-1827159-jammy-synthetics-fs
Bryce Harrington (community): Approve
Canonical Server: Pending requested
Diff: 89 lines (+47/-13)
2 files modified
debian/changelog (+9/-0)
debian/patches/exclude-tmpfs-squashfs-tracefs.patch (+38/-13)
~mirespace/ubuntu/+source/monitoring-plugins:1940916-1827159-impish-synthetics-fs
Bryce Harrington (community): Approve
Canonical Server: Pending requested
Canonical Server MOTU reviewers: Pending requested
Diff: 89 lines (+47/-13)
2 files modified
debian/changelog (+9/-0)
debian/patches/exclude-tmpfs-squashfs-tracefs.patch (+38/-13)
~mirespace/ubuntu/+source/monitoring-plugins:1940916-1827159-focal-synthetics-fs
Utkarsh Gupta (community): Needs Information
Bryce Harrington (community): Approve
Diff: 89 lines (+47/-13)
2 files modified
debian/changelog (+9/-0)
debian/patches/exclude-tmpfs-squashfs-tracefs.patch (+38/-13)
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in monitoring-plugins (Ubuntu):
status: New → Confirmed
Jonathan Wiltshire (tiger-jmw)
description: updated
Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote :

Thanks for reporting this issue.

I could reproduce the issue in fresh lxc containers in focal and in impish, although it is indeed not present in bionic:

apt update
apt install -y monitoring-plugins
mkdir /reproduce
mount -t tmpfs -o rw,size=2G tmpfs /reproduce
/usr/lib/nagios/plugins/check_disk -w 10% -c 5% -p /reproduce
DISK UNKNOWN - free space:|

Changed in monitoring-plugins (Ubuntu):
status: Confirmed → Triaged
Bryce Harrington (bryce)
tags: added: server-todo
Changed in monitoring-plugins (Ubuntu):
importance: Undecided → Medium
Christian Ehrhardt  (paelzer)
Changed in monitoring-plugins (Ubuntu):
assignee: nobody → Miriam España Acebal (mirespace)
Miriam España Acebal (mirespace)
Changed in monitoring-plugins (Ubuntu):
status: Triaged → In Progress
Revision history for this message
Miriam España Acebal (mirespace) wrote (last edit ):

Hi all,

I have checked that the fix for LP #1827159 introduces the problem (as kindly said by the reporter) because removing the line corresponding to tmpfs in the fix restores the desired behaviour:

root@nagios-focal:~# df -h | grep reproduce
tmpfs 2.0G 0 2.0G 0% /reproduce
root@nagios-focal:~# /usr/lib/nagios/plugins/check_disk -w 10% -c 5% -p /reproduce
DISK OK - free space: /reproduce 2048 MB (100% inode=99%);| /reproduce=0MB;1843;1945;0;2048

In upstream, it isn't clear to apply the fix for LP #1827159 to tmpfs: https://github.com/monitoring-plugins/monitoring-plugins/pull/1609 and https://github.com/monitoring-plugins/monitoring-plugins/issues/1608

Now, checking the side effects of reverting the fix for tmpfs on the original issue (LP #1827159) ...

Revision history for this message
Miriam España Acebal (mirespace) wrote :

Oh, reverting the fix only for tmpfs introduces again the "DISK CRITICAL" noise... Looking into the workaround to understand why there it works OK.

Revision history for this message
Miriam España Acebal (mirespace) wrote :

Debugging a little between behaviour ok/non-ok: it seems it goes through "calling stat" (stat_path function in check_disk.c) at least twice when the result (STATE) is OK:

  * without the fix for bug 1827159 (good case):
     root@nagios-focal-miriam:~# /usr/lib/nagios/plugins/check_disk -w 10% -c 5% -vvv -p /reproduce
     calling stat on /reproduce
     Thresholds(pct) for /reproduce warn: 10.000000 crit 5.000000
     calling stat on /reproduce
     For /reproduce, used_pct=0 free_pct=100 used_units=0 free_units=2048 total_units=2048 used_inodes_pct=1 free_inodes_pct=99 fsp.fsu_blocksize=4096 mult=1048576
     Freespace_units result=0
     Freespace% result=0
     Usedspace_units result=0
     Usedspace_percent result=0
     Usedinodes_percent result=0
     Freeinodes_percent result=0
     DISK OK - free space: /reproduce 2048 MB (100% inode=99%);| /reproduce=0MB;1843;1945;0;2048

  * with the fix:
    - Bad case:
        root@nagios-focal:~# /usr/lib/nagios/plugins/check_disk -w 10% -c 5% -vvvv -p /reproduce
        calling stat on /reproduce
        Thresholds(pct) for /reproduce warn: 10.000000 crit 5.000000
        DISK UNKNOWN - free space:|

    - Good case (using group option workaround):
        root@nagios-focal:~# /usr/lib/nagios/plugins/check_disk -w 10% -c 5% -vvvv -g repro -p /reproduce
        calling stat on /reproduce
        Thresholds(pct) for /reproduce warn: 10.000000 crit 5.000000
        Group of /reproduce: repro
        calling stat on /reproduce
        calling stat on /reproduce
        Group repro: adding 524288 blocks sized 4096, (/reproduce) used_units=0 free_units=2048
        total_units=2048 fsu_blocksize=1048576 mult=93861737284654
        Group repro now has: used_units=0 free_units=2048 total_units=2048 fsu_blocksize=524288 mult=4096
        For repro, used_pct=0 free_pct=100 used_units=0 free_units=2048 total_units=2048 used_inodes_pct=1 free_inodes_pct=99 fsp.fsu_blocksize=4096 mult=1048576
        Freespace_units result=0
        Freespace% result=0
        Usedspace_units result=0
        Usedspace_percent result=0
        Usedinodes_percent result=0
        Freeinodes_percent result=0
        DISK OK - free space: repro 2048 MB (100% inode=99%);| repro=0MB;1843;1945;0;2048

Also, with the fix, the whole disk check operations are consistent (if you check on units or average the result is OK) and without the fix, it varies from warning, critical, ok ... depending on the combination, i.e.:

   /usr/lib/nagios/plugins/check_disk -w 10 -c 10
   /usr/lib/nagios/plugins/check_disk -w 10% -c 10%
   /usr/lib/nagios/plugins/check_disk -w 10% -c 10
   /usr/lib/nagios/plugins/check_disk -w 10 -c 10%
   /usr/lib/nagios/plugins/check_disk -w 10
   /usr/lib/nagios/plugins/check_disk -w 10%
   /usr/lib/nagios/plugins/check_disk -c 10
   /usr/lib/nagios/plugins/check_disk -c 10%

Revision history for this message
Miriam España Acebal (mirespace) wrote :

Here we have to make a solution that satisfies bug 1827159 and this one (bug 1940916):

1) Non exclude the squash, trace and tmp filesystems if the -p option is provided. Exclude them otherwise.
2) if the -N option is present (the include option), no exclude the selected fs for inclusion (as exclude has precedence over include).

But, it seems in the upstream sid Debian package this behaviour doesn't occur, so I'll check the build of that 2.3.1-1 version on the supported Ubuntu series for that 3 filesystems.

Revision history for this message
Utkarsh Gupta (utkarsh) wrote :

Hi Miriam,

A duplicate of this has been reported via LP: #1958481. Could you please also check that and make sure that it indeed is a dupe and will be fixed with whatever route you take. :)

TIA.

Revision history for this message
Miriam España Acebal (mirespace) wrote :

Hi Utkarsh,

sure :). Thanks Richard also for the approach, which is like 1) in comment #7... so it looks like it's going in a good direction

Revision history for this message
Miriam España Acebal (mirespace) wrote :
Download full text (4.7 KiB)

Combining 1) and 2) from #7 the results are ok for both bugs (I'm preparing already the MP):

root@nagios-focal-miriam:~# /usr/lib/nagios/plugins/check_disk -w 10 -c 10
DISK OK - free space: / 6971 MB (85% inode=99%); /dev/fuse 32071 MB (100% inode=99%); /dev/net/tun 32071 MB (100% inode=99%); /dev/full 32071 MB (100% inode=99%); /dev/null 32071 MB (100% inode=99%); /dev/random 32071 MB (100% inode=99%); /dev/tty 32071 MB (100% inode=99%); /dev/urandom 32071 MB (100% inode=99%); /dev/zero 32071 MB (100% inode=99%); /snap 6971 MB (85% inode=99%);| /=1204MB;8165;8165;0;8175 /dev/fuse=0MB;32061;32061;0;32071 /dev/net/tun=0MB;32061;32061;0;32071 /dev/full=0MB;32061;32061;0;32071 /dev/null=0MB;32061;32061;0;32071 /dev/random=0MB;32061;32061;0;32071 /dev/tty=0MB;32061;32061;0;32071 /dev/urandom=0MB;32061;32061;0;32071 /dev/zero=0MB;32061;32061;0;32071 /snap=1204MB;8165;8165;0;8175

root@nagios-focal-miriam:~# /usr/lib/nagios/plugins/check_disk -w 10% -c 5% -p /reproduce-tmpfs
DISK OK - free space: /reproduce-tmpfs 2048 MB (100% inode=99%);| /reproduce-tmpfs=0MB;1843;1945;0;2048

root@nagios-focal-miriam:~# /usr/lib/nagios/plugins/check_disk -w 10% -c 5% -N tmpfs
DISK OK - free space: /dev 0 MB (99% inode=99%); /dev/lxd 0 MB (100% inode=99%); /dev/.lxd-mounts 0 MB (100% inode=99%); /proc/sys/kernel/random/boot_id 0 MB (99% inode=99%); /dev/shm 32106 MB (100% inode=99%); /run 6421 MB (99% inode=99%); /run/lock 5 MB (100% inode=99%); /sys/fs/cgroup 32106 MB (100% inode=99%); /run/user/0 6421 MB (100% inode=99%); /run/snapd/ns 6421 MB (99% inode=99%); /reproduce-tmpfs 2048 MB (100% inode=99%); /reproduce-squashfs 2048 MB (100% inode=99%); /reproduce-tracefs 2048 MB (100% inode=99%);| /dev=0MB;0;0;0;0 /dev/lxd=0MB;0;0;0;0 /dev/.lxd-mounts=0MB;0;0;0;0 /proc/sys/kernel/random/boot_id=0MB;0;0;0;0 /dev/shm=0MB;28895;30500;0;32106 /run=0MB;5778;6099;0;6421 /run/lock=0MB;4;4;0;5 /sys/fs/cgroup=0MB;28895;30500;0;32106 /run/user/0=0MB;5778;6099;0;6421 /run/snapd/ns=0MB;5778;6099;0;6421 /reproduce-tmpfs=0MB;1843;1945;0;2048 /reproduce-squashfs=0MB;1843;1945;0;2048 /reproduce-tracefs=0MB;1843;1945;0;2048

root@nagios-focal-miriam:~# /usr/lib/nagios/plugins/check_disk -w 10% -c 5% -N tmpfs -p /reproduce-tmpfs
DISK OK - free space: /reproduce-tmpfs 2048 MB (100% inode=99%);| /reproduce-tmpfs=0MB;1843;1945;0;2048

root@nagios-focal-miriam:~# /usr/lib/nagios/plugins/check_disk -w 10% -c 5% -X tmpfs -p /reproduce-tmpfs
DISK UNKNOWN - free space:|

root@nagios-focal-miriam:~# /usr/lib/nagios/plugins/check_disk -w 10% -c 5% -X squashfs -p /reproduce-tmpfs
DISK OK - free space: /reproduce-tmpfs 2048 MB (100% inode=99%);| /reproduce-tmpfs=0MB;1843;1945;0;2048
root@nagios-focal-miriam:~# /usr/lib/nagios/plugins/check_disk -w 10% -c 5% -X squashfs -N tmpfs

DISK OK - free space: /dev 0 MB (99% inode=99%); /dev/lxd 0 MB (100% inode=99%); /dev/.lxd-mounts 0 MB (100% inode=99%); /proc/sys/kernel/random/boot_id 0 MB (99% inode=99%); /dev/shm 32106 MB (100% inode=99%); /run 6421 MB (99% inode=99%); /run/lock 5 MB (100% inode=99%); /sys/fs/cgroup 32106 MB (100% inode=99%); /run/user/0 6421 MB (100% inode=99%); /run/snapd/ns 6421 MB (99% inode=99%); /reproduce-tmpfs 2048 MB (100%...

Read more...

Miriam España Acebal (mirespace)
description: updated
description: updated
Bryce Harrington (bryce)
no longer affects: percona-monitoring-plugins
Miriam España Acebal (mirespace)
description: updated
Revision history for this message
Brian Murray (brian-murray) wrote :

Reading the bug report this change doesn't seem to have landed in Jammy which is a prerequisite to SRU'ing the fix to Focal. What is the plan for getting this change into Jammy?

Changed in monitoring-plugins (Ubuntu Focal):
status: New → Incomplete
Miriam España Acebal (mirespace)
Changed in monitoring-plugins (Ubuntu Focal):
assignee: nobody → Miriam España Acebal (mirespace)
status: Incomplete → In Progress
importance: Undecided → Medium
Miriam España Acebal (mirespace)
Changed in monitoring-plugins (Ubuntu Impish):
assignee: nobody → Miriam España Acebal (mirespace)
importance: Undecided → Medium
status: New → In Progress
Revision history for this message
Miriam España Acebal (mirespace) wrote :

Hi Brian,

sorry, changes for Jammy are now under review in its corresponding MP. I also submitted the change for Impish as well.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package monitoring-plugins - 2.3.1-1ubuntu4

---------------
monitoring-plugins (2.3.1-1ubuntu4) jammy; urgency=medium

  * d/p/exclude-tmpfs-squashfs-tracefs.patch: Adding synthetic filesystems
    for exclusion only if they have not been included and no mount point
    has been provided in command line. Re-implementing solution for
    LP bug 1827159. (LP: #1940916).

 -- Miriam España Acebal <email address hidden> Wed, 02 Feb 2022 13:35:26 +0100

Changed in monitoring-plugins (Ubuntu Jammy):
status: In Progress → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Jonathan, or anyone else affected,

Accepted monitoring-plugins into impish-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/monitoring-plugins/2.3.1-1ubuntu2.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-impish to verification-done-impish. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-impish. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in monitoring-plugins (Ubuntu Impish):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-impish
Changed in monitoring-plugins (Ubuntu Focal):
status: In Progress → Fix Committed
tags: added: verification-needed-focal
Revision history for this message
Brian Murray (brian-murray) wrote :

Hello Jonathan, or anyone else affected,

Accepted monitoring-plugins into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/monitoring-plugins/2.2-6ubuntu1.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Richard Laager (rlaager)
tags: added: verification-done-focal
removed: verification-needed-focal
Revision history for this message
Miriam España Acebal (mirespace) wrote :
Download full text (6.2 KiB)

Installing...

Setting up monitoring-plugins (2.3.1-1ubuntu2.1) ...

Checking the #DISK UNKNOWN cases ... all OK:

root@checkdisks-impish:~# /usr/lib/nagios/plugins/check_disk -w 10% -c 5% -p /reproduce-tmpfs
DISK OK - free space: /reproduce-tmpfs 2048 MB (100% inode=99%);| /reproduce-tmpfs=0MB;1843;1945;0;2048
root@checkdisks-impish:~# /usr/lib/nagios/plugins/check_disk -w 10% -c 5% -N tmpfs
DISK OK - free space: /dev 0 MB (99% inode=99%); /dev/lxd 0 MB (100% inode=99%); /dev/.lxd-mounts 0 MB (100% inode=99%); /proc/sys/kernel/random/boot_id 0 MB (99% inode=99%); /dev/shm 32106 MB (100% inode=99%); /run 12842 MB (99% inode=99%); /run/lock 5 MB (100% inode=99%); /sys/fs/cgroup 4 MB (100% inode=98%); /run/user/0 6421 MB (100% inode=99%); /reproduce-tmpfs 2048 MB (100% inode=99%); /reproduce-squashfs 2048 MB (100% inode=99%); /reproduce-tracefs 2048 MB (100% inode=99%); /run/snapd/ns 12842 MB (99% inode=99%);| /dev=0MB;0;0;0;0 /dev/lxd=0MB;0;0;0;0 /dev/.lxd-mounts=0MB;0;0;0;0 /proc/sys/kernel/random/boot_id=0MB;0;0;0;0 /dev/shm=0MB;28895;30500;0;32106 /run=0MB;11557;12199;0;12842 /run/lock=0MB;4;4;0;5 /sys/fs/cgroup=0MB;3;3;0;4 /run/user/0=0MB;5778;6099;0;6421 /reproduce-tmpfs=0MB;1843;1945;0;2048 /reproduce-squashfs=0MB;1843;1945;0;2048 /reproduce-tracefs=0MB;1843;1945;0;2048 /run/snapd/ns=0MB;11557;12199;0;12842
root@checkdisks-impish:~# /usr/lib/nagios/plugins/check_disk -w 10% -c 5% -N tmpfs -p /reproduce-tmpfs
DISK OK - free space: /reproduce-tmpfs 2048 MB (100% inode=99%);| /reproduce-tmpfs=0MB;1843;1945;0;2048
root@checkdisks-impish:~# /usr/lib/nagios/plugins/check_disk -w 10% -c 5% -X tmpfs -p /reproduce-tmpfs
DISK UNKNOWN - free space:|
root@checkdisks-impish:~# /usr/lib/nagios/plugins/check_disk -w 10% -c 5% -X squashfs -p /reproduce-tmpfs
DISK OK - free space: /reproduce-tmpfs 2048 MB (100% inode=99%);| /reproduce-tmpfs=0MB;1843;1945;0;2048
root@checkdisks-impish:~# /usr/lib/nagios/plugins/check_disk -w 10% -c 5% -X squashfs -N tmpfs
DISK OK - free space: /dev 0 MB (99% inode=99%); /dev/lxd 0 MB (100% inode=99%); /dev/.lxd-mounts 0 MB (100% inode=99%); /proc/sys/kernel/random/boot_id 0 MB (99% inode=99%); /dev/shm 32106 MB (100% inode=99%); /run 12842 MB (99% inode=99%); /run/lock 5 MB (100% inode=99%); /sys/fs/cgroup 4 MB (100% inode=98%); /run/user/0 6421 MB (100% inode=99%); /reproduce-tmpfs 2048 MB (100% inode=99%); /reproduce-squashfs 2048 MB (100% inode=99%); /reproduce-tracefs 2048 MB (100% inode=99%); /run/snapd/ns 12842 MB (99% inode=99%);| /dev=0MB;0;0;0;0 /dev/lxd=0MB;0;0;0;0 /dev/.lxd-mounts=0MB;0;0;0;0 /proc/sys/kernel/random/boot_id=0MB;0;0;0;0 /dev/shm=0MB;28895;30500;0;32106 /run=0MB;11557;12199;0;12842 /run/lock=0MB;4;4;0;5 /sys/fs/cgroup=0MB;3;3;0;4 /run/user/0=0MB;5778;6099;0;6421 /reproduce-tmpfs=0MB;1843;1945;0;2048 /reproduce-squashfs=0MB;1843;1945;0;2048 /reproduce-tracefs=0MB;1843;1945;0;2048 /run/snapd/ns=0MB;11557;12199;0;12842

#DISK CRITICAL cases ... OK too

root@checkdisks-impish:~# /usr/lib/nagios/plugins/check_disk -w 10 -c 10
DISK OK - free space: / 7718 MB (91% inode=99%); /dev/fuse 32070 MB (100% inode=99%); /dev/net/tun 32070 MB (100% inode=99%); /dev/full 32070 MB (100% inode=99%); /dev/null 320...

Read more...

tags: added: verification-done verification-done-impish
removed: verification-needed verification-needed-impish
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package monitoring-plugins - 2.3.1-1ubuntu2.1

---------------
monitoring-plugins (2.3.1-1ubuntu2.1) impish; urgency=medium

  * d/p/exclude-tmpfs-squashfs-tracefs.patch: Adding synthetic filesystems
    for exclusion only if they have not been included and no mount point
    has been provided in command line. Re-implementing solution for
    LP bug 1827159. (LP: #1940916).

 -- Miriam España Acebal <email address hidden> Wed, 02 Feb 2022 12:19:06 +0100

Changed in monitoring-plugins (Ubuntu Impish):
status: Fix Committed → Fix Released
Revision history for this message
Robie Basak (racb) wrote : Update Released

The verification of the Stable Release Update for monitoring-plugins has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package monitoring-plugins - 2.2-6ubuntu1.2

---------------
monitoring-plugins (2.2-6ubuntu1.2) focal; urgency=medium

  * d/p/exclude-tmpfs-squashfs-tracefs.patch: Adding synthetic filesystems
    for exclusion only if they have not been included and no mount point
    has been provided in command line. Re-implementing solution for
    LP bug 1827159. (LP: #1940916).

 -- Miriam España Acebal <email address hidden> Wed, 01 Dec 2021 07:55:47 +0100

Changed in monitoring-plugins (Ubuntu Focal):
status: Fix Committed → Fix Released
Miriam España Acebal (mirespace)
tags: removed: server-todo
Dariusz Gadomski (dgadomski)
Changed in monitoring-plugins (Ubuntu Bionic):
assignee: nobody → Hua Zhang (zhhuabj)
Dariusz Gadomski (dgadomski)
Changed in monitoring-plugins (Ubuntu Bionic):
importance: Undecided → Medium
Dariusz Gadomski (dgadomski)
tags: added: sts sts-sponsor-dgadomski
Revision history for this message
Robie Basak (racb) wrote :

Minor review point. This upload does a completely unnecessary quilt refresh and denormalizes the patch. Please see: https://lists.ubuntu.com/archives/ubuntu-devel/2022-May/042103.html

It's not worth fixing now though, so I'm accepting.

Changed in monitoring-plugins (Ubuntu Bionic):
status: New → Fix Committed
tags: added: verification-needed verification-needed-bionic
removed: verification-done
Revision history for this message
Robie Basak (racb) wrote : Please test proposed package

Hello Jonathan, or anyone else affected,

Accepted monitoring-plugins into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/monitoring-plugins/2.2-3ubuntu3.18.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Revision history for this message
Hua Zhang (zhhuabj) wrote :

This is the test result for 2.2-3ubuntu3.18.04.1, it works, see - https://paste.ubuntu.com/p/fTqg2hhzk7/

tags: added: verification-done-bionic
removed: verification-needed-bionic
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package monitoring-plugins - 2.2-3ubuntu3.18.04.1

---------------
monitoring-plugins (2.2-3ubuntu3.18.04.1) bionic; urgency=medium

  * d/p/exclude-tmpfs-squashfs-tracefs.patch: Adding synthetic filesystems
    for exclusion only if they have not been included and no mount point
    has been provided in command line. Re-implementing solution for
    LP bug 1827159. (LP: #1940916)

 -- Zhang Hua <email address hidden> Mon, 27 Jun 2022 18:12:04 +0800

Changed in monitoring-plugins (Ubuntu Bionic):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.