Support Script to Update Patron Penalties Needed

Been meaning to put something together for this so I can stop with the ad-hoc shell scripts.

Plan is to create a support-scripts Perl script that has a few options:

* process all non-deleted patrons
* process patrons from a file of IDs

To handle some other common cases, add filters like:

* limit to patrons with fines greater than / less then X
* limit to patrons with open circulations.
* Probably others..

Here's a branch:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1944986-patron-penalty-batch-update

cd Open-ILS/src/support-scripts && ./patron-penalties-batch.pl --help

Pushed --has-penalty and --no-has-penalty filters.

Would it be appropriate to install this script into the Evergreen bin directory during install? With the $osrf_config getting set to the correct value?
Josh

I used the script recently for some post-COVID work and had an unexpected side effect.

Some standing penalties can be generated by the system (e.g. PATRON_EXCEEDS_COLLECTIONS_WARNING) based on a threshold, but can also be manually archived by staff even when the conditions that resulted in the penalty still exist.

If the patron interacts with the system in a way that causes penalties to be regenerated OR a batch script runs that updates everyone's penalties, the manually archived penalty can be re-applied for patrons that still meet the required conditions.

If the penalty in question causes, say, a billing notice to be sent, regenerating such penalties can cause a large pile of notices to be sent to patrons that have already received the same notice. Good times.

Removing pullrequest. Adding Needs discussion.

I've embedded the script here in another branch over at bug 2006971 in order to add some additional functionality. If this version ends up going in first then that branch will need a trim, but if it goes first then we can mark this one as a duplicate.

In either case, thanks, Bill! I think this'll be very useful.

Speaking for PaILS, we're comfortable with combining this with the work on 2006971 (we tested it both on Butternut and previously on another Equinox server) -- we should add the fact that staff-archived penalties can be re-instated to the documentation; I don't think that the reverse (that a recalculation script would NOT apply penalties that had been manually archived if the conditions still existed) would be a desirable behavior.
(cross-posted on 1944986 and 2006971)

The patch for this branch was merged as part of bug #2006971.