Mahara

Comment ratings have a link underline when they shouldn't

Bug #1950069 reported by Kristina Hoeppner
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Evonne Cheung
Mahara 22.04.0
21.04
Fix Released
Medium
Unassigned
Mahara 21.04.4
21.10
Fix Released
Medium
Unassigned
Mahara 21.10.2
22.04
Fix Released
Medium
Evonne Cheung
Mahara 22.04.0

Bug Description

Comment ratings have a link underline when you don't hover over them when they shouldn't as it makes them harder to distinguish (see attachment).

To replicate:

1. Allow comment ratings in Admin menu -> Extensions -> Plugin administration -> comment.
2. Add a comment to a page with a comment rating.
3. Refresh the page to see the comment.

Expected result: There are no underlines between the symbols when not hovering over them.
Actual result: There are link underlines between the symbols when not hovering over them.

Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "main" branch: https://reviews.mahara.org/12242

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/12242
Committed: https://git.mahara.org/mahara/mahara/commit/782b87d8f49ab8d9555d5ca757deef986c1c94a4
Submitter: Robert Lyon (<email address hidden>)
Branch: main

commit 782b87d8f49ab8d9555d5ca757deef986c1c94a4
Author: Evonne <email address hidden>
Date: Thu Nov 11 10:53:33 2021 +1300

Bug 1950069 Removing ratings stars underline

Also fontawesome wasn't displaying the solid star due to incorrect
weight and file reference.

steps: 1. turn on comments rating in institution
2. make a page
3. add comment form choose a 3 star rating, save

Expected: comment should display 3 solid stars and 2 outline stars
Actual: comment displays 5 outline stars

behatnotneeded

Change-Id: I9619605b9eca03bcd8cffcdb6389a059a12cb8e8

Robert Lyon (robertl-9)
Changed in mahara:
status: Confirmed → Fix Committed
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "21.10_DEV" branch: https://reviews.mahara.org/12504

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "21.04_DEV" branch: https://reviews.mahara.org/12505

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "20.10_DEV" branch: https://reviews.mahara.org/12506

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/12506
Committed: https://git.mahara.org/mahara/mahara/commit/e2c47a9d4e5fe74248b744882e56a080981f66f6
Submitter: Doris Tam (<email address hidden>)
Branch: 20.10_DEV

commit e2c47a9d4e5fe74248b744882e56a080981f66f6
Author: Evonne <email address hidden>
Date: Thu Nov 11 10:53:33 2021 +1300

Bug 1950069 Removing ratings stars underline

Also fontawesome wasn't displaying the solid star due to incorrect
weight and file reference.

steps: 1. turn on comments rating in institution
2. make a page
3. add comment form choose a 3 star rating, save

Expected: comment should display 3 solid stars and 2 outline stars
Actual: comment displays 5 outline stars

behatnotneeded

Change-Id: I9619605b9eca03bcd8cffcdb6389a059a12cb8e8

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/12505
Committed: https://git.mahara.org/mahara/mahara/commit/0322f5a7771307a949b3162cf90319eb05fe405d
Submitter: Doris Tam (<email address hidden>)
Branch: 21.04_DEV

commit 0322f5a7771307a949b3162cf90319eb05fe405d
Author: Evonne <email address hidden>
Date: Thu Nov 11 10:53:33 2021 +1300

Bug 1950069 Removing ratings stars underline

Also fontawesome wasn't displaying the solid star due to incorrect
weight and file reference.

steps: 1. turn on comments rating in institution
2. make a page
3. add comment form choose a 3 star rating, save

Expected: comment should display 3 solid stars and 2 outline stars
Actual: comment displays 5 outline stars

behatnotneeded

Change-Id: I9619605b9eca03bcd8cffcdb6389a059a12cb8e8
(cherry picked from commit 782b87d8f49ab8d9555d5ca757deef986c1c94a4)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/12504
Committed: https://git.mahara.org/mahara/mahara/commit/045784c1932a67e4b3f3d9a48feb2f016f2c29c2
Submitter: Doris Tam (<email address hidden>)
Branch: 21.10_DEV

commit 045784c1932a67e4b3f3d9a48feb2f016f2c29c2
Author: Evonne <email address hidden>
Date: Thu Nov 11 10:53:33 2021 +1300

Bug 1950069 Removing ratings stars underline

Also fontawesome wasn't displaying the solid star due to incorrect
weight and file reference.

steps: 1. turn on comments rating in institution
2. make a page
3. add comment form choose a 3 star rating, save

Expected: comment should display 3 solid stars and 2 outline stars
Actual: comment displays 5 outline stars

behatnotneeded

Change-Id: I9619605b9eca03bcd8cffcdb6389a059a12cb8e8
(cherry picked from commit 782b87d8f49ab8d9555d5ca757deef986c1c94a4)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.