failing tests with new sssd, blocks python3-defaults

Bug #1962510 reported by Steve Langasek
14
This bug affects 1 person
Affects Status Importance Assigned to Milestone
adsys (Ubuntu)
Fix Released
Undecided
Unassigned
Focal
Fix Released
Undecided
Unassigned

Bug Description

[Impact]
Fix some flaky tests to ensure that future SRUs are easier to release

[Test Plan]
1. Have the package build (tests are running) and that DEP8 tests are passing.

[Where problems could occur]
The fix is only impacting some tests that were flaky and asking for a rerun. Fixes are only located in this test code to make them more reliable and less racy, even in VM environments.

-----------------------------

adsys has failing autopkgtests on armhf. Demoting the package to -proposed to unblock the python3-defaults transition.

Steve Langasek (vorlon)
tags: added: block-proposed
Revision history for this message
Sebastien Bacher (seb128) wrote :

why removing the package rather than just hinting the test results?

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

These tests are a firehose, but I think this is the only failure on armhf: " --- FAIL: TestInit/Configuration_changed (0.00s)"

--- FAIL: TestInit (2.22s)
    --- PASS: TestInit/Error_on_config_flag_points_to_unexisting_path (0.00s)
    --- PASS: TestInit/Load_configuration,_no_file,_no_flag,_no_env (0.00s)
    --- PASS: TestInit/Empty_configuration_file_is_supported (0.02s)
    --- PASS: TestInit/Flag_is_supported (0.03s)
    --- PASS: TestInit/Error_on_invalid_configuration_file (0.00s)
    --- PASS: TestInit/Error_on_callback_returning_error_on_first_call (0.00s)
    --- PASS: TestInit/Load_configuration_with_file (0.00s)
    --- PASS: TestInit/No_config_flag_set_before_Init_is_call_is_ignored (0.00s)
    --- FAIL: TestInit/Configuration_changed (0.00s)
    --- PASS: TestInit/Error_on_no_verbose_flag_set_before_Init_is_call (0.00s)
    --- PASS: TestInit/Configuration_file_created_after_Init()_is_not_taken_into_account (2.00s)
    --- PASS: TestInit/Callback_in_error_on_refresh_only_prints_warning (0.00s)
    --- PASS: TestInit/Flag_has_precedence_over_env (0.03s)
    --- PASS: TestInit/Env_has_precedence_over_configuration (0.06s)
    --- PASS: TestInit/Configuration_flag_has_precedence_over_local_file (0.00s)
    --- PASS: TestInit/Configuration_flag,_not_in_config_dir (0.00s)
    --- PASS: TestInit/Environment_is_supported (0.00s)

No idea what happened, there is no other clue whatsoever in the test output.

Revision history for this message
Sebastien Bacher (seb128) wrote :

removing the blocker tag since python3-defaults migrated now

tags: removed: block-proposed
Revision history for this message
Steve Langasek (vorlon) wrote :

Removing the tag means that this package will reenter the release pocket with failing tests. Who is responsible for fixing these tests? The standard for proposed-migration is that we don't regret tests.

Revision history for this message
Sebastien Bacher (seb128) wrote :

The package isn't regressing tests since it's not present in the release pocket at the moment. In any case adsys is in a target promotion for desktop for the incoming LTS, bug #1936907, we will own the issues as we do for any of our other packages.

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

I troubleshooted this initially in https://bugs.launchpad.net/ubuntu/+source/adsys/+bug/1962170, when all tests were failing, and reached the same patch that mwhudson did, but the tests were still failing.

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

The flaky test on armhf is fixed by https://github.com/ubuntu/adsys/pull/292 (couldn’t retrigger the flakyness after multiple builds in ppa with this patch)
The ppcel64 issue, introduced by new samba is workarounded in https://github.com/ubuntu/adsys/pull/295

Changed in adsys (Ubuntu):
status: New → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package adsys - 0.8.1

---------------
adsys (0.8.1) jammy; urgency=medium

  * Change chown logic on script directory and parents to avoid potential
    vulnerability. (LP: #1961458)
  * Separate readiness from session running to avoid unrefreshed user script
    directories after a logout without any new logins.
  * pam_adsys: Fix memory leak and identation. (LP: #1961459)
  * Adapt to newer samba, while keeping backward compatilibity for CI.
    Thanks Michael. (LP: #1962170)
  * Try to stabilize configuration detection change test by calling sync() to
    sync FHS to disk, and then, hoping we get the inotify update. Seems to fix
    flakyness on armhf. (LP: #1962510)
  * Enforce closing stderr on ppcel64 in tests with new samba to avoid hangs
    in race.
  * Fix linting issues discovered by new golangci-lint.
  * Misc syntax polish.
  * Dependencies update:
    - github.com/godbus/dbus/v5
    - github.com/golangci/golangci-lint
    - gopkg.in/ini.v1

 -- Didier Roche <email address hidden> Tue, 08 Mar 2022 09:49:08 +0100

Changed in adsys (Ubuntu):
status: Fix Committed → Fix Released
description: updated
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Please test proposed package

Hello Steve, or anyone else affected,

Accepted adsys into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/adsys/0.9.2~20.04 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in adsys (Ubuntu Focal):
status: New → Fix Committed
tags: added: verification-needed verification-needed-focal
Revision history for this message
Jean-Baptiste Lallement (jibel) wrote :

Verified successfully on Focal with adsys 0.9.2~20.04.

Marking as verification-done

tags: added: verification-done verification-done-focal
removed: verification-needed verification-needed-focal
Revision history for this message
Chris Halse Rogers (raof) wrote : Update Released

The verification of the Stable Release Update for adsys has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (5.7 KiB)

This bug was fixed in the package adsys - 0.9.2~20.04

---------------
adsys (0.9.2~20.04) focal; urgency=medium

  * Backport to focal
    - Build with Go 1.16
    - Move debhelper compat to 12
    - Do not recommends ubuntu-advantage-desktop-daemon as it’s not available
      on focal yet.

adsys (0.9.2) kinetic; urgency=medium

  * Update generators to fix FTBFS
    - shell out to mkdir instead of go's os.Mkdir which can bypass fakeroot's
      filesystem hijacking and cause unexpected behavior
  * Update dependencies to latest:
    - github.com/golangci/golangci-lint
    - google.golang.org/protobuf

adsys (0.9.1) kinetic; urgency=medium

  [ Didier Roche ]
  [ Gabriel Nagy ]
  * Fix loading policy content from uppercase folders (LP: #1982330)
  * Add GSettings power management keys (LP: #1982349)
  * Allow parsing policy entries with empty values (LP: #1982342)
  * Allow parsing policies with unsupported types (LP: #1982343)
  * Allow parsing policy entries with no data (LP: #1982345)
  * Lowercase target name when normalizing (LP: #1982347)
  * Annotate policies that require Ubuntu Pro (LP: #1982348)
  * Update dependencies to latest:
    - github.com/spf13/cobra
    - github.com/spf13/viper
    - github.com/stretchr/testify
    - github.com/charmbracelet/bubbletea
    - github.com/charmbracelet/bubbles
    - google.golang.org/grpc
    - github.com/golangci/golangci-lint
    - github.com/sirupsen/logrus

adsys (0.9.0) kinetic; urgency=medium

  [ Jean-Baptiste Lallement ]
  [ Didier Roche ]
  [ Gabriel Nagy ]
  * Add Active Directory Watch Daemon - adwatchd: (LP: #1982351)
    - Implement a Windows daemon that watches a list of configured directories
      for changes and bumps the relevant GPT.INI files.
    - Add adsys-windows binary package which includes the Windows daemon
      executable and the admx/adml policies.
  * Config detection now includes current executable directory
  * Fixes in generator build race
  * Update dependencies to latest:
    - github.com/spf13/cobra
    - github.com/stretchr/testify
  * CI updates:
    - switch to Go setup v3
    - bump to really build with Golang 1.18

adsys (0.8.6) kinetic; urgency=medium

  * Fix new build failures on 32 bits due to libsmbclient-dev no longer sets
    the large file support cflags in libsmbclient.h.
    Update to latest libsmbclient-go.
  * Update dependencies to latest:
    - google.golang.org/grpc
    - gopkg.in/ini.v1
    - github.com/golangci/golangci-lint
    - github.com/spf13/viper
    - github.com/stretchr/testify

adsys (0.8.5) kinetic; urgency=medium

  [ Jean-Baptiste Lallement ]
  [ Didier Roche ]
  * Rename chapters to be in correct ascii order when viewed online.
    Thanks to Anton Drastrup-Fjordbak.
  * Include 22.04 in admx/adml for lts only releases. (LP: #1973745)
  * Bump embedeed dependencies minor versions for both bug fixes and minor
    security enhancements.
  * Fix dconf keys not being readable by user after applying policy.
    (LP: #1973748)
  * Ensure we can execute machine and user scripts:
    /run is now noexec on Ubuntu. Ensure that we can execute the scripts in
    /run/adsys subdirectories. The scripts mechanism has been reviewed by the...

Read more...

Changed in adsys (Ubuntu Focal):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.