Change password hangs on palindrome

Bug #196386 reported by Mark Browning
2
Affects Status Importance Assigned to Milestone
gnome-control-center
Fix Released
Low
gnome-control-center (Ubuntu)
Fix Released
Low
Ubuntu Desktop Bugs

Bug Description

When user attempts to change password to a palindrome, gnome-about-me hangs indefinitely, but can be cancelled.

`passwd` correctly warns about palindrome passwords, but this rare case is not handled by the GUI.

Tested today (2/28/2008) on Gutsy 7.10.

Steps to repeat:

System->About Me>Change password -> [Authenticate] ->

Type any palindrome, such as 'panamanap' or 'toot' into both new password boxes, and press enter or click 'Change password'

The system should give a warning about palindrome passwords and allow user to try a new password. Instead, it gives the appearance of working in the background while not actually doing anything.

Revision history for this message
Mark Browning (mabrowningrr) wrote :

Upon inspection of the code, it is a simple typo.

In gnome-control-center/capplets/about-me/gnome-about-me-password.c, there are two typos: panlindrome instead of palindrome on line 498 and 529. This is a simple fix, I just don't have the experience to update anything of importance.

Revision history for this message
Koen (koen-beek) wrote :

Thank you for taking the time to report this bug and helping to make Ubuntu better. This bug did not have a package associated with it, which is important for ensuring that it gets looked at by the proper developers. You can learn more about finding the right package at [WWW] https://wiki.ubuntu.com/Bugs/FindRightPackage . I have classified this bug as a bug in gnome-control-center.

Revision history for this message
Koen (koen-beek) wrote :

The source code looks like this (gnome-control-center 1:2.20.1-0ubuntu1)

                        if (is_string_complete (str->str, "successfully",
                                                                                          "short",
                                                                                          "panlindrome",
                                                                                          "simple",
                                                                                          "similar",
                                                                                          "wrapped",
                                                                                          "recovered",
                                                                                          "unchanged",
                                                                                          "match",
                                                                                          "1 numeric or special",
                                                                                          "failure",
                                                                                          NULL)) {

                                /* What response did we get? */
                                passdlg_set_busy (pdialog, FALSE);

                                if (g_strrstr (str->str, "successfully") != NULL) {
                                        /* Hooray! */

                                        passdlg_clear (pdialog);
                                        passdlg_set_status (pdialog, _("Your password has been changed."));
                                } else {
                                        /* Ohnoes! */

                                        /* Focus new password */
                                        gtk_widget_grab_focus (GTK_WIDGET (pdialog->new_password));

                                        if (g_strrstr (str->str, "recovered") != NULL) {
                                                /* What does this indicate?
                                                 * "Authentication information cannot be recovered?" from libpam? */
                                                msg = g_strdup_printf (_("System error: %s."), str->str);
                                        } else if (g_strrstr (str->str, "short") != NULL) {
                                                msg = g_strdup (_("The password is too short."));
                                        } else if (g_strrstr (str->str, "panlindrome") != NULL) {
                                                msg = g_strdup (_("The password is too simple."));
                                        } else if (g_strrstr (str->str, "simple") != NULL) {
                                                msg = g_strdup (_("The password is too simple."));
                                        } else if ((g_strrstr (str->str, "similar") != NULL) || (g_strrstr (str->str, "wrapped") != NULL)) {

Changed in gnome-control-center:
status: New → Confirmed
Revision history for this message
Sebastien Bacher (seb128) wrote :

the bug has been fixed to svn already

Changed in gnome-control-center:
assignee: nobody → desktop-bugs
importance: Undecided → Low
status: Confirmed → Fix Committed
Changed in gnome-control-center:
status: Unknown → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-control-center - 1:2.22.0-0ubuntu1

---------------
gnome-control-center (1:2.22.0-0ubuntu1) hardy; urgency=low

  * New upstream version:
    about-me:
    - Fix misspelling of "palindrome" (lp: #196386à
    common:
    - Port to GIO
    keyboard:
    - Fix leaks and remove unnecessary casts
    mouse:
    - Make the mouse orientation radio button usable with both mouse buttons
    updated translations

 -- Sebastien Bacher <email address hidden> Tue, 11 Mar 2008 23:45:07 +0100

Changed in gnome-control-center:
status: Fix Committed → Fix Released
Changed in gnome-control-center:
importance: Unknown → Low
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.