pktstat FTBFS: error: format not a string literal and no format arguments [-Werror=format-security]
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
pktstat (Debian) |
Fix Released
|
Unknown
|
|||
pktstat (Ubuntu) |
Fix Released
|
High
|
Nick Rosbrook |
Bug Description
Imported from Debian bug http://
Source: pktstat
Version: 1.8.5-7
Severity: serious
Tags: ftbfs
pktstat fails to build from source in unstable on amd64. A non-parallel
build ends as follows:
| gcc -DHAVE_CONFIG_H -I. -DPATH_
| In file included from /usr/include/
| from /usr/include/
| from display.c:17:
| /usr/include/
| 187 | # warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE"
| | ^~~~~~~
| display.c: In function ‘display_update’:
| display.c:499:33: warning: field width specifier ‘*’ expects argument of type ‘int’, but argument 2 has type ‘long unsigned int’ [-Wformat=]
| 499 | attron(
| | ~~^~
| | |
| | int
| display.c:552:13: warning: field precision specifier ‘.*’ expects argument of type ‘int’, but argument 2 has type ‘long unsigned int’ [-Wformat=]
| 552 | printw("%.*s\n", MIN(maxx - LLEN, sizeof flows[i].tag - 1),
| | ~~^~
| | |
| | int
| display.c:566:15: warning: field precision specifier ‘.*’ expects argument of type ‘int’, but argument 2 has type ‘long unsigned int’ [-Wformat=]
| 566 | printw(" %.*s\n", MIN(maxx - LLEN - 2,
| | ~~^~
| | |
| | int
| display.c:285:21: warning: variable ‘x’ set but not used [-Wunused-
| 285 | int maxx, maxy, y, x;
| | ^
| display.c: In function ‘printhelp’:
| display.c:672:3: error: format not a string literal and no format arguments [-Werror=
| 672 | printw((char *)h->name + 1);
| | ^~~~~~
| cc1: some warnings being treated as errors
| make[2]: *** [Makefile:483: display.o] Error 1
| make[2]: Leaving directory '/<<PKGBUILDDIR>>'
| make[1]: *** [Makefile:339: all] Error 2
| make[1]: Leaving directory '/<<PKGBUILDDIR>>'
| dh_auto_build: error: make -j1 returned exit code 2
| make: *** [debian/rules:11: build] Error 25
| dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2
This is likely due to ncurses including format string annotations.
Helmut
tags: | added: update-excuse |
Changed in pktstat (Debian): | |
importance: | Undecided → Unknown |
status: | New → Fix Committed |
Changed in pktstat (Debian): | |
status: | Fix Committed → Fix Released |
The linked Debian bug does provide a patch, but it has not been applied in Debian yet. I have attached that patch here.