Fix view bug created from phpstan fix

Bug #1966140 reported by Doris Tam
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Doris Tam

Bug Description

Fix error created from htdocs/lib/view.php phpstan fix.

Logic order fix.

To test, on creating a collection, cancel on the page where you add pages.

Expect: no errors
Actual: errors thrown for empty collection.

Doris Tam (doristam)
description: updated
Changed in mahara:
assignee: nobody → Doris Tam (doristam)
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "main" branch: https://reviews.mahara.org/12514

Changed in mahara:
status: New → In Progress
importance: Undecided → High
milestone: none → 22.04.0
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/12514
Committed: https://git.mahara.org/mahara/mahara/commit/4082d9efc6f554363c151d3abfcc96f8343d270c
Submitter: Robert Lyon (<email address hidden>)
Branch: main

commit 4082d9efc6f554363c151d3abfcc96f8343d270c
Author: Doris Tam <email address hidden>
Date: Thu Mar 24 11:17:03 2022 +1300

Bug 1966140: Fix logic order error on first page collection

Change-Id: I42dfb0ad39b953df75fcf52ef2aa342da12d029b

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Gold (gold.catalyst)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.