Fix drm/amd/pm: enable ASPM by default

Bug #1966680 reported by koba
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
HWE Next
Fix Released
Critical
koba
linux (Ubuntu)
Fix Released
Undecided
koba
Focal
Invalid
Undecided
Unassigned
Jammy
Fix Released
Medium
koba
Kinetic
Fix Released
Undecided
Unassigned
linux-oem-5.14 (Ubuntu)
Invalid
Undecided
Unassigned
Focal
Fix Released
Undecided
koba
Jammy
Invalid
Undecided
Unassigned
Kinetic
Invalid
Undecided
Unassigned
linux-oem-5.17 (Ubuntu)
Invalid
Undecided
Unassigned
Focal
Invalid
Undecided
koba
Jammy
Fix Released
Undecided
Unassigned
Kinetic
Invalid
Undecided
Unassigned

Bug Description

[Impact]
With WX3200 and 20.04d kernel the unit freezes on resume

[Fix]
commit 0064b0ce85bb ("drm/amd/pm: enable ASPM by default") enabled ASPM
by default but a variety of hardware configurations it turns out that this
caused a regression.

Multiple SKUs with wx3200&rx540 gpus encounter the resume&hange issue.
Before the real fix is landed, revert commit 0064b0ce85bb first.

[Test Case]
1. plug wx3200 on the adl machine and make it as a output.
2. suspend&resume machine
3. check if machine could resume successfully

[Where problems could occur]
Low, don't make AMDGPU ASPM by default.

CVE References

koba (kobako)
description: updated
Changed in linux-oem-5.14 (Ubuntu Focal):
assignee: nobody → koba (kobako)
status: New → In Progress
Changed in linux (Ubuntu Jammy):
status: New → In Progress
assignee: nobody → koba (kobako)
koba (kobako)
tags: added: oem-priority originate-from-1952981 somerville
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in linux (Ubuntu Focal):
status: New → Confirmed
Changed in linux-oem-5.14 (Ubuntu):
status: New → Confirmed
Timo Aaltonen (tjaalton)
Changed in linux-oem-5.14 (Ubuntu Jammy):
status: Confirmed → Invalid
Changed in linux-oem-5.14 (Ubuntu Focal):
status: In Progress → Fix Committed
Changed in linux (Ubuntu Focal):
status: Confirmed → Invalid
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the linux-oem-5.14/5.14.0-1032.35 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-focal' to 'verification-done-focal'. If the problem still exists, change the tag 'verification-needed-focal' to 'verification-failed-focal'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: verification-needed-focal
Revision history for this message
koba (kobako) wrote :

have verified with 5.14-oem-1032.

tags: added: verification-done-focal
removed: verification-needed-focal
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (4.1 KiB)

This bug was fixed in the package linux-oem-5.14 - 5.14.0-1032.35

---------------
linux-oem-5.14 (5.14.0-1032.35) focal; urgency=medium

  * focal/linux-oem-5.14: 5.14.0-1032.35 -proposed tracker (LP: #1967284)

  * IPU6 camera has no function on Andrews MLK (LP: #1964983)
    - SAUCE: IPU6: 2022-03-11 alpha release for Andrews MLK
    - [Config] IPU6: enable OV02C10 sensor

  * Fix audio on Zbook Studio G9 (LP: #1966010)
    - gpiolib: acpi: Convert ACPI value of debounce to microseconds
    - ALSA: hda/realtek: Fix LED on Zbook Studio G9

  * alsa: enable the cirrus-logic side-codec to make the speaker output sound
    (LP: #1965496)
    - ASoC: cs35l41: CS35L41 Boosted Smart Amplifier
    - ASoC: cs35l41: Fix use of an uninitialised variable
    - ASoC: cs35l41: Use regmap_read_poll_timeout to wait for OTP boot
    - ASoC: cs35l41: Combine adjacent register writes
    - ASoC: cs35l41: Don't overwrite returned error code
    - ASoC: cs35l41: Fixup the error messages
    - ASoC: cs35l41: Fix a bunch of trivial code formating/style issues
    - misc: cs35l41: Remove unused pdn variable
    - ASoC: cs35l41: Make cs35l41_remove() return void
    - ASoC: cs35l41: Change monitor widgets to siggens
    - ASoC: cs35l41: DSP Support
    - ASoC: cs35l41: Set the max SPI speed for the whole device
    - ASoC: cs35l41: Fix link problem
    - ASoC: cs35l41: Fix undefined reference to core functions
    - ASoC: cs35l41: Convert tables to shared source code
    - ASoC: cs35l41: Move cs35l41_otp_unpack to shared code
    - ASoC: cs35l41: Move power initializations to reg_sequence
    - ASoC: cs35l41: Create shared function for errata patches
    - ASoC: cs35l41: Create shared function for setting channels
    - ASoC: cs35l41: Create shared function for boost configuration
    - ASoC: cs35l41: Add cs35l51/53 IDs
    - ASoC: cs35l41: Remove incorrect comment
    - ASoC: cs35l41: Correct DSP power down
    - ASoC: cs35l41: Correct handling of some registers in the cache
    - ALSA: hda: cs35l41: Add support for CS35L41 in HDA systems
    - ASoC: cs35l41: Update handling of test key registers
    - ALSA: hda: cs35l41: fix double free on error in probe()
    - ALSA: hda: cs35l41: Avoid overwriting register patch
    - ALSA: hda: cs35l41: Add calls to newly added test key function
    - ALSA: hda: cs35l41: Move cs35l41* calls to its own symbol namespace
    - ALSA: hda: cs35l41: Add missing default cases
    - ALSA: hda: cs35l41: Make use of the helper function dev_err_probe()
    - ALSA: hda: cs35l41: Tidyup code
    - ALSA: hda: cs35l41: Make cs35l41_hda_remove() return void
    - ALSA: hda/realtek: Add support for Legion 7 16ACHg6 laptop
    - ALSA: hda/realtek: Add CS35L41 support for Thinkpad laptops
    - ALSA: hda/realtek: fix speakers and micmute on HP 855 G8
    - i2c: acpi: Add an i2c_acpi_client_count() helper function
    - platform/x86: i2c-multi-instantiate: Use the new i2c_acpi_client_count()
      helper
    - Revert "platform/x86: i2c-multi-instantiate: Don't create platform device
      for INT3515 ACPI nodes"
    - spi: Create helper API to lookup ACPI info for spi device
    - spi: Support selection of the index of the ACPI Spi Resource bef...

Read more...

Changed in linux-oem-5.14 (Ubuntu Focal):
status: Fix Committed → Fix Released
Revision history for this message
Timo Aaltonen (tjaalton) wrote :

what's the situation with jammy kernel?

Timo Aaltonen (tjaalton)
Changed in hwe-next:
importance: Undecided → Critical
status: New → Incomplete
Revision history for this message
koba (kobako) wrote :

need to sru this official commit that landed since v5.19-rc1

e02fe3bc7aba2f7b292c6005b8334fffd4ac5e5f
drm/amdgpu: vi: disable ASPM on Intel Alder Lake based systems

Revision history for this message
koba (kobako) wrote :
Changed in linux-oem-5.17 (Ubuntu Focal):
assignee: nobody → koba (kobako)
status: New → In Progress
Changed in hwe-next:
assignee: nobody → koba (kobako)
Stefan Bader (smb)
Changed in linux (Ubuntu Jammy):
importance: Undecided → Medium
Timo Aaltonen (tjaalton)
Changed in hwe-next:
status: Incomplete → In Progress
Timo Aaltonen (tjaalton)
Changed in linux-oem-5.17 (Ubuntu Focal):
status: In Progress → Fix Committed
Revision history for this message
Stefan Bader (smb) wrote :

I have adjusted the title to match what is actually done. Note that I had to make patch #1 a backport because we now have applied bdbeb0dde425 "drm/amdgpu: filter out radeon PCI device IDs" to jammy. This required some context adjustments.

summary: - Revert drm/amd/pm: enable ASPM by default
+ Fix drm/amd/pm: enable ASPM by default
Changed in linux (Ubuntu Jammy):
status: In Progress → Fix Committed
Timo Aaltonen (tjaalton)
Changed in linux-oem-5.17 (Ubuntu Jammy):
status: New → Fix Committed
Changed in linux-oem-5.17 (Ubuntu Focal):
status: Fix Committed → Invalid
Changed in linux-oem-5.17 (Ubuntu):
status: New → Invalid
Changed in hwe-next:
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (75.1 KiB)

This bug was fixed in the package linux - 5.15.0-47.51

---------------
linux (5.15.0-47.51) jammy; urgency=medium

  * jammy/linux: 5.15.0-47.51 -proposed tracker (LP: #1983903)

  * Jammy update: v5.15.46 upstream stable release (LP: #1981864)
    - UBUNTU: [Packaging] Move python3-dev to build-depends

  * touchpad and touchscreen doesn't work at all on ACER Spin 5 (SP513-54N)
    (LP: #1884232)
    - x86/PCI: Eliminate remove_e820_regions() common subexpressions
    - x86: Log resource clipping for E820 regions
    - x86/PCI: Clip only host bridge windows for E820 regions
    - x86/PCI: Add kernel cmdline options to use/ignore E820 reserved regions
    - x86/PCI: Disable E820 reserved region clipping via quirks
    - x86/PCI: Revert "x86/PCI: Clip only host bridge windows for E820 regions"

  * [SRU][H/OEM-5.13/OEM-5.14/U][J/OEM-5.17/U] Fix invalid MAC address after
    hotplug tbt dock (LP: #1942999)
    - SAUCE: igc: wait for the MAC copy when enabled MAC passthrough

  * Mass Storage Gadget driver truncates device >2TB (LP: #1981390)
    - usb: gadget: storage: add support for media larger than 2T

  * AMD Rembrandt: DP tunneling fails with Thunderbolt monitors (LP: #1983143)
    - SAUCE: drm/amd: Fix DP Tunneling with Thunderbolt monitors
    - drm/amd/display: Fix for dmub outbox notification enable
    - Revert "drm/amd/display: Fix DPIA outbox timeout after S3/S4/reset"
    - drm/amd/display: Reset link encoder assignments for GPU reset
    - drm/amd/display: Fix DPIA outbox timeout after S3/S4/reset
    - drm/amd/display: Fix new dmub notification enabling in DM
    - SAUCE: thunderbolt: Add DP out resource when DP tunnel is discovered.

  * Fix sub-optimal I210 network speed (LP: #1976438)
    - igb: Make DMA faster when CPU is active on the PCIe link

  * e1000e report hardware hang (LP: #1973104)
    - e1000e: Enable GPT clock before sending message to CSME
    - Revert "e1000e: Fix possible HW unit hang after an s0ix exit"

  * ioam6.sh in net from ubuntu_kernel_selftests fails with 5.15 kernels in
    Focal (LP: #1982930)
    - selftests: net: fix IOAM test skip return code

  * Additional fix for TGL + AUO panel flickering (LP: #1983297)
    - Revert "UBUNTU: SAUCE: drm/i915/display/psr: Fix flicker on TGL + AUO panel"
    - drm/i915/display: Fix sel fetch plane offset calculation
    - drm/i915: Nuke ORIGIN_GTT
    - drm/i915/display: Drop PSR support from HSW and BDW
    - drm/i915/display/psr: Handle plane and pipe restrictions at every page flip
    - drm/i915/display/psr: Do full fetch when handling multi-planar formats
    - drm/i915/display: Drop unnecessary frontbuffer flushes
    - drm/i915/display: Handle frontbuffer rendering when PSR2 selective fetch is
      enabled
    - drm/i915/display: Fix glitches when moving cursor with PSR2 selective fetch
      enabled
    - SAUCE: drm/i915/display/psr: Reinstate fix for TGL + AUO panel flicker

  * AMD Yellow Carp DMCUB fw update for s0i3 B0 fixes (LP: #1957026)
    - drm/amd/display: Optimize bandwidth on following fast update
    - drm/amd/display: Fix surface optimization regression on Carrizo
    - drm/amd/display: Reset DMCUB before HW init

  * GPIO character devi...

Changed in linux (Ubuntu Jammy):
status: Fix Committed → Fix Released
Timo Aaltonen (tjaalton)
Changed in hwe-next:
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package linux-oem-5.17 - 5.17.0-1016.17

---------------
linux-oem-5.17 (5.17.0-1016.17) jammy; urgency=medium

  * jammy/linux-oem-5.17: 5.17.0-1016.17 -proposed tracker (LP: #1983905)

  * drm/i915, turbostat: Support for ADL-N, RPL-P (LP: #1987265)
    - tools/power turbostat: Introduce support for RaptorLake
    - tools/power turbostat: Support RAPTORLAKE P
    - drm/i915/rpl-s: Add stepping info
    - drm/i915: Add RPL-S PCI IDs
    - drm/i915/adl-n: Enable ADL-N platform
    - drm/i915/rpl-p: Add PCI IDs
    - drm/i915/adl-n: Add PCH Support for Alder Lake N
    - drm/i915/adl-n: Add stepping info

  * CVE-2021-33655
    - fbcon: Disallow setting font bigger than screen size
    - fbcon: Prevent that screen size is smaller than font size
    - fbmem: Check virtual screen sizes in fb_set_var()

  * Add proper runtime PM support to Realtek PCIe cardreader (LP: #1963615)
    - misc: rtsx: Rework runtime power management flow
    - misc: rtsx: Cleanup power management ops
    - misc: rtsx: Quiesce rts5249 on system suspend
    - misc: rtsx: conditionally build rtsx_pm_power_saving()
    - misc: rtsx: rts522a rts5228 rts5261 support Runtime PM

  * Fix non-working I219 ethernet after s2idle (LP: #1986751)
    - Revert "e1000e: Fix possible HW unit hang after an s0ix exit"

  * Fix invalid MAC address after hotplug tbt dock (LP: #1942999)
    - SAUCE: igc: wait for the MAC copy when enabled MAC passthrough

  * AMD Rembrandt: DP tunneling fails with Thunderbolt monitors (LP: #1983143)
    - drm/amd/display: Fix new dmub notification enabling in DM
    - SAUCE: thunderbolt: Add DP out resource when DP tunnel is discovered.

  * Enable speaker and mute LEDs for HP laptops (LP: #1982990)
    - ALSA: hda/realtek: Enable speaker and mute LEDs for HP laptops

  * Fix drm/amd/pm: enable ASPM by default (LP: #1966680)
    - drm/amd: Refactor `amdgpu_aspm` to be evaluated per device
    - drm/amd: Use amdgpu_device_should_use_aspm on navi umd pstate switching
    - drm/amdgpu: vi: disable ASPM on Intel Alder Lake based systems

  * CVE-2021-33061
    - ixgbe: add the ability for the PF to disable VF link state
    - ixgbe: add improvement for MDD response functionality
    - ixgbevf: add disable link state

  [ Ubuntu: 5.17.0-8.8~22.04.8 ]

  * jammy/linux-hwe-5.17: 5.17.0-8.8~22.04.8 -proposed tracker (LP: #1983907)
  * Packaging resync (LP: #1786013)
    - debian/dkms-versions -- update from kernel-versions (main/2022.08.08)
  * GPIO character device v1 API not enabled in kernel (LP: #1953613)
    - [Config] Enable CONFIG_GPIO_CDEV_V1
  * refactoring of overlayfs fix to properly support shiftfs (LP: #1983640)
    - SAUCE: for aufs mmap: print the virtual file path
    - SAUCE: overlayfs: fix incorrect mnt_id of files opened from map_files
  * Audio mute key (f5) LED and Mic mute key (f8) LED are no function on HP
    440/450/640/650 G9 (LP: #1982716)
    - ALSA: hda/realtek: fix mute/micmute LEDs for HP machines

 -- Timo Aaltonen <email address hidden> Mon, 22 Aug 2022 13:50:21 +0300

Changed in linux-oem-5.17 (Ubuntu Jammy):
status: Fix Committed → Fix Released
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the linux-nvidia/5.15.0-1006.6 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-jammy' to 'verification-done-jammy'. If the problem still exists, change the tag 'verification-needed-jammy' to 'verification-failed-jammy'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

koba (kobako)
tags: added: verification-done-jammy
Changed in linux (Ubuntu):
status: In Progress → Fix Released
Changed in linux (Ubuntu Kinetic):
status: New → Fix Released
Changed in linux-oem-5.14 (Ubuntu Kinetic):
status: New → Invalid
Changed in linux-oem-5.17 (Ubuntu Kinetic):
status: New → Invalid
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the linux-mtk/5.15.0-1030.34 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-jammy-linux-mtk' to 'verification-done-jammy-linux-mtk'. If the problem still exists, change the tag 'verification-needed-jammy-linux-mtk' to 'verification-failed-jammy-linux-mtk'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: kernel-spammed-jammy-linux-mtk-v2 verification-needed-jammy-linux-mtk
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.