gnome-weather fails to use dark theme

Bug #1967630 reported by Erich Eickmeyer
58
This bug affects 9 people
Affects Status Importance Assigned to Milestone
gnome-weather (Ubuntu)
Fix Released
Medium
Jeremy Bícha
Jammy
Fix Released
Medium
Jeremy Bícha

Bug Description

Impact
------
GNOME Weather uses the light theme regardless of whether the dark theme is selected in the GNOME Settings app.

Also, GNOME Weather won't run correctly if gir1.2-gweather-4.0 or gir1.2-gnomedesktop-4.0 are installed because the code wasn't specific about which it needed.

It would show a warning like this when run from the command line:
Requiring GnomeDesktop but it has 2 versions available; use imports.gi.versions to pick one

Test Case
--------
sudo apt install --mark-auto gir1.2-gweather-4.0 gir1.2-gnomedesktop-4.0

Run gnome-weather and verify that the app works correctly.

Open gnome-control-center. Switch to the Appearance panel and change the color style from light to dark and verify that the app changes its appearance to match.

sudo apt autoremove

What Could Go Wrong
-------------------
These are minimal fixes.

GNOME Weather is shipped by default with Ubuntu MATE.

ProblemType: Bug
DistroRelease: Ubuntu 22.04
Package: gnome-weather 41.0-3
ProcVersionSignature: Ubuntu 5.15.0-23.23-lowlatency 5.15.27
Uname: Linux 5.15.0-23-lowlatency x86_64
NonfreeKernelModules: nvidia_modeset nvidia
ApportVersion: 2.20.11-0ubuntu80
Architecture: amd64
CasperMD5CheckResult: pass
CurrentDesktop: ubuntu:GNOME
Date: Sat Apr 2 12:20:22 2022
InstallationDate: Installed on 2021-08-19 (226 days ago)
InstallationMedia: Ubuntu 21.10 "Impish Indri" - Alpha amd64 (20210818)
PackageArchitecture: all
ProcEnviron:
 TERM=xterm-256color
 PATH=(custom, no user)
 XDG_RUNTIME_DIR=<set>
 LANG=en_US.UTF-8
 SHELL=/bin/bash
SourcePackage: gnome-weather
UpgradeStatus: No upgrade log present (probably fresh install)

Revision history for this message
Erich Eickmeyer (eeickmeyer) wrote :
Jeremy Bícha (jbicha)
Changed in gnome-weather (Ubuntu Jammy):
assignee: nobody → Jeremy Bicha (jbicha)
status: New → Triaged
importance: Undecided → Low
Revision history for this message
Brian Murray (brian-murray) wrote :

This makes sense as an SRU and doesn't need fixing for the release.

Changed in gnome-weather (Ubuntu Jammy):
milestone: ubuntu-22.04 → ubuntu-22.04.1
Jeremy Bícha (jbicha)
description: updated
Changed in gnome-weather (Ubuntu Jammy):
importance: Low → Medium
status: Triaged → In Progress
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Erich, or anyone else affected,

Accepted gnome-weather into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-weather/41.0-3ubuntu2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in gnome-weather (Ubuntu Jammy):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-jammy
Revision history for this message
MD Intisar (mdintisar) wrote :

I have enabled the proposed updates and the new update to gnome-weather has fixed the dark theming issue that I was facing. Thank you.

Revision history for this message
Gérard Bigot (gerard-bigot) wrote :

Same.

-proposed update and gnome-weather has a dark theme.

Thanks

Revision history for this message
Jeremy Bícha (jbicha) wrote :

I installed gnome-weather 41.0-3ubuntu2 and verified that switching to the dark theme and light theme work as expected. Also, the app continues to run fine if gir1.2-gweather-4.0 and gir1.2-gnomedesktop-4.0 are installed.

tags: added: verification-done verification-done-jammy
removed: verification-needed verification-needed-jammy
Revision history for this message
Erich Eickmeyer (eeickmeyer) wrote :

I also installed gnome-weather 41.0-3ubuntu2 and checked with dark and light yaru themes, worked as expected.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-weather - 41.0-3ubuntu2

---------------
gnome-weather (41.0-3ubuntu2) jammy; urgency=medium

  * Fix GNOME 42 dark theme patch (LP: #1967630)
  * Add patch to specify import versions for gweather and gnome-desktop

 -- Jeremy Bicha <email address hidden> Wed, 20 Apr 2022 20:38:56 -0400

Changed in gnome-weather (Ubuntu):
status: Fix Committed → Fix Released
Changed in gnome-weather (Ubuntu Jammy):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of the Stable Release Update for gnome-weather has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.