Mahara

General page instructions lost when there are specific instructions are set

Bug #1969257 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Dianne Tennent
Mahara 22.04.0

Bug Description

This is a regression introduced in bug #1955600: When there are specific page instructions set, the general text "This is a preview of your page. Changes are saved automatically..." is removed. This shouldn't happen because this text, especially also the accessible text is important to keep.

To replicate:

1. Create a new page.
2. View it in 'Edit mode'. The general information on editing a page are displayed, starting with 'This is a preview...".
3. Add instructions via 'Settings' -> 'Advanced'.

Results:
- Expected: The general information text is still displayed when switching to 'Edit' mode.
- Actual: The general information text is removed.

Tags: regression
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/12614

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/c/mahara/+/12614
Committed: https://git.mahara.org/mahara/mahara/commit/2bcbad95b1ebcf8e342eed32f9eaee4ae42fac07
Submitter: "Gold <email address hidden>"
Branch: main

commit 2bcbad95b1ebcf8e342eed32f9eaee4ae42fac07
Author: Dianne Tennent <email address hidden>
Date: Wed Apr 20 12:21:29 2022 +1200

Bug 1969257: General page instructions stay visible

Even when there are custom page instructions added in
the advanced settings, allow the general page instructions
to still be visible when in 'Edit' mode.

Change-Id: I5cc982309af76fd0210a145188a778560fc321e6

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "22.04_DEV" branch: https://reviews.mahara.org/c/mahara/+/12640

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/c/mahara/+/12640
Committed: https://git.mahara.org/mahara/mahara/commit/c053adbf05730e56a67e1cfe7a11521f27e3ea81
Submitter: "Robert Lyon <email address hidden>"
Branch: 22.04_DEV

commit c053adbf05730e56a67e1cfe7a11521f27e3ea81
Author: Dianne Tennent <email address hidden>
Date: Wed Apr 20 12:21:29 2022 +1200

Bug 1969257: General page instructions stay visible

Even when there are custom page instructions added in
the advanced settings, allow the general page instructions
to still be visible when in 'Edit' mode.

Change-Id: I5cc982309af76fd0210a145188a778560fc321e6
(cherry picked from commit 2bcbad95b1ebcf8e342eed32f9eaee4ae42fac07)

Robert Lyon (robertl-9)
Changed in mahara:
status: Confirmed → Fix Committed
milestone: 22.04rc2 → 22.04.0
Gold (gold.catalyst)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.