Mahara

Maroon theme menu highlight looks weird after accessibility improvements to html

Bug #1969538 reported by Dianne Tennent
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Evonne Cheung
Mahara 22.04.0

Bug Description

Now that each menu item is a single button, rather than two clickable elements (word and chevron), it seems weird that the chevron is highlighted differently than the word, as they are now one clickable element.

See attached screenshot.

Revision history for this message
Dianne Tennent (dianne-t) wrote :
Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

What is your take on that, Evonne? The lighter colour works well when the sub menu is expanded as it matches the colour of the sub menu.

Thank you
Kristina

Changed in mahara:
assignee: nobody → Evonne Cheung (evonne)
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/12627

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/c/mahara/+/12627
Committed: https://git.mahara.org/mahara/mahara/commit/d87622f3255b39bb5f7d0e6086cac41a3849be72
Submitter: "Robert Lyon <email address hidden>"
Branch: main

commit d87622f3255b39bb5f7d0e6086cac41a3849be72
Author: Evonne <email address hidden>
Date: Thu Apr 21 17:12:59 2022 +1200

Bug 1969538 Menu dropdown arrow highlight

Changed in raw so that it no longer sticks to the focus/hover state
background behind the arrow.

behatnotneeded

Change-Id: I5df21fa8e57a870bb12a998878965214693db209

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "22.04_DEV" branch: https://reviews.mahara.org/c/mahara/+/12642

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/c/mahara/+/12642
Committed: https://git.mahara.org/mahara/mahara/commit/fd1acd3390287716637de246aee55ea44fa9a0af
Submitter: "Robert Lyon <email address hidden>"
Branch: 22.04_DEV

commit fd1acd3390287716637de246aee55ea44fa9a0af
Author: Evonne <email address hidden>
Date: Thu Apr 21 17:12:59 2022 +1200

Bug 1969538 Menu dropdown arrow highlight

Changed in raw so that it no longer sticks to the focus/hover state
background behind the arrow.

behatnotneeded

Change-Id: I5df21fa8e57a870bb12a998878965214693db209
(cherry picked from commit d87622f3255b39bb5f7d0e6086cac41a3849be72)

Robert Lyon (robertl-9)
Changed in mahara:
milestone: none → 22.04.0
importance: Undecided → Medium
status: New → Fix Committed
Gold (gold.catalyst)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.