Mahara

'Default' theme doesn't have background when dragging a block

Bug #1969722 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Evonne Cheung
Mahara 22.04.0

Bug Description

When you drag a block, there is a dashed border and a light grey background in 'Raw' and all other themes bug 'Default'.

In https://reviews.mahara.org/c/mahara/+/12611 Robert is fixing the dashed border so that it is always dark. Without the '!important' it would not be dark when you drag a block but only when you view a block and it's not moved.

Attached is a short video showing what dragging a block in 'Raw' looks like with the grey background and what it looks like in 'Default' where there is no grey background.

Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :
Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/12631

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/c/mahara/+/12631
Committed: https://git.mahara.org/mahara/mahara/commit/2967d5602a54e4fdd875ad1b5a69918c8342a7ef
Submitter: "Robert Lyon <email address hidden>"
Branch: main

commit 2967d5602a54e4fdd875ad1b5a69918c8342a7ef
Author: Evonne Cheung <email address hidden>
Date: Fri Apr 22 10:52:55 2022 +1200

Bug 1969722 Background colour when dragging a block

Changed in raw to not be the card-header-bg which can sometimes be
white, changed to lightest gray.

Change-Id: I60a1f515bcfb2e230188dbcf8468df0b50101566

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "22.04_DEV" branch: https://reviews.mahara.org/c/mahara/+/12651

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/c/mahara/+/12651
Committed: https://git.mahara.org/mahara/mahara/commit/7b4dd218d6771a54e6dc2d46019593fe89c531eb
Submitter: "Robert Lyon <email address hidden>"
Branch: 22.04_DEV

commit 7b4dd218d6771a54e6dc2d46019593fe89c531eb
Author: Evonne Cheung <email address hidden>
Date: Fri Apr 22 10:52:55 2022 +1200

Bug 1969722 Background colour when dragging a block

Changed in raw to not be the card-header-bg which can sometimes be
white, changed to lightest gray.

Change-Id: I60a1f515bcfb2e230188dbcf8468df0b50101566
(cherry picked from commit 2967d5602a54e4fdd875ad1b5a69918c8342a7ef)

Robert Lyon (robertl-9)
Changed in mahara:
status: Confirmed → Fix Committed
milestone: 22.04rc2 → 22.04.0
Gold (gold.catalyst)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.