Ubuntu
gnome-shell-extension-ubuntu-dock package

Ubuntu-dock does not work when using Turkish Language

Bug #1969838 reported by Kaan Büyükerdem on 2022-04-21

This bug affects 1 person

	Status	Importance	Assigned to
Dash to dock	Unknown	Unknown	auto-github-micheleg-dash-to-dock #1687
gjs (Ubuntu)	Fix Released	Critical	Marco Trevisan (Treviño)
Jammy	Fix Released	Critical	Marco Trevisan (Treviño)
gnome-shell-extension-ubuntu-dock (Ubuntu)	Invalid	Undecided	Unassigned

Bug Description

[ Impact ]

Ubuntu dock doesn't work when Turkish language is selected.

Issue on dash-to-dock's github: https://github.com/micheleg/dash-to-dock/issues/1687
Ubuntu version: Ubuntu 22.04 LTS
gnome-shell-extension-ubuntu-dock version: 72~ubuntu5

[ Test case ]
- Run ubuntu session
- Ubuntu dock should be visible on a screen edge

Alternatively:

Save this test case in a file (i.e. /tmp/test.js):

const { GLib, GObject } = imports.gi;
const ImplicitProp = GObject.registerClass({
    Properties: {
        "prop-int": GObject.ParamSpec.uint(
            "prop-int", "prop-int", "prop-int",
            GObject.ParamFlags.READWRITE | GObject.ParamFlags.CONSTRUCT_ONLY,
            0, GLib.MAXUINT32, 55),
    },
}, class DashToDock extends GObject.Object { });
if (new ImplicitProp().propInt === undefined)
    throw new Error("Missing property")
print('All good');

In a terminal run:
LC_ALL=tr_TR gjs /tmp/test.js

The script should work without throwing any error.

[ Regression potential ]

Implicit properties on GJS may be wrongly computed, and further objects could have undefined properties.

See original description

Tags:

Revision history for this message

Kaan Büyükerdem (kaanyalova) wrote on 2022-04-21:

Desktop when Turkish Language is selected Edit (482.4 KiB, image/png)

summary:

- Ubuntu-dock not working when using Turkish Language
+ Ubuntu-dock does not work when using Turkish Language

Daniel van Vugt (vanvugt) on 2022-04-22

tags:	added: jammy
Changed in gnome-shell-extension-ubuntu-dock (Ubuntu):
status:	New → Confirmed

Marco Trevisan (Treviño) (3v1n0) on 2022-04-28

Changed in gnome-shell-extension-ubuntu-dock (Ubuntu):
status:	Confirmed → Invalid
Changed in gjs (Ubuntu):
status:	New → In Progress
importance:	Undecided → Critical
assignee:	nobody → Marco Trevisan (Treviño) (3v1n0)

Marco Trevisan (Treviño) (3v1n0) on 2022-04-28

description:	updated
tags:	added: rls-jj-tracking

Marco Trevisan (Treviño) (3v1n0) on 2022-04-28

Changed in gjs (Ubuntu Jammy):
status:	New → In Progress
importance:	Undecided → Critical
assignee:	nobody → Marco Trevisan (Treviño) (3v1n0)

Revision history for this message

Launchpad Janitor (janitor) wrote on 2022-04-29:

This bug was fixed in the package gjs - 1.72.0-3

---------------
gjs (1.72.0-3) unstable; urgency=medium

* debian/patches: Correctly generate camelCase properties on all locales.
And particularly looking at Turkish one. (LP: #1969838)

-- Marco Trevisan (Treviño) <email address hidden> Thu, 28 Apr 2022 22:24:50 +0200

Changed in gjs (Ubuntu):
status:	In Progress → Fix Released

Revision history for this message

Timo Aaltonen (tjaalton) wrote on 2022-05-03: Please test proposed package

Hello Kaan, or anyone else affected,

Accepted gjs into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gjs/1.72.0-3~ubuntu22.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in gjs (Ubuntu Jammy):
status:	In Progress → Fix Committed
tags:	added: verification-needed verification-needed-jammy

Revision history for this message

Jeremy Bícha (jbicha) wrote on 2022-05-11:

I installed language-pack-gnome-tr. I opened the Settings app and switched the language to Turkish. I logged out and logged back in. The Ubuntu Dock was missing.

I installed the gjs updates. I logged out and logged back in. The Ubuntu Dock works again.

I also verified that the test.js script failed before the update but works after the update.

tags:

added: verification-done verification-done-jammy
removed: verification-needed verification-needed-jammy

Revision history for this message

Launchpad Janitor (janitor) wrote on 2022-05-11:

This bug was fixed in the package gjs - 1.72.0-3~ubuntu22.04.1

---------------
gjs (1.72.0-3~ubuntu22.04.1) jammy; urgency=medium

* No-change backport to jammy

gjs (1.72.0-3) unstable; urgency=medium

* debian/patches: Correctly generate camelCase properties on all locales.
And particularly looking at Turkish one. (LP: #1969838)

gjs (1.72.0-2) unstable; urgency=medium

* Upload to unstable

-- Marco Trevisan (Treviño) <email address hidden> Thu, 28 Apr 2022 22:31:00 +0200

Changed in gjs (Ubuntu Jammy):
status:	Fix Committed → Fix Released

Revision history for this message

Brian Murray (brian-murray) wrote on 2022-05-11: Update Released

The verification of the Stable Release Update for gjs has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Marco Trevisan (Treviño) (3v1n0) on 2022-07-08

no longer affects:

gnome-shell-extension-ubuntu-dock (Ubuntu Jammy)