Ubuntu
xserver-xorg-video-intel package

Patch to make the intel driver aware of the fujitsu-laptop /sys interface

Bug #197620 reported by Khashayar Naderehvandi
4
Affects Status Importance Assigned to Milestone
xserver-xorg-video-intel (Ubuntu)
Fix Released
Low
Bryce Harrington

Bug Description

Since kernel 2.6.24 there is a fujitsu-laptop module that enables backlight control on some intel fujitsu laptops. The small patch that is attached enables the xbacklight tool to use this interface and control the backlight.

The patch is incredibly small, it just adds one line, and something like this will probably be included in the intel driver upstream anyway.

Tags: cherry-pick
Revision history for this message
Khashayar Naderehvandi (khashayar) wrote :
Revision history for this message
unggnu (unggnu) wrote :

Do you have any documentation for your patch or source?

Changed in xserver-xorg-video-intel:
status: New → Incomplete
Revision history for this message
Khashayar Naderehvandi (khashayar) wrote :

Hi,
No, in an email, Jesse Barnes suggested I'd add that line to the intel driver source code in order to make things work. I said I could do this in the meanwhile, until the bug gets fixed. However, I might have misunderstood things and the bug might in the end be fixed in the xbacklight utility and not the intel driver, I wouldn't know.

In any case the patch is so tiny - it only adds one line to a list that already includes "thinkpad_screen","acpi_video1", and "acpi_video0" - that it should be easily maintainable. The gains are simply that the xbacklight utility would work on fujitsu-platforms, and perhaps that not *very* important.

Alright, long story short: No documentation :-)

Revision history for this message
Khashayar Naderehvandi (khashayar) wrote :

Update: The patch is now in current git:
http://gitweb.freedesktop.org/?p=xorg/driver/xf86-video-intel.git;a=commit;h=e04908853db74dc76718f6bc0dfb23b5ab3c5837

Please consider adding it to the intel driver.

unggnu (unggnu)
Changed in xserver-xorg-video-intel:
status: Incomplete → Confirmed
Revision history for this message
Bryce Harrington (bryce) wrote :

Cool, thanks for seeking out a patch for this. One line patches are certainly a thing of beauty. It looks good to me, I'll verify it builds and upload it directly.

Changed in xserver-xorg-video-intel:
assignee: nobody → bryceharrington
importance: Undecided → Low
status: Confirmed → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package xserver-xorg-video-intel - 2:2.2.1-1ubuntu9

---------------
xserver-xorg-video-intel (2:2.2.1-1ubuntu9) hardy; urgency=low

  * debian/patches/14_sysfs_fujitsu_backlight.patch:
    - Add sysfs backlight support for Fujitsu laptops (LP: #197620)

 -- Bryce Harrington <email address hidden> Fri, 04 Apr 2008 20:02:03 -0700

Changed in xserver-xorg-video-intel:
status: In Progress → Fix Released
Revision history for this message
Khashayar Naderehvandi (khashayar) wrote :

>Cool, thanks for seeking out a patch for this.

Glad to help!

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.