Mahara

PHP 8 Compatibility: webservice

Bug #1976432 reported by Gold
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Wishlist
Gold
Mahara 22.10.0

Bug Description

This is to track patchsets that will bring the codebase up to be compliant with PHP 8.1.

The initial run through will be on a top level directory basis. i.e. the directories below htdocs. It will focus on the results from the PHPStan and Phan static analysis tools.

This bug tracks files in the webservice directory.

Testing will require identifying, from the patchset, where the code is used and then verifying that that area of the site still works in both PHP 7.4 and PHP 8.1.

https://phpstan.org/
https://github.com/phan/phan

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/12961

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/12962

Revision history for this message
Gold (gold.catalyst) wrote :

Yep... There's 2 reviews here. My bad. 12962 is a child of 12961 though so things shouldn't be an issue.

Changed in mahara:
status: Confirmed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/c/mahara/+/12962
Committed: https://git.mahara.org/mahara/mahara/commit/5b36091ebf3ea11a0890ed18b0c434b649dfe311
Submitter: "Doris Tam <email address hidden>"
Branch: main

commit 5b36091ebf3ea11a0890ed18b0c434b649dfe311
Author: Gold <email address hidden>
Date: Tue Jun 28 10:11:31 2022 +1200

Bug 1976432: PHP 8 Compatibility: webservice

Still a WIP as there is a question around session_get_instance(). The
function doesn't exist. Odds are that this code has never been hit as
there are no bug reports. This leads me to think that this should be a
stand alone bug report. Will leave this as a WIP until a decision is
made on that though.

https://git.mahara.org/mahara/mahara/-/blob/main/htdocs/webservice/lib.php#L1251

Signed-off-by: Gold <email address hidden>
Change-Id: If0c2e22e850e77536a358dbd71dc68f5ddd10f00

Doris Tam (doristam)
Changed in mahara:
status: In Progress → Fix Committed
Kristina Hoeppner (kris-hoeppner)
tags: added: newfeature
Kristina Hoeppner (kris-hoeppner)
Changed in mahara:
importance: High → Wishlist
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.