External system tries to get the remote path even when it's not enabled.
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mahara |
Fix Released
|
Medium
|
Unassigned |
Bug Description
When trying to download a file, it needs to check if an external file system is enabled before it goes off to object storage like S3 to try to download the file.
Steps to reproduce:
1. Fresh install mahara
2. Install https:/
3. Configure the plugin with test S3 crendentials
4. Ensure that Enable transfer tasks is unticked (we installed the plugin but not using it yet).
5. Add this in config.php
$cfg->externalf
"includefile
"class" => "module_
);
6. Upload an image on the artefact (site/artefact/
7. Rotate the image. It would be broken and the only way to fix is to move back orientation to 0
8. If possible, check the logs and you will see it's trying to grab a file from S3
At the moment, when downloading/
PS: this is very similar to https:/
I understand this is quite specific. Please let me know if you need more information from me.
I will create a patch for this :)
Changed in mahara: | |
status: | New → In Progress |
importance: | Undecided → Medium |
milestone: | none → 22.10.0 |
Changed in mahara: | |
status: | In Progress → Fix Committed |
Changed in mahara: | |
status: | Fix Committed → Fix Released |
Patch for "main" branch: https:/ /reviews. mahara. org/c/mahara/ +/12835