Request to back port vmci patches to Ubuntu kernel

Bug #1978145 reported by Vishnu Dasa
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
linux (Ubuntu)
Invalid
Undecided
Unassigned
Jammy
Fix Released
Medium
Unassigned

Bug Description

SRU Justification

[Impact]

The request is to bring vmci to TOT and back port the following patches into
Ubuntu kernels.

1. fac608138c6136126faadafa5554cc0bbabf3c44 ("VMCI: dma dg: whitespace formatting change for vmci register defines")
2. e283a0e8b7ea83915e988ed059384af166b444c0 ("VMCI: dma dg: add MMIO access to registers")
3. eed2298d936087a1c85e0fa6f7170028e4f4fded ("VMCI: dma dg: detect DMA datagram capability")
4. 8cb520bea1470ca205980fbf030ed1f472f4af2f ("VMCI: dma dg: set OS page size")
5. cc68f2177fcbfe2dbe5e9514789b96ba5995ec1e ("VMCI: dma dg: register dummy IRQ handlers for DMA datagrams")
6. 5ee109828e73bbe4213c373988608d8f33e03d78 ("VMCI: dma dg: allocate send and receive buffers for DMA datagrams")
7. 22aa5c7f323022477b70e044eb00e6bfea9498e8 ("VMCI: dma dg: add support for DMA datagrams sends")
8. 463713eb6164b6577f8e91447c7745628215531b ("VMCI: dma dg: add support for DMA datagrams receive")
9. 77e861619baea5a7c934e47fda74b03c0b072aec ("VMCI: Fix some error handling paths in vmci_guest_probe_device()")
10. c8e9b30ccae605bf1dbeaf03971f9b83f70b928d ("VMCI: Release notification_bitmap in error path")
11. 5df0e734b8c39598effe0f17e5bd8ff7748a0693 ("VMCI: Check exclusive_vectors when freeing interrupt 1")
12. 1f7142915d304804a9bd952245fce92786b1b62f ("VMCI: Add support for ARM64")
13. ba03a9bbd17b149c373c0ea44017f35fc2cd0f28 ("VMCI: Release resource if the work is already queued")

There is a new version of the VMCI device. Patches #1 to #11 provide support for that, see [1] for some information on what is new. #12 adds arm64 support (we only support the new version of the VMCI device in arm64, but both old and new versions of VMCI device are supported in x86). #13 is a general bugfix. All 13 patches can build on both x86 and arm64.

[1] https://<email address hidden>

[Test Case]

VMWARE tested

[Where things could go wrong]

The VMCI device driver could fail.

CVE References

Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote : Missing required logs.

This bug is missing log files that will aid in diagnosing the problem. While running an Ubuntu kernel (not a mainline or third-party kernel) please enter the following command in a terminal window:

apport-collect 1978145

and then change the status of the bug to 'Confirmed'.

If, due to the nature of the issue you have encountered, you are unable to run this command, please add a comment stating that fact and change the bug status to 'Confirmed'.

This change has been made by an automated script, maintained by the Ubuntu Kernel Team.

Changed in linux (Ubuntu):
status: New → Incomplete
Revision history for this message
Vishnu Dasa (vdasa) wrote :

Since this is a request to port patches from upstream to Ubuntu kernels,
setting the status to 'Confirmed'.

Changed in linux (Ubuntu):
status: Incomplete → Confirmed
Revision history for this message
Tim Gardner (timg-tpi) wrote :
Revision history for this message
Vishnu Dasa (vdasa) wrote :

Thanks a lot for the quick response, Tim!

We have completed our testing on x86 and it looks good from our
point of view. We are in the process of testing on arm64.
Will keep you posted on the progress.

Thanks,
Vishnu

Revision history for this message
Tim Gardner (timg-tpi) wrote :
Revision history for this message
Tim Gardner (timg-tpi) wrote :

Hi Vishnu - can you expand a bit as to the purpose of these patches ? Are they solely for the purpose of adding arm64 support ?

rtg

Revision history for this message
Vishnu Dasa (vdasa) wrote :

Hi Tim,
No, not exactly. We have a new version of the VMCI device itself and
patches #1 to #11 provide support for that, see [1] for some information
on what is new. #12 adds arm64 support (we only support the new version
of the VMCI device in arm64, but both old and new versions of VMCI
device are supported in x86). #13 is a general bugfix. All 13 patches
can build on both x86 and arm64. Please let me know if this helps.

[1] https://<email address hidden>

Thanks,
Vishnu

Tim Gardner (timg-tpi)
description: updated
description: updated
Revision history for this message
Vishnu Dasa (vdasa) wrote :

Tim,
We're seeing some unrelated issues with the arm64 test kernel you shared.
Is it possible for you to provide arm64 test kernel that is based on
5.15.0-39 instead of 5.15.0-37?

Thanks,
Vishnu

Revision history for this message
Tim Gardner (timg-tpi) wrote :

Hi Vishnu,

Try the kernel at https://kernel.ubuntu.com/~rtg/jammy-vmci-updates-lp1978145/5.15.0-41.44~lp1972662.1/. This is the kernel that will be tested for this SRU cycle. I've also updated the git repo at 'git://git.launchpad.net/~timg-tpi/ubuntu/+source/linux/+git/jammy jammy-vmci-updates-lp1978145'.

rtg

Revision history for this message
Vishnu Dasa (vdasa) wrote :

Thanks a lot, Tim! This worked and our testing went fine.

So, to sum up -- our testing on both x86 and arm64 passed and
looks good from our point of view

Thanks,
Vishnu

Stefan Bader (smb)
Changed in linux (Ubuntu Jammy):
importance: Undecided → Medium
status: New → Fix Committed
Changed in linux (Ubuntu):
status: Confirmed → Invalid
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the linux/5.15.0-41.44 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-jammy' to 'verification-done-jammy'. If the problem still exists, change the tag 'verification-needed-jammy' to 'verification-failed-jammy'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: verification-needed-jammy
Revision history for this message
Vishnu Dasa (vdasa) wrote :

I have changed the tag to verification-done-jammy as the fix has been
verified (Update #10).

tags: added: verification-done-jammy
removed: verification-needed-jammy
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (31.7 KiB)

This bug was fixed in the package linux - 5.15.0-41.44

---------------
linux (5.15.0-41.44) jammy; urgency=medium

  * jammy/linux: 5.15.0-41.44 -proposed tracker (LP: #1979448)

  * Fix can't boot up after change to vmd (LP: #1976587)
    - PCI: vmd: Assign VMD IRQ domain before enumeration
    - PCI: vmd: Revert 2565e5b69c44 ("PCI: vmd: Do not disable MSI-X remapping if
      interrupt remapping is enabled by IOMMU.")

  * [SRU][Jammy/OEM-5.17][PATCH 0/1] Fix calltrace in mac80211 (LP: #1978297)
    - mac80211: fix struct ieee80211_tx_info size

  * [SRU][Jammy][PATCH 0/1] Fix amd display corruption on s2idle resume
    (LP: #1978244)
    - drm/amd/display: Don't reinitialize DMCUB on s0ix resume

  * pl2303 serial adapter not recognized (LP: #1967493)
    - USB: serial: pl2303: fix type detection for odd device

  * Remove SAUCE patches from test_vxlan_under_vrf.sh in net of
    ubuntu_kernel_selftests (LP: #1975691)
    - Revert "UBUNTU: SAUCE: selftests: net: Don't fail test_vxlan_under_vrf on
      xfail"
    - Revert "UBUNTU: SAUCE: selftests: net: Make test for VXLAN underlay in non-
      default VRF an expected failure"

  * Fix hp_wmi_read_int() reporting error (0x05) (LP: #1979051)
    - platform/x86: hp-wmi: Fix hp_wmi_read_int() reporting error (0x05)

  * Request to back port vmci patches to Ubuntu kernel (LP: #1978145)
    - VMCI: dma dg: whitespace formatting change for vmci register defines
    - VMCI: dma dg: add MMIO access to registers
    - VMCI: dma dg: detect DMA datagram capability
    - VMCI: dma dg: set OS page size
    - VMCI: dma dg: register dummy IRQ handlers for DMA datagrams
    - VMCI: dma dg: allocate send and receive buffers for DMA datagrams
    - VMCI: dma dg: add support for DMA datagrams sends
    - VMCI: dma dg: add support for DMA datagrams receive
    - VMCI: Fix some error handling paths in vmci_guest_probe_device()
    - VMCI: Release notification_bitmap in error path
    - VMCI: Check exclusive_vectors when freeing interrupt 1
    - VMCI: Add support for ARM64
    - [Config] Update policies for VMWARE_VMCI and VMWARE_VMCI_VSOCKETS

  * [UBUNTU 20.04] rcu stalls with many storage key guests (LP: #1975582)
    - s390/gmap: voluntarily schedule during key setting
    - s390/mm: use non-quiescing sske for KVM switch to keyed guest

  * [SRU][OEM-5.14/OEM-5.17/Jammy][PATCH 0/1] Fix i915 calltrace on new ADL BIOS
    (LP: #1976214)
    - drm/i915: update new TMDS clock setting defined by VBT

  * Revert PPC get_user workaround (LP: #1976248)
    - powerpc: Export mmu_feature_keys[] as non-GPL

  * Jammy update: v5.15.39 upstream stable release (LP: #1978240)
    - MIPS: Fix CP0 counter erratum detection for R4k CPUs
    - parisc: Merge model and model name into one line in /proc/cpuinfo
    - ALSA: hda/realtek: Add quirk for Yoga Duet 7 13ITL6 speakers
    - ALSA: fireworks: fix wrong return count shorter than expected by 4 bytes
    - mmc: sdhci-msm: Reset GCC_SDCC_BCR register for SDHC
    - mmc: sunxi-mmc: Fix DMA descriptors allocated above 32 bits
    - mmc: core: Set HS clock speed before sending HS CMD13
    - gpiolib: of: fix bounds check for 'gpio-reserved-ranges'
    - x86/fpu: Prevent FPU s...

Changed in linux (Ubuntu Jammy):
status: Fix Committed → Fix Released
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the linux-gkeop-5.15/5.15.0-1003.5~20.04.2 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-focal' to 'verification-done-focal'. If the problem still exists, change the tag 'verification-needed-focal' to 'verification-failed-focal'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.