Title says it all. The patch is untested as I've run out of chroots..
laga@prometheus:~/dev/ltsp/ltsp-5.0.40~bzr20080212/server$ diff -u ltsp-update-image.orig ltsp-update-image
--- ltsp-update-image.orig 2008-03-03 23:01:22.777273251 +0100
+++ ltsp-update-image 2008-03-03 23:02:29.047118436 +0100
@@ -75,7 +75,7 @@
# Find out if we are really an nbd client and if so, build the image.
# Check and see if user's left /proc mounted in chroot. If so, issue
# a warning, and unmount it
-PROC_MOUNTED=$(chroot /opt/ltsp/i386 test -f /proc/cpuinfo && echo True)
+PROC_MOUNTED=$(chroot ${CHROOT} test -f /proc/cpuinfo && echo True)
if [ -n "${PROC_MOUNTED}" ]; then
echo "/proc mounted in chroot ${CHROOT}, Unmounting."
umount ${CHROOT}/proc
I found another smal issue in ltsp-update-image, but I don't want to open a new bug for it.
ltsp-update-image will fail if temporary files from the last run are still around. It's easy to reproduce, eg with sudo touch /opt/ltsp/
Patch:
--- ltsp-update-image 2008-03-03 23:23:13.347079242 +0100
+++ ltsp-update-
@@ -90,6 +90,7 @@
IMAGE=
rm "${IMAGE}"
+ rm "${IMAGE}.tmp"
mksquashfs "${CHROOT}" "${IMAGE}.tmp" -e cdrom
mv "${IMAGE}.tmp" "${IMAGE}"
chmod 0744 "${IMAGE}"
Both rm lines will throw ugly error messages if "${IMAGE}" or "${IMAGE}.tmp" can't be found. That's good for debugging messages, but it might confuse the user. Maybe you want to redirect them to /dev/null instead?