[SRU]Update ice driver to support E823 devices

Bug #1986717 reported by Jeff Lane 
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
linux (Ubuntu)
Invalid
Undecided
Michael Reed
Focal
Fix Released
Medium
Michael Reed

Bug Description

SRU Justification:

[Impact]

Ice driver does not support E823 in 5.4. This was introduced in 5.7, but is part of the Ice Lake D platform which is otherwise supported in 5.4. One of the hardware vendors has requested that we update Ice in 5.4 to support E823.

[Fix]

e36aeec0f4e5 ice: add support for E823 devices
5d9e618cbb54 ice: Add device ids for E822 devices

[Testcase]

Load ice driver on system with E823 device present and ensure the device is seen by the system

[Where problems could occur]

The regression risk is low
These patches did not cherry pick cleanly I had to make some minor changes.

Other Info:

https://code.launchpad.net/~mreed8855/ubuntu/+source/linux/+git/focal/+ref/e823_intel_3

Jeff Lane  (bladernr)
Changed in linux (Ubuntu):
assignee: nobody → Jeff Lane  (bladernr)
tags: added: servcert-456
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote : Missing required logs.

This bug is missing log files that will aid in diagnosing the problem. While running an Ubuntu kernel (not a mainline or third-party kernel) please enter the following command in a terminal window:

apport-collect 1986717

and then change the status of the bug to 'Confirmed'.

If, due to the nature of the issue you have encountered, you are unable to run this command, please add a comment stating that fact and change the bug status to 'Confirmed'.

This change has been made by an automated script, maintained by the Ubuntu Kernel Team.

Changed in linux (Ubuntu):
status: New → Incomplete
Jeff Lane  (bladernr)
description: updated
Changed in linux (Ubuntu):
status: Incomplete → In Progress
Revision history for this message
Michael Reed (mreed8855) wrote : Re: Update ice driver to support E823 devices

Additional Patches may be needed.

e36aeec0f4e5 ice: add support for E823 devices
af23635a5335 ice: add backslash-n to strings
7124507291cb ice: increase PF reset wait timeout to 300 milliseconds
5fa23e0b23fb ice: Support XDP UMEM wake up mechanism
31c5f7f3f45a ice: SW DCB, report correct max TC value
27d9be98eda1 ice: Report correct DCB mode
c8608b5071d0 ice: Add DCBNL ops required to configure ETS in CEE for SW DCB
36be2baa09f0 ice: Always clear the QRXFLXP_CNTXT register for VF Rx queues
a6892c96fc49 ice: Fix for TCAM entry management
9d5c5a5290d4 ice: update malicious driver detection event handling

Changed in linux (Ubuntu):
assignee: Jeff Lane  (bladernr) → Michael Reed (mreed8855)
Revision history for this message
Michael Reed (mreed8855) wrote :

I tried cherry picking e36aeec0f4e5 ice: add support for E823 devices to 5.4 and manually resolved 2 of the 3 files that need changes. The third file drivers/net/ethernet/intel/ice/ice_nvm.c has too many changes that are missing. I need Intel to provide additional patches to resolve the issue.

Revision history for this message
Michael Reed (mreed8855) wrote :

I have created a test kernel. Please test it and provide feedback.

https://people.canonical.com/~mreed/misc/lp_1986717_e823/

Michael Reed (mreed8855)
description: updated
Jeff Lane  (bladernr)
Changed in linux (Ubuntu):
status: In Progress → Incomplete
Revision history for this message
Jeff Lane  (bladernr) wrote :

Update from OEM:
Hi Rick and Jeff,

I have tested those packages. E823 can be recognized by Ubuntu 18.04.6 OS(kernel ) and i can use them to ping “www.google.com”

But the name is not complete when I use "lspci" command and some pkgs have dependency issue when I installed. “linux-cloud-tools-5.4.0-136-generic_5.4.0-136.153_amd64.deb and linux-tools-5.4.0-136-generic_5.4.0-136.153_amd64.deb”

Test result is below===

root@hakuba:~# uname -mrs
Linux 5.4.0-136-generic x86_64
root@hakuba:~#

root@hakuba:~# ethtool -i eno6
driver: ice
version: 0.8.1-k
firmware-version: 2.28 0x8001028e 0.0.0
expansion-rom-version:
bus-info: 0000:89:00.0
supports-statistics: yes
supports-test: yes
supports-eeprom-access: yes
supports-register-dump: yes
supports-priv-flags: yes
root@hakuba:~# lspci |grep -i ethernet
03:00.0 Ethernet controller: Intel Corporation Device 125d (rev 04)
04:00.0 Ethernet controller: Intel Corporation Device 125d (rev 04)
89:00.0 Ethernet controller: Intel Corporation Device 188e
89:00.1 Ethernet controller: Intel Corporation Device 188e
89:00.2 Ethernet controller: Intel Corporation Device 188e
89:00.3 Ethernet controller: Intel Corporation Device 188e
root@hakuba:~# ip a
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN group default qlen 1000
    link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
    inet 127.0.0.1/8 scope host lo
       valid_lft forever preferred_lft forever
    inet6 ::1/128 scope host
       valid_lft forever preferred_lft forever
2: eno6: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc fq_codel state UP group default qlen 1000
    link/ether 00:00:00:00:01:00 brd ff:ff:ff:ff:ff:ff
    inet 10.241.99.166/24 brd 10.241.99.255 scope global eno6
       valid_lft forever preferred_lft forever
    inet6 fe80::200:ff:fe00:100/64 scope link
       valid_lft forever preferred_lft forever
3: eno5: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN group default qlen 1000
    link/ether 00:00:00:00:01:01 brd ff:ff:ff:ff:ff:ff
4: eno4: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN group default qlen 1000
    link/ether 00:00:00:00:01:02 brd ff:ff:ff:ff:ff:ff
5: eno3: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN group default qlen 1000
    link/ether 00:00:00:00:01:03 brd ff:ff:ff:ff:ff:ff
root@hakuba:~# ping www.google.com
PING www.google.com (142.250.186.132) 56(84) bytes of data.
64 bytes from fra24s07-in-f4.1e100.net (142.250.186.132): icmp_seq=1 ttl=105 time=266 ms
64 bytes from fra24s07-in-f4.1e100.net (142.250.186.132): icmp_seq=2 ttl=105 time=266 ms
64 bytes from fra24s07-in-f4.1e100.net (142.250.186.132): icmp_seq=3 ttl=105 time=265 ms
64 bytes from fra24s07-in-f4.1e100.net (142.250.186.132): icmp_seq=4 ttl=105 time=265 ms
64 bytes from fra24s07-in-f4.1e100.net (142.250.186.132): icmp_seq=5 ttl=105 time=265 ms
64 bytes from fra24s07-in-f4.1e100.net (142.250.186.132): icmp_seq=6 ttl=105 time=265 ms

Michael Reed (mreed8855)
Changed in linux (Ubuntu):
status: Incomplete → In Progress
Michael Reed (mreed8855)
summary: - Update ice driver to support E823 devices
+ [SRU}Update ice driver to support E823 devices
Changed in linux (Ubuntu Focal):
assignee: nobody → Michael Reed (mreed8855)
summary: - [SRU}Update ice driver to support E823 devices
+ [SRU]Update ice driver to support E823 devices
Michael Reed (mreed8855)
description: updated
description: updated
description: updated
description: updated
Michael Reed (mreed8855)
Changed in linux (Ubuntu Focal):
status: New → In Progress
Revision history for this message
Michael Reed (mreed8855) wrote :

This has been Acked on the kernel team mailing list

https://lists.ubuntu.com/archives/kernel-team/2023-February/137062.html

When this hits proposed please verify it works.

tags: added: verification-needed-focal
Stefan Bader (smb)
Changed in linux (Ubuntu Focal):
importance: Undecided → Medium
Changed in linux (Ubuntu):
status: In Progress → Invalid
Stefan Bader (smb)
Changed in linux (Ubuntu Focal):
status: In Progress → Fix Committed
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the linux/5.4.0-145.162 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-focal' to 'verification-done-focal'. If the problem still exists, change the tag 'verification-needed-focal' to 'verification-failed-focal'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: kernel-spammed-focal-linux
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package linux - 5.4.0-146.163

---------------
linux (5.4.0-146.163) focal; urgency=medium

  * focal/linux: 5.4.0-146.163 -proposed tracker (LP: #2012094)

  * NFS deathlock with last Kernel 5.4.0-144.161 and 5.15.0-67.74 (LP: #2009325)
    - NFS: Correct timing for assigning access cache timestamp

linux (5.4.0-145.162) focal; urgency=medium

  * focal/linux: 5.4.0-145.162 -proposed tracker (LP: #2008389)

  * [SRU]Update ice driver to support E823 devices (LP: #1986717)
    - ice: Add device ids for E822 devices
    - ice: add support for E823 devices

  * btrfs/154: rename fails with EOVERFLOW when calculating item size during
    item key collision (LP: #2004132)
    - btrfs: correctly calculate item size used when item key collision happens

  * rtcpie in timers from ubuntu_kernel_selftests randomly failing
    (LP: #1814234)
    - SAUCE: selftest: rtcpie: Force passing unreliable subtest

  * [UBUNTU 20.04] KVM: s390: pv: don't allow userspace to set the clock under
    PV - kernel part (LP: #1999882)
    - KVM: s390x: fix SCK locking
    - KVM: s390: pv: don't allow userspace to set the clock under PV

  * CVE-2021-3669
    - ipc: replace costly bailout check in sysvipc_find_ipc()

  * net:fcnal-test.sh 'nettest' command not found on F/K (LP: #2006391)
    - selftests/net: Find nettest in current directory

  * xfs: Preallocated ioend transactions cause deadlock due to log buffer
    exhaustion (LP: #2007219)
    - xfs: drop submit side trans alloc for append ioends

  * CVE-2022-4382
    - USB: gadgetfs: Fix race between mounting and unmounting

  * CVE-2022-2196
    - KVM: VMX: Execute IBPB on emulated VM-exit when guest has IBRS

  * ubuntu_kernel_selftests: net:udpgso_bench.sh failed (LP: #1951447)
    - selftests: net: udpgso_bench: Fix racing bug between the rx/tx programs

  * net:fcnal-test.sh didn't return a non-zero value even with some sub-tests
    failed (LP: #2006692)
    - selftests: net/fcnal-test.sh: add exit code

  * Fix selftests/ftracetests/Meta-selftests in Focal (LP: #2006453)
    - SAUCE: Fix ftrace/Meta-selftests bashism check

  * CVE-2023-23559
    - wifi: rndis_wlan: Prevent buffer overflow in rndis_query_oid

 -- Luke Nowakowski-Krijger <email address hidden> Fri, 17 Mar 2023 11:08:20 -0700

Changed in linux (Ubuntu Focal):
status: Fix Committed → Fix Released
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the linux-aws/5.4.0-1100.108 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-focal' to 'verification-done-focal'. If the problem still exists, change the tag 'verification-needed-focal' to 'verification-failed-focal'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: kernel-spammed-focal-linux-aws
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the linux-azure/5.4.0-1106.112 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-focal' to 'verification-done-focal'. If the problem still exists, change the tag 'verification-needed-focal' to 'verification-failed-focal'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: kernel-spammed-focal-linux-azure
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the linux-bluefield/5.4.0-1060.66 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-focal' to 'verification-done-focal'. If the problem still exists, change the tag 'verification-needed-focal' to 'verification-failed-focal'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: kernel-spammed-focal-linux-bluefield
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the linux-xilinx-zynqmp/5.4.0-1023.27 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-focal' to 'verification-done-focal'. If the problem still exists, change the tag 'verification-needed-focal' to 'verification-failed-focal'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: kernel-spammed-focal-linux-xilinx-zynqmp
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.