Ubuntu
dh-cargo package

Add support for vendored build-dependency tracking

Bug #1987515 reported by Simon Chopin on 2022-08-24

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	dh-cargo (Ubuntu)	Fix Released	Undecided	Simon Chopin

Bug Description

As part of the tentative MIR rules for Rust packages, we want to be able to embed vendored sources in the packages. This implies that there should be an easy way to divert the dh-cargo helper into using vendored dependencies if available, and also add some metadata to easily know which source package contains which vendored dependencies.

See https://github.com/cpaelzer/ubuntu-mir/pull/3 for some discussions around the topic.

See original description

Tags:

Simon Chopin (schopin) on 2022-08-24

description:

updated

Revision history for this message

Simon Chopin (schopin) wrote on 2022-08-24:

dh-cargo.debdiff Edit (8.5 KiB, text/plain)

Attached is a debdiff for review purposes. DO NOT UPLOAD, since it's missing the various binary files for the test case.

You'll find a full build there: https://launchpad.net/~schopin/+archive/ubuntu/test-ppa/+sourcepub/13888757/+listing-archive-extra

Changed in dh-cargo (Ubuntu):
status:	New → In Progress
assignee:	nobody → Simon Chopin (schopin)

Ubuntu Foundations Team Bug Bot (crichton) on 2022-08-24

tags:

added: patch

Revision history for this message

Julian Andres Klode (juliank) wrote on 2022-08-25:

Review:

* dh-cargo-vendored-sources.pl:
  - missing 'use strict;' and 'use warnings;' before other 'use' (compare cargo.pm)
  - should not have a .pl ending (the shell scripts don't end in .sh either)
  - sub cargo_info opens a file but does not close it

Revision history for this message

Launchpad Janitor (janitor) wrote on 2022-08-27:

This bug was fixed in the package dh-cargo - 28ubuntu1

---------------
dh-cargo (28ubuntu1) kinetic; urgency=medium

  * Add support for using vendored sources, including checking the validity of
    XS-Vendored-Sources-Rust field via the new dh-cargo-vendored-sources
    script, and shipping the Cargo.lock file if available. (LP: #1987515)

-- Simon Chopin <email address hidden> Thu, 25 Aug 2022 16:26:43 +0200